Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Thu, 7 Apr 2022 19:58:33 +0200 (CEST)
From:   Julia Lawall <julia.lawall@inria.fr>
To:     MAHAK GUPTA <mahak_g@cs.iitr.ac.in>
cc:     Larry.Finger@lwfinger.net, florian.c.schilhabel@googlemail.com,
        gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org, outreachy@lists.linux.dev
Subject: Re: [PATCH] staging: rtl8712: fix camel case in function
 r8712_generate_ie
In-Reply-To: <CANnaPbD7C8kvz-fK4js=zprck58=Yxp8h+wBLmXfQNKsHMDytw@mail.gmail.com>
Message-ID: <alpine.DEB.2.22.394.2204071958000.2279@hadrien>
References: <20220407120945.31030-1-mahak_g@cs.iitr.ac.in> <alpine.DEB.2.22.394.2204071414080.2213@hadrien> <CANnaPbD7C8kvz-fK4js=zprck58=Yxp8h+wBLmXfQNKsHMDytw@mail.gmail.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk


On Thu, 7 Apr 2022, MAHAK GUPTA wrote:

> On Thu, Apr 7, 2022 at 5:44 PM Julia Lawall <julia.lawall@inria.fr> wrote:
> >
> >
> >
> > On Thu, 7 Apr 2022, Mahak Gupta wrote:
> >
> > > Adhere to linux kernel coding style.
> > >
> > > Reported by checkpatch:
> > >
> > > CHECK: Avoid CamelCase: <beaconPeriod>
> >
> > As another patch, you could also adjust the structure field name.
> >
> > julia
> >
> > >
> > > Signed-off-by: Mahak Gupta <mahak_g@cs.iitr.ac.in>
> > > ---
> > >  drivers/staging/rtl8712/ieee80211.c | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/staging/rtl8712/ieee80211.c b/drivers/staging/rtl8712/ieee80211.c
> > > index f926809b1021..7d8f1a29d18a 100644
> > > --- a/drivers/staging/rtl8712/ieee80211.c
> > > +++ b/drivers/staging/rtl8712/ieee80211.c
> > > @@ -162,13 +162,13 @@ int r8712_generate_ie(struct registry_priv *registrypriv)
> > >       uint sz = 0;
> > >       struct wlan_bssid_ex *dev_network = &registrypriv->dev_network;
> > >       u8 *ie = dev_network->IEs;
> > > -     u16 beaconPeriod = (u16)dev_network->Configuration.BeaconPeriod;
> > > +     u16 beacon_period = (u16)dev_network->Configuration.BeaconPeriod;
> > >
> > >       /*timestamp will be inserted by hardware*/
> > >       sz += 8;
> > >       ie += sz;
> > >       /*beacon interval : 2bytes*/
> > > -     *(__le16 *)ie = cpu_to_le16(beaconPeriod);
> > > +     *(__le16 *)ie = cpu_to_le16(beacon_period);
> > >       sz += 2;
> > >       ie += 2;
> > >       /*capability info*/
> > > --
> > > 2.17.1
> > >
> > >
> > >
>
> Sure, on it. Thanks.

It's good not to top post, but you can put your response right under the
text you are responding to.

julia