Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Guo Zhengkui <guozhengkui@vivo.com>
To:     Andrew Morton <akpm@linux-foundation.org>,
        Shuah Khan <shuah@kernel.org>,
        linux-mm@kvack.org (open list:MEMORY MANAGEMENT),
        linux-kselftest@vger.kernel.org (open list:KERNEL SELFTEST FRAMEWORK),
        linux-kernel@vger.kernel.org (open list)
Cc:     zhengkui_guo@outlook.com, Guo Zhengkui <guozhengkui@vivo.com>
Subject: [PATCH] userfaultfd/selftests: use swap() instead of open coding it
Date:   Thu,  7 Apr 2022 20:31:41 +0800
Message-Id: <20220407123141.4998-1-guozhengkui@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ocL8PHDHVD7EHnxtQJk3ALfAReoAUg63E7yGNje6Olpre3d/zM+Ti4yevnJh?=
 =?us-ascii?Q?iwkoJGTC4aGxBdpKDkXNuB5AXcgshTeINrRv7S0YqSaCfyxPs9k5cgujKZb3?=
 =?us-ascii?Q?7ChMDOmTvU3xJHSukU8h0WJNUX3eHWhyqsCaMX0gpDn5NHLJGVCF1bAIbMhH?=
 =?us-ascii?Q?L7gtt3TSaqYqPVsvhO3T/U0fIuMYDYOGM0nrof155I5EOESv91B9qA5H1S2Z?=
 =?us-ascii?Q?qzaF2Uskdg0XkXQpzWTt6HoXrlUvWywQO4Gnk+nWR7z51vSmKMVQh3n0C3yf?=
 =?us-ascii?Q?We3KRNWc2Eq4xsf69jUVf56LmGZhiIxK8ISA85H5KZi0UWH1wE/vmAeurwcO?=
 =?us-ascii?Q?AsTEcj8DR3tHijaz7+AXwTm1ia9DM+omedcEjofU/zhYMyAKwYUom0i6Ctxd?=
 =?us-ascii?Q?7noXhRF1UQWhxkEuZ2B/oF5U07cwTJhz1J18ZBtCw5AX0ObJvhAXig+O60YJ?=
 =?us-ascii?Q?iwtf/XzDkByh9rYxbFLBYX3T3tEZWBD39as5whqYAq/fUcgqVAYPMqJEJaqN?=
 =?us-ascii?Q?7ASA3y/nNLXllpB69eamJDII4lNZnTnpOqTo/QcB2ASZcRlhgU50t3q4nE4w?=
 =?us-ascii?Q?bfFZnmdQHvVq/ATm1/hYJPivwVtDdkjN6Q+2XxhdKbXhtQrnEFeBsGackypt?=
 =?us-ascii?Q?73yS0uxzRYQMDhA3aflV2CmSx5IT/lVTdS4I0u2tUB2ZtmT3Ur0YCKB/HoLe?=
 =?us-ascii?Q?67VXAhy5H37mj83DXpJwqFCwyDg5dUHIyPOGn0K8RipKBRQMJ0/h+b6+yrfz?=
 =?us-ascii?Q?nqRdSw0gXcf0qw4jSh/05iOXP+SPE9YwNWTbm+FpLU70bFOTSDwWLrfQB3iQ?=
 =?us-ascii?Q?5e6laNR2NVOqcQma7rgcqZLFlUkmKIABXVFNZJZOU/uOEDRXFSUTCGleBk8o?=
 =?us-ascii?Q?GE+R26+DmG0ze7fmiLFrjhBW0BoPnWqhY7N+KuxN12C9LFVr3uysmtbp0cIe?=
 =?us-ascii?Q?Dw0h1RQi5LyNpQnZFBnivE1Lp7MyXPflCYckXbYuonenphq9laG53jeDuO7B?=
 =?us-ascii?Q?CcP5Y6j/Ks7cHfkfEm/UJl+X03MB6DMY+9SQ3tVtDRW4ly4v+8AHAIBkN2s0?=
 =?us-ascii?Q?q0JH2Yvz+KIB/TwZI2WTpSRnjqd3LULaSnlHUut5Ff0RyHA6667xJ1IaamA6?=
 =?us-ascii?Q?wiAK86U//W7F6c/6KIC5OVOX42cjsCVYpxCrL39Vjow7lylP3YAd0gamvEFV?=
 =?us-ascii?Q?lwKkLPhWbiC8uGXvkEav0BLk4b7OWbv/+ssIvrp93xnXLsH13V9Zkw9qca97?=
 =?us-ascii?Q?6E6p1u1Nm3qAJw0muVXAXgrlkA5ft97YSq/7l7v2hqQx11Pv5svceOPT4J08?=
 =?us-ascii?Q?yjm3/d59lgY2aOpwwaEvzF8juBnicMULHsgEL8ch9uJ41Jt0bxzNpy9Mygk5?=
 =?us-ascii?Q?irTDuZiT7skpkFC7qIrXP7cJFvB78m9UL+U+5NBRATfUqV3gN3NFQJb/iUtN?=
 =?us-ascii?Q?EbspEtmYu3ck6qoeZFbASFI4s+035iS2Pg00/0bwWG+0sCDI73fn5THcRnoL?=
 =?us-ascii?Q?308/wfC0H9omgKSguDI2gyjv/Pst5N0+dhhmTOzVYfxcaAB/blKirZGty/Hu?=
 =?us-ascii?Q?8JTL9hA9exG4/kBngpEyV7AYaub8Z5mtpmSy5pgAGIXOxtzdebCmoNL0ZwF5?=
 =?us-ascii?Q?pRlTevxAq07vaGw29qQlYcsKQJAspGMiOh0I+jGqLBGN0qqZsGiXafK9Vclg?=
 =?us-ascii?Q?xICqhPVcn9l4jDlIevAM6V62Fq+62XA4vYmE39AI4NdojIk3CqaBAbLHaWdb?=
 =?us-ascii?Q?+wRyEINAqw=3D=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 609567d4-b105-4ea6-028b-08da18929c18
X-MS-Exchange-CrossTenant-AuthSource: HK2PR06MB3492.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 12:31:59.1488
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UWb7RnDF0K5wPC+6RWInczNrO6XQNAFGLy1PoOTK9mzex8PORZa56iiyQwlvr0y166dOhMBk2DXzyxMcOhqu7w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB4404
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE,
	SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Address the following coccicheck warning:

tools/testing/selftests/vm/userfaultfd.c:1536:21-22: WARNING opportunity
for swap().
tools/testing/selftests/vm/userfaultfd.c:1540:33-34: WARNING opportunity
for swap().

by using swap() for the swapping of variable values and drop
`tmp_area` that is not needed any more.

`swap()` macro in userfaultfd.c is introduced in commit 681696862bc18
("selftests: vm: remove dependecy from internal kernel macros")

It has been tested with gcc (Debian 8.3.0-6) 8.3.0.

Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
---
 tools/testing/selftests/vm/userfaultfd.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/tools/testing/selftests/vm/userfaultfd.c b/tools/testing/selftests/vm/userfaultfd.c
index 92a4516f8f0d..7aba3ced7545 100644
--- a/tools/testing/selftests/vm/userfaultfd.c
+++ b/tools/testing/selftests/vm/userfaultfd.c
@@ -1422,7 +1422,6 @@ static void userfaultfd_pagemap_test(unsigned int test_pgsize)
 static int userfaultfd_stress(void)
 {
 	void *area;
-	char *tmp_area;
 	unsigned long nr;
 	struct uffdio_register uffdio_register;
 	struct uffd_stats uffd_stats[nr_cpus];
@@ -1533,13 +1532,9 @@ static int userfaultfd_stress(void)
 					    count_verify[nr], nr);
 
 		/* prepare next bounce */
-		tmp_area = area_src;
-		area_src = area_dst;
-		area_dst = tmp_area;
+		swap(area_src, area_dst);
 
-		tmp_area = area_src_alias;
-		area_src_alias = area_dst_alias;
-		area_dst_alias = tmp_area;
+		swap(area_src_alias, area_dst_alias);
 
 		uffd_stats_report(uffd_stats, nr_cpus);
 	}
-- 
2.20.1