Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <89ad6f76-a947-edd9-2de3-84dbc4901835@suse.de>
Date:   Fri, 8 Apr 2022 00:58:55 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH] bcache: add a check for the return of kzalloc()
Content-Language: en-US
To:     xkernel.wang@foxmail.com
Cc:     linux-bcache@vger.kernel.org, kent.overstreet@gmail.com,
        linux-kernel@vger.kernel.org
References: <tencent_C028FEC2BF94C0FF5740D298F572B9396C09@qq.com>
From:   Coly Li <colyli@suse.de>
In-Reply-To: <tencent_C028FEC2BF94C0FF5740D298F572B9396C09@qq.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/25/22 11:27 AM, xkernel.wang@foxmail.com wrote:
> From: Xiaoke Wang <xkernel.wang@foxmail.com>
>
> kzalloc() is a memory allocation function which can return NULL when
> some internal memory errors happen. So it is better to check it to
> prevent potential wrong memory access.
>
> Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com>
> ---
> Note: I just roughly handled the error and this seems to affect the
> original functionality. If this cannot fail, maybe the tag
> `__GFP_NOFAIL` should be considered.

The error handling is incorrect indeed. And IIRC there is someone else 
already fixes it properly and the patch is not upstream yet.

Thanks.


Coly Li


>   drivers/md/bcache/request.c | 18 ++++++++++--------
>   1 file changed, 10 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c
> index 6d1de88..1dc9821 100644
> --- a/drivers/md/bcache/request.c
> +++ b/drivers/md/bcache/request.c
> @@ -1107,14 +1107,16 @@ static void detached_dev_do_request(struct bcache_device *d, struct bio *bio,
>   	 * which would call closure_get(&dc->disk.cl)
>   	 */
>   	ddip = kzalloc(sizeof(struct detached_dev_io_private), GFP_NOIO);
> -	ddip->d = d;
> -	/* Count on the bcache device */
> -	ddip->orig_bdev = orig_bdev;
> -	ddip->start_time = start_time;
> -	ddip->bi_end_io = bio->bi_end_io;
> -	ddip->bi_private = bio->bi_private;
> -	bio->bi_end_io = detached_dev_end_io;
> -	bio->bi_private = ddip;
> +	if (ddip) {
> +		ddip->d = d;
> +		/* Count on the bcache device */
> +		ddip->orig_bdev = orig_bdev;
> +		ddip->start_time = start_time;
> +		ddip->bi_end_io = bio->bi_end_io;
> +		ddip->bi_private = bio->bi_private;
> +		bio->bi_end_io = detached_dev_end_io;
> +		bio->bi_private = ddip;
> +	}
>   
>   	if ((bio_op(bio) == REQ_OP_DISCARD) &&
>   	    !blk_queue_discard(bdev_get_queue(dc->bdev)))