Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
MIME-Version: 1.0
References: <CAGETcx-tH0+WoqH6s=Zw6VSaHwFcBhvaJKLJRLHGtUEs+skCvQ@mail.gmail.com>
In-Reply-To: <CAGETcx-tH0+WoqH6s=Zw6VSaHwFcBhvaJKLJRLHGtUEs+skCvQ@mail.gmail.com>
From:   Saravana Kannan <saravanak@google.com>
Date:   Thu, 7 Apr 2022 17:44:31 -0700
Message-ID: <CAGETcx_7_r7NJb+uU05YxzJu1QZfvMBxwOo2M_wK6JU_h=wJKw@mail.gmail.com>
Subject: Re: [PATCH v2] printk: ringbuffer: Improve prb_next_seq() performance
To:     pmladek@suse.com
Cc:     Chunlei.wang@mediatek.com, john.ogness@linutronix.de,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        LKML <linux-kernel@vger.kernel.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@lists.infradead.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Steven Rostedt <rostedt@goodmis.org>, senozhatsky@chromium.org,
        Android Kernel Team <kernel-team@android.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Messed up mail headers. I'll resend this with proper mail headers.

-Saravana

On Thu, Apr 7, 2022 at 5:36 PM Saravana Kannan <saravanak@google.com> wrote:
>
> > --- a/kernel/printk/printk_ringbuffer.h
> > +++ b/kernel/printk/printk_ringbuffer.h
> > @@ -75,6 +75,7 @@ struct prb_desc_ring {
> >  struct printk_info *infos;
> >  atomic_long_t head_id;
> >  atomic_long_t tail_id;
> > + atomic_long_t last_finalized_id;
>
> I really know nothing about this code, but while looking around
> kernel/printk/ I noticed kernel/printk/printk.c has these lines in
> log_buf_vmcoreinfo_setup().
>
>         VMCOREINFO_STRUCT_SIZE(prb_desc_ring);
>         VMCOREINFO_OFFSET(prb_desc_ring, count_bits);
>         VMCOREINFO_OFFSET(prb_desc_ring, descs);
>         VMCOREINFO_OFFSET(prb_desc_ring, infos);
>         VMCOREINFO_OFFSET(prb_desc_ring, head_id);
>         VMCOREINFO_OFFSET(prb_desc_ring, tail_id);
>
> Would this header file change also require a change to that location?
> Something like
>
>         VMCOREINFO_OFFSET(prb_desc_ring, head_id);
>         VMCOREINFO_OFFSET(prb_desc_ring, tail_id);
> +        VMCOREINFO_OFFSET(prb_desc_ring, last_finalized_id);
>
> -Saravana
>
> > };
> >
> > /*
> > @@ -258,6 +259,7 @@ static struct printk_ringbuffer name = { \
> >  .infos = &_##name##_infos[0], \
> >  .head_id = ATOMIC_INIT(DESC0_ID(descbits)), \
> >  .tail_id = ATOMIC_INIT(DESC0_ID(descbits)), \
> > + .last_finalized_id = ATOMIC_INIT(DESC0_ID(descbits)), \
> >  }, \
> >  .text_data_ring = { \
> >  .size_bits = (avgtextbits) + (descbits), \