Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Thu, 7 Apr 2022 17:51:16 -0700
From:   Isaku Yamahata <isaku.yamahata@gmail.com>
To:     Paolo Bonzini <pbonzini@redhat.com>
Cc:     isaku.yamahata@intel.com, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, isaku.yamahata@gmail.com,
        Jim Mattson <jmattson@google.com>, erdemaktas@google.com,
        Connor Kuehl <ckuehl@redhat.com>,
        Sean Christopherson <seanjc@google.com>
Subject: Re: [RFC PATCH v5 024/104] KVM: TDX: create/destroy VM structure
Message-ID: <20220408005116.GB2864606@ls.amr.corp.intel.com>
References: <cover.1646422845.git.isaku.yamahata@intel.com>
 <36805b6b6b668669d5205183c338a4020df584dd.1646422845.git.isaku.yamahata@intel.com>
 <aa6afd32-8892-dc8d-3804-3d85dcb0b867@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <aa6afd32-8892-dc8d-3804-3d85dcb0b867@redhat.com>
Precedence: bulk

On Tue, Apr 05, 2022 at 02:44:04PM +0200,
Paolo Bonzini <pbonzini@redhat.com> wrote:

> > diff --git a/arch/x86/kvm/vmx/main.c b/arch/x86/kvm/vmx/main.c
> > index 6111c6485d8e..5c3a904a30e8 100644
> > --- a/arch/x86/kvm/vmx/main.c
> > +++ b/arch/x86/kvm/vmx/main.c
> > @@ -39,12 +39,24 @@ static int vt_vm_init(struct kvm *kvm)
> >   		ret = tdx_module_setup();
> >   		if (ret)
> >   			return ret;
> > -		return -EOPNOTSUPP;	/* Not ready to create guest TD yet. */
> > +		return tdx_vm_init(kvm);
> >   	}
> >   	return vmx_vm_init(kvm);
> >   }
> > +static void vt_mmu_prezap(struct kvm *kvm)
> > +{
> > +	if (is_td(kvm))
> > +		return tdx_mmu_prezap(kvm);
> > +}
> 
> Please rename the function to explain what it does, for example
> tdx_mmu_release_hkid.

In the patch 021/104,  you suggested flush_shadow_all_private().
Which do you prefer? flush_shadow_all_private or tdx_mmu_release_hkid.
-- 
Isaku Yamahata <isaku.yamahata@gmail.com>