Received: by 2002:a05:6a10:83d0:0:0:0:0 with SMTP id o16csp200810pxh; Thu, 7 Apr 2022 18:48:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwsjbVCb5u0Lj6u9nq/nBBkfMKBMD49XF6HmPB8PHGAlGVq45V/W6pmnMWHTTF1SJkk7/7y X-Received: by 2002:a17:902:d2d2:b0:156:cda5:e88c with SMTP id n18-20020a170902d2d200b00156cda5e88cmr16836209plc.74.1649382507034; Thu, 07 Apr 2022 18:48:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649382507; cv=none; d=google.com; s=arc-20160816; b=YTZuRZOFgeEAMihTiT0d/kapc6RJ/714CAaPXrvIvzJuI3qvCrq8wrvBTZBn3ijYwP cLrHL6+9DjZ/uROHcOACeLzFQ4DYyZoKQqTc0ESc0TTgptLBfg7FlwjATSy65C8UHkj+ XIjjXkX8OK6OBBeDurHjesIR6QeEOnMIqJi2JocRhaX5kdMLPf5w7++dkJM8UL/E/fyZ zhiJu/BG6lMEOCRJSdCKsv5Cx+Bpkhn3E8VzfEjxmkn/NIyeK9sN8LT9l4Iv35WleF48 NV0DTZzpBOx9naLvRPmaXorWKOzpnCt9D9pZEZN9M/82jejXKVLL2CVwi5x1+JIMrKBx Wr7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=57LqHa+AbfwFjq7Vk+b/e1ot2SC8721sG4HrvSCk/uU=; b=ApJ67iG1EoFkNGlmxAjnYOSTlkea+qVgU5HvmqIXtpriiZD2EeqypEk5RzcHt5xOyw WrdHryOB3FytlIgV9KqcgBSJp+boBvBxN2xhJjCj3VrRuZk9tAcJ9ml+E8YzPCKvJMpQ TUKC+STaz8C3tTmWbPk70BGEmECt2HxCpKv6VM/4p2fE03cACBReluI9Af+B+EmQImLT DffRIg+p2eijoXLjmuFbL4qCoVsaPoUvswZkLbJFhq/aQvlfpDhvSisIRpXkwTpP8AHX NgmOGOHgWpQ0fCZRFJsug4sFU6XBLCSjKIRmxjXvDn10ZXj+lDpM006OWIqp35LaUj09 oZ1A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=CzKotq9B; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id t2-20020a62ea02000000b004fadce9e1cdsi19449344pfh.374.2022.04.07.18.48.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Apr 2022 18:48:27 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=CzKotq9B; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5511B149D17; Thu, 7 Apr 2022 18:19:19 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230169AbiDHBVR (ORCPT + 99 others); Thu, 7 Apr 2022 21:21:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233320AbiDHBVP (ORCPT ); Thu, 7 Apr 2022 21:21:15 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D8B234BB7 for ; Thu, 7 Apr 2022 18:19:13 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: nfraprado) with ESMTPSA id 8FD2F1F46B10 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1649380752; bh=DRF0VVql1NDF1AFBXdreQkrM736cxZe8TLofRJp+rIE=; h=From:To:Cc:Subject:Date:From; b=CzKotq9B/GtJeR8NyobQE7fpb4jsG3di7QvNmI8YKfpttbMaevDT9Uf0OdhsDS3Wq kW0OUMPFd8j73Nlc3Lx7iohdfUWUeC1u6t+C0BUkKMEfMlejJb/BOwbGK3j4oiaQzl zV1wC6Be1FGMR6a/4BlZpDjMns3t8ZmMr6qU8M/9H3+myE196Vsk92YjgRydOUwQhB F1h6D4bzcLn4Cau+hHx5IL9LmniCCecJfT4lHOneb0gonTu8akKH5rN3Lxdb82jKcK rYHceKabJgfRjDlxubAvqcymueNkYSqbcd2MEn7p1ifNkTqfkboJOVEsqsCUZcY+/0 Qj2e/jOnJFqkA== From: =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= To: Philipp Zabel , Chun-Kuang Hu Cc: AngeloGioacchino Del Regno , kernel@collabora.com, =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= , Daniel Vetter , David Airlie , Matthias Brugger , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: [PATCH] drm/mediatek: dpi: Use mt8183 output formats for mt8192 Date: Thu, 7 Apr 2022 21:19:07 -0400 Message-Id: <20220408011907.672120-1-nfraprado@collabora.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The configuration for mt8192 was incorrectly using the output formats from mt8173. Since the output formats for mt8192 are instead the same ones as for mt8183, which require two bus samples per pixel, the pixelclock and DDR edge setting were misconfigured. This made external displays unable to show the image. Fix the issue by correcting the output format for mt8192 to be the same as for mt8183, fixing the usage of external displays for mt8192. Signed-off-by: NĂ­colas F. R. A. Prado --- drivers/gpu/drm/mediatek/mtk_dpi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c index 4554e2de1430..e61cd67b978f 100644 --- a/drivers/gpu/drm/mediatek/mtk_dpi.c +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c @@ -819,8 +819,8 @@ static const struct mtk_dpi_conf mt8192_conf = { .cal_factor = mt8183_calculate_factor, .reg_h_fre_con = 0xe0, .max_clock_khz = 150000, - .output_fmts = mt8173_output_fmts, - .num_output_fmts = ARRAY_SIZE(mt8173_output_fmts), + .output_fmts = mt8183_output_fmts, + .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts), }; static int mtk_dpi_probe(struct platform_device *pdev) -- 2.35.1