Received: by 2002:a05:6a10:83d0:0:0:0:0 with SMTP id o16csp24612pxh; Thu, 7 Apr 2022 21:44:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwrMfmwn5ANXUWH/S5vXe66VHGakoXyDv/jDSVAMxVDradjhiw0XgeMl9bZEesb7kjhKMn+ X-Received: by 2002:a63:6443:0:b0:399:54fe:5184 with SMTP id y64-20020a636443000000b0039954fe5184mr14031858pgb.511.1649393084226; Thu, 07 Apr 2022 21:44:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649393084; cv=none; d=google.com; s=arc-20160816; b=xHYZzeEeGLO/pagb7yG9KZ+Pwq+DSow7Zs8Gr+GYLQhpNDdO44ig4z90KElj1Vff8y NR75K1zPBmPW1u71a1TmrzIdLTKyT7aXnpBehWghXSPLZdE2bh/wOKwTTRxWIV1ulfAK IMWWpKLr+QAXKuGwklrvEFAqr3hmduNqpwHmpN5J00+vPMyBr76fUSJ47P6+Wz7YW65s cWA4uiaqD6e0ke4tuSyHxaa8Hrd9u95RfWgTDD1nS2CO1TSY1BoVy6Zkg4wk2YnBYr76 aHm88IVGLF86XN1K1rXnUO1SwSrBHy5SsE1xjLupPIxem3624UhPUjZH5mnIKi7ULI12 kkmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=rtgdGpnF2Oy2zH1CTbcUKZBK4sJyPx+XWktNeydRM2g=; b=nKtE0iACchb7xEDURfmJu1haOrd/p/qIM4FVogN4Tz451Rdi/h//lKvZIgpn9b+KOi D/k7iwcwvTJx8H6r0H5uka7/Qrl4jbc3EupaG0wuawNftgITA9YLDP6aTdfPkkwQN7y5 Va4FeWY3kmJyAV8APHJrZfnRxmS5+KxubGq07XgD/IRu58VvnUaexJAL225PRdQ3wwTt KIZuUwS8VsgwW4uOYaJUo/rjLcvrqNzvsPbQy9J9mQAYsPCEeoNcvaS8QHNr/Uw+CcR6 vZ2fUJg+BRwg4H++6MGL9iajUrx7oxvkJeU7nymwdkeIhlXtUnhZG4xGfluHrlZWO1ob m18Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="SU50/V/1"; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id m22-20020a056a00081600b004fa3a8dff9asi91560pfk.81.2022.04.07.21.44.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Apr 2022 21:44:44 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="SU50/V/1"; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 0A02B20C19F; Thu, 7 Apr 2022 21:10:58 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234167AbiDHEMj (ORCPT + 99 others); Fri, 8 Apr 2022 00:12:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49182 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232390AbiDHEMR (ORCPT ); Fri, 8 Apr 2022 00:12:17 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 751781EB805; Thu, 7 Apr 2022 21:10:15 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id E472DCE29FF; Fri, 8 Apr 2022 04:10:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 450C4C385A3; Fri, 8 Apr 2022 04:10:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649391012; bh=/ocmwyPmcxJaE7A3jgFW3oPLW1FUfozUVp4GcoMvkoE=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=SU50/V/1U1F4SxYfBIQWfbo0x2uJIoLXzsSxn2er9wPOXoHmtlBSuG5CIrrohjVTb nNg9fEtBcYEMA9yFHB33kFDTr1uKGWwVTcUqvHW38MnmsXHOBQinc6bGlar7TYBpst NPG8GubMiAxfSQQUoMX6MxeKQYUQHHwbzRvZz4i2NmjLG5L0IHOGxpZ98gmC743coz o1gV3lGBsKH1np/fryx2V6nRC3KtwEJ+yjt0DUzZciS1Nmak3kEg2r41Bc/13SIobC 7XvUq0Ggf4JUvRSDa2EHhww0FP7BtMsq57lFBgD1C7Im3Md4qveOx/FzyzySfXmZTC cMpeY/dYt35kw== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 22C9BE85BCB; Fri, 8 Apr 2022 04:10:12 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH v2] qed: remove an unneed NULL check on list iterator From: patchwork-bot+netdevbpf@kernel.org Message-Id: <164939101213.29309.15840560082982456814.git-patchwork-notify@kernel.org> Date: Fri, 08 Apr 2022 04:10:12 +0000 References: <20220406015921.29267-1-xiam0nd.tong@gmail.com> In-Reply-To: <20220406015921.29267-1-xiam0nd.tong@gmail.com> To: Xiaomeng Tong Cc: aelior@marvell.com, manishc@marvell.com, davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski : On Wed, 6 Apr 2022 09:59:21 +0800 you wrote: > The define for_each_pci_dev(d) is: > while ((d = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, d)) != NULL) > > Thus, the list iterator 'd' is always non-NULL so it doesn't need to > be checked. So just remove the unnecessary NULL check. Also remove the > unnecessary initializer because the list iterator is always initialized. > > [...] Here is the summary with links: - [v2] qed: remove an unneed NULL check on list iterator https://git.kernel.org/netdev/net-next/c/4daf5f195630 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html