Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Fri, 8 Apr 2022 08:57:32 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Julia Lawall <julia.lawall@inria.fr>
Cc:     Rebecca Mckeever <remckee0@gmail.com>, outreachy@lists.linux.dev,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] staging: rtl8192u: replace ternary statement with
 if and assignment
Message-ID: <20220408055732.GO3293@kadam>
References: <cover.1649378587.git.remckee0@gmail.com>
 <36059ec66a2f3d58a8e339aa4f262772eabd3ef0.1649378587.git.remckee0@gmail.com>
 <alpine.DEB.2.22.394.2204080614400.2199@hadrien>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.22.394.2204080614400.2199@hadrien>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?dxkwZfI7lTA78ySomZxL8FKMMIX1l5kDGw2JVSbgaBP0B521vRdeQ4GJORh3?=
 =?us-ascii?Q?CRWc8BZCS5GRgLwvdJRksUL8Qx7CA+8L1qTa6UXwPox/z/VOE84Dz0wsYEAQ?=
 =?us-ascii?Q?8O9Ljn8aICPtgpqHg57rbVjhctyumsrCkEeICryUsA82Sr+EX/YY3UhkCLLu?=
 =?us-ascii?Q?qNqgoPOU/uPpH3Ld0wAE+8ZGaCC2NV4I1s2eIDRedJ1OJsXmwU3Rpixjld+h?=
 =?us-ascii?Q?Mge+mB6YfV1Xmg0uu9n/xo+GGLdStQODDgrrjATMtaxKr2U+PkiHflnLBsvH?=
 =?us-ascii?Q?PMdSLtRutU/6KsZLRuQxRRXVAXMLKCW0fRIs6mhIwGrDTK6ViNg3Qr+g6svW?=
 =?us-ascii?Q?b1aaaG1TeMjf00xfoCEETAz+j4UVZ44dMb9FU58R4UvsYJNwyigat5QG+Rls?=
 =?us-ascii?Q?gLlKeLqETrkZWVNz7GWThUO8ofLDR/hqFSvP8HD2hIUtsCpYMo2nBGoEPU6d?=
 =?us-ascii?Q?1wgxNl7ZGWiodBMcs+nE2/yhbdlb++LQnQ2kaQ5cDyesQzsvlKrSux/n3/Aq?=
 =?us-ascii?Q?6RUdD+Z0I+yJvfq5ypi+0lbLzz+WiNF2MNK73stiL9uLEO13VhsW2C26RMB/?=
 =?us-ascii?Q?HX3aEe1IT65yB1sxBLyya+Q4t11ARxQ9GBp0Cqgj9aDmERpbCeU0ayXgAFjy?=
 =?us-ascii?Q?t5qnyzdoUZ3LjgrPXOl3ecGiYRQ31ff10e0dEPIlDh3zBXtPec8h/rm2qRL5?=
 =?us-ascii?Q?hS0Wn5gN+R+2jB3Q8SXkzqjWpt4hhh2QaKe13pxrGki/lKqrPHL1pA+Ykn9g?=
 =?us-ascii?Q?NEnl4rZCSnEXCBeaL+qhuEKV7yPtIEGtH0gaFLLmO77ApQp8/GANZyzfmhKS?=
 =?us-ascii?Q?HYEMJkFZ525SsbC0GasakO7Xy5P2IVZysnPpfk7WaB+ra2m4UYpTLYvt1cpy?=
 =?us-ascii?Q?fH47bpr73b+uJLPQZUc9zRwDbW3j1TMX03zppYyzG/NFXTbm7TeP8aF7Z0hv?=
 =?us-ascii?Q?mpBt4J1WAdsDgRKFG1aYEx4Sc05KDnoKgRSwNXD+kaj71oVdgLDrcpcMz8Ez?=
 =?us-ascii?Q?XDfaQwMWWr9hmJpUM96V0jSlEbK+erZo6YozI31w6ugjZdr+EI6laa4RzsUV?=
 =?us-ascii?Q?ca1CMIowuVZVClZ9EEOdcXsml2B+NIemxRGVpbYIhkuuth7pGRrqfjsKx6yO?=
 =?us-ascii?Q?0CwUIHEIaH7XnGoHDmdUrsVjWj5ttA3jYsiqrr2lFiv6azryby4f7RM6RSgS?=
 =?us-ascii?Q?4SUz+GUA3nVX0iH+KwqG5+y5ZoCDLwIG9Z1eTQfHluW28jjZeQQgGp+hBFhe?=
 =?us-ascii?Q?YqqtzuUrTMfDTuIol/tz6wfQsN6CtUZ38lDZLij7dVLnJLJzBzL5itXZDUe0?=
 =?us-ascii?Q?jRp3uxUkqBpaijKcwvHA/or8ZHI1gW6VZvm7fWRXW5AK+XSrraremUOeNsam?=
 =?us-ascii?Q?LeStUBRaUWyg6dnn0EQGkm3NCmVVcL7LPtP9Ao97FKJm52ImEV1IPDjkwtvO?=
 =?us-ascii?Q?JuSSBJpKMZg6x2sLLJx0tdvBpM9J+UYIhFAx0BDxL1yK/t8OPzvfsN2Vp4gl?=
 =?us-ascii?Q?wKMDzk6sta4AB5io1zgpuQQE8DXWtbi+b9NRr3ytsRMH1vn2c2cBl2yEqM5T?=
 =?us-ascii?Q?h41Ns202RRkIEEWKg284QuPEwsavGDZ67q4y/vDvHChmOWnxGiHuZnqYzj6M?=
 =?us-ascii?Q?5utq5tfBmISxxfVzkBKoUw9uzO3AlXwE+b370utaETymnYBqvmQ4GCWvS+PN?=
 =?us-ascii?Q?cOKfxBT8P8CIJJHrsjblqEV3SHB5zoubfaXQu4PrBgurwK7WMPx63HDx6g7f?=
 =?us-ascii?Q?+L3r5LZh/f2HLTpJAFDQPuey4YCNLqc=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ea82a549-3766-438b-1fc0-08da1924b439
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2022 05:57:46.2787
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: I2Uk09gX0y98Qj4SURtZBFuA/SCJg/cKvSgwF0gk+FlARNbY3Om/9ZXMoLcsKKVsxdy5EM3o1PAIVLmgPhV1z/nuLNK0EnRV+fZQY2mdiFg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB2811
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.850
 definitions=2022-04-07_01:2022-04-07,2022-04-07 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 adultscore=0
 suspectscore=0 spamscore=0 mlxlogscore=937 bulkscore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204070064
X-Proofpoint-ORIG-GUID: ar2rF50WhZ_7RLUCSQTx5j7Kywx1-X_7
X-Proofpoint-GUID: ar2rF50WhZ_7RLUCSQTx5j7Kywx1-X_7
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Apr 08, 2022 at 06:15:14AM +0200, Julia Lawall wrote:
> On Thu, 7 Apr 2022, Rebecca Mckeever wrote:
> 
> > Replace ternary statement with an if statement followed by an assignment
> > to increase readability and make error handling more obvious.
> > Found with minmax coccinelle script.
> >
> > Signed-off-by: Rebecca Mckeever <remckee0@gmail.com>
> > ---
> >  drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c
> > index 78cc8f357bbc..9885917b9199 100644
> > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c
> > +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c
> > @@ -470,7 +470,9 @@ int ieee80211_wx_get_encode(struct ieee80211_device *ieee,
> >  		return 0;
> >  	}
> >  	len = crypt->ops->get_key(keybuf, SCM_KEY_LEN, NULL, crypt->priv);
> > -	erq->length = (len >= 0 ? len : 0);
> > +	if (len < 0)
> > +		len = 0;
> > +	erq->length = len;
> 
> Maybe you could use max here?

Initially Rebecca did use max() but I NAKed it.  It's really not less
readable.  Better to handle the error explicitly.  Keep the error path
indented two tabs.  Separate from the success path.

regards,
dan carpenter