Received: by 2002:a05:6a10:144:0:0:0:0 with SMTP id 4csp27845pxw; Thu, 7 Apr 2022 23:30:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxqniyM9aE12Mk9+QrfVFwahFpfbd6bxFDe/26NrKCpEnRgyI/LlsJczMQw75YPvCutQtFf X-Received: by 2002:a05:6a00:1304:b0:4e1:2338:f11e with SMTP id j4-20020a056a00130400b004e12338f11emr17956750pfu.24.1649399416092; Thu, 07 Apr 2022 23:30:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649399416; cv=none; d=google.com; s=arc-20160816; b=daEZSrX2X7intXwo9mvm7SF0r8156KIUHP3rWVw17D0ML2pqjgalevMRPfw/NJQbGp RyfuUUX0+w1hhKsWxkf6ALm9Y09mmTOSTWo5wvtFgvcDTsdJnLE1DgmtAMilll20HvSp RWY8/vg9HlaRobuAn1bZui4CbsxYiOeVpGGX9C1jMmHG+HrShfW6MDr59QhWa63vpcSV mdshSeESLsHQtMKFSFXk2MQQ+pE4hp0fUBEbtLGrlVBMooZBJcTtwYlLKc1E8ofv7aKq WVF7s/lHXRHmeLAY/n7xapXTNmxoI2cAlP0BNeKKaaZ3AQKd7WvK0dwzA0FiZOM/17Bn vTRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=yUfU77rU29Ug0Am6GhAJCd/BoIsDfP1OgWIu7qTm9p4=; b=QxBnpz+yIwNuo8mBMnlkdR5Z4CrirPxZXlAvnZ7kAFcCY9TF9eDHXpFlLeLVtvvQgd 9cmMjJAoDthZopzKtdiCpmagX21QkVi/KLTkjBAMSHLURXkIIn4j6dt9H1Xeph6f9v5p gS6uL2m6t1duEmK4l3i/cVCrySJbEoc/+hLeHYwObcSR9cfAhkfRxS1g2f6XJwthh/cr 067UbBHBl8pQMe839s1vQa41YMnlWb1V21oFawTU3//oWzeIzHEO0P+pSVbVitEVycjB 3lBdC8pYubxDIIienD3WfAQ6sFMX6+rQ3S/Cy0SVmuWXV6+P2y/SW59AA46oU+Yi4WVc MqXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=4lnT1HMW; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id 2-20020a17090a01c200b001caa0b8c6f0si3674101pjd.18.2022.04.07.23.30.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Apr 2022 23:30:16 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=4lnT1HMW; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 80DDBFFB77; Thu, 7 Apr 2022 23:00:25 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235046AbiDHGCV (ORCPT + 99 others); Fri, 8 Apr 2022 02:02:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229484AbiDHGCT (ORCPT ); Fri, 8 Apr 2022 02:02:19 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19706D4C9E; Thu, 7 Apr 2022 23:00:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=yUfU77rU29Ug0Am6GhAJCd/BoIsDfP1OgWIu7qTm9p4=; b=4lnT1HMWxexe2GgqCPW2cj8JbN DNLd+Tl+sz2yoMSB/6z583gHFhIwWnHIMFsEpoFjrFLdReVTMDJoQKk55eK7O/44fRLL1cPP9lSkE 42HRozXxTqqPx/InXETa7ceDD9di4rct6kkjbwqxVaNtSdBTlE1djGVasySilTJRTYUykElZXj0iF 7QIDueY2gwSboHkpQv+rjXxVs6PqrLtU6fz95NVx8O8kA68dP9igPGUPnzSo4gx4ujlhVzspHHvE5 58qvgNeaBklmLPnzeHSug34EYY+60VDZiLW94k3pumSa7//lNNPjyzwK9B4vsyXi5X9za0eWEVbow R9A2IJ6w==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nchfM-00FDnq-G2; Fri, 08 Apr 2022 06:00:16 +0000 Date: Thu, 7 Apr 2022 23:00:16 -0700 From: Christoph Hellwig To: Logan Gunthorpe Cc: linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, Song Liu , Shaohua Li , Guoqing Jiang , Stephen Bates , Martin Oliveira , David Sloan Subject: Re: [PATCH v1 2/8] md/raid5: Move stripe_add_to_batch_list() call out of add_stripe_bio() Message-ID: References: <20220407164511.8472-1-logang@deltatee.com> <20220407164511.8472-3-logang@deltatee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220407164511.8472-3-logang@deltatee.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 07, 2022 at 10:45:05AM -0600, Logan Gunthorpe wrote: > The call to add_stripe_bio() in retry_aligned_read() is for a read only > and thus wouldn't have added the batch anyway. This sentence is missing an object. Otherwise looks good: Reviewed-by: Christoph Hellwig