Received: by 2002:a05:6a10:144:0:0:0:0 with SMTP id 4csp30925pxw; Thu, 7 Apr 2022 23:35:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx0MVKVULnONf9rU1yU2o6TT5cHAFEsQC9pDyI8CJkrH7bnKFJCxoAB+xmT8aco7YYUqd5z X-Received: by 2002:a65:614e:0:b0:380:bfd9:d4ea with SMTP id o14-20020a65614e000000b00380bfd9d4eamr14272263pgv.92.1649399745245; Thu, 07 Apr 2022 23:35:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649399745; cv=none; d=google.com; s=arc-20160816; b=d0fbjBsxr5Gc6tmMRDhNjibgCUfj8jlosTiyIYBqfFIbflr4aOTSbdJ3fiYRJT5IIm SeUonclGkzXQ2GXaHGxhqR6lynuxL9biehQYchv5/qH6i0qgy6tWQZEq4zQv0YbNEb47 BeCecvEw+nccJVuTUEGDCfrin9c8NE7g/fmHu0MTaRJW9Tn1eEPIGC/3YBSmUj+QKfsB toPUBM1pukJRaog40Lac5Ya3exHM2xFgY0//reMD1ID1tJeGqZZGyK9IXLzxppjjUxBt CEeEXyBww27phioOf8zZK/R0rc0cBtBYRpd5RRyASWkGyD1IFGSH6CsXkjThLaO6fvFC KFmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=A6b+cX8hCB8oB11lm2BdzaQ+eWpWdm8tA3u4Ttvi6EI=; b=r6wTDxvpK6ipPQ0rKezPZuoyJ7bq7wHs5Bx0bK8haRvvUav8Hen07bf4QkfRT5MMOI /8OU6Xuunrm92+Etz3ITIwvQaNeye4qTvWA3AaB/cquzQn9v4kUlR3ZgqE7GQEzqA+dh EW2clLUs+TgcrbLObWFyLJ7XxvllBoM90M2yJcRaJCyIzhEMmkmB/NKNCEt7jqAsx+VC Xi8Ti+CL/+7h4TfRSNTycpldk1onRXr5EJ29RqFcrIIYVt6CjfHKDny2C4L4Ocw8Y7NU R7qPXpunyGkYLmttEnIZ2LbV0CdVir/Z0hwbt6bN6VigFOypfUrPlwZnF4GRmvYrMCSx 1ZUQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=lr3uug1E; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id j187-20020a638bc4000000b00398009192c9si417081pge.869.2022.04.07.23.35.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Apr 2022 23:35:45 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=lr3uug1E; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 442FEADD77; Thu, 7 Apr 2022 23:06:14 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235116AbiDHGII (ORCPT + 99 others); Fri, 8 Apr 2022 02:08:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43488 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235102AbiDHGIG (ORCPT ); Fri, 8 Apr 2022 02:08:06 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 328648BE0F; Thu, 7 Apr 2022 23:06:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=A6b+cX8hCB8oB11lm2BdzaQ+eWpWdm8tA3u4Ttvi6EI=; b=lr3uug1E9ClqhmRQnJUM6m4zvu H+QXpYVrltMP/5D4gXQTqD3G1Z076X+3471FD4Q1s6yc2pfwcSG51hiBuSrey1sUZP0iSCVEKH0Fl lsNknnudbq+Ga6SkkBuJ/d5hW9A1cQhtNUs2LKsyCymwKPczcAUhDzWvNMBmeO4CCBoW+MyQ6MNrJ 3iFN4lRmkm8q0zv7eU+kH9R0XII2PasECvlKNYoBbRfHnLzDrl5RvMz2GrSQJemjR09kJpetHDJSh nzjCyWMVizGvs3kHid/EhnRxerV9emGCvMb073htfeYGzKnRT7LmWsvVvV1EG9pTNpMgkw3N3z9Xz tqDr+eVA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nchkw-00FEDs-QY; Fri, 08 Apr 2022 06:06:02 +0000 Date: Thu, 7 Apr 2022 23:06:02 -0700 From: Christoph Hellwig To: Logan Gunthorpe Cc: linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, Song Liu , Guoqing Jiang Subject: Re: [PATCH v1 1/7] md/raid5: Cleanup setup_conf() error returns Message-ID: References: <20220407165713.9243-1-logang@deltatee.com> <20220407165713.9243-2-logang@deltatee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220407165713.9243-2-logang@deltatee.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 07, 2022 at 10:57:07AM -0600, Logan Gunthorpe wrote: > Be more careful about the error returns. Most errors in this function > are actually ENOMEM, but it forcibly returns EIO if conf has been > allocated. > > Instead return ret and ensure it is set appropriately before each goto > abort. > > Signed-off-by: Logan Gunthorpe Looks good: Reviewed-by: Christoph Hellwig