Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Fri, 8 Apr 2022 09:19:36 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Jaehee Park <jhpark1013@gmail.com>
Cc:     =?iso-8859-1?B?Suly9G1l?= Pouiller <jerome.pouiller@silabs.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
        outreachy@lists.linux.dev, Stefano Brivio <sbrivio@redhat.com>
Subject: Re: [PATCH v2] staging: wfx: use container_of() to get vif
Message-ID: <20220408061936.GP3293@kadam>
References: <20220408032349.GA2132476@jaehee-ThinkPad-X1-Extreme>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220408032349.GA2132476@jaehee-ThinkPad-X1-Extreme>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?LYGDZ5rvXpdJboMuMWzmwKQTgRHJVZ7t2FkWZ+/WshxFVjcTi3xWvQqiY5Kj?=
 =?us-ascii?Q?2Njj590SzIbc5EIkHutGwCtY3kUtWRucmNgcSk5f5IVUBqn3Lwc8U1Y8raxB?=
 =?us-ascii?Q?OMaAmphC45bDLSMdnB4UbmtC/IXcgAhLlNRr+bcLsMt7IQ3EbQOqut9H5snE?=
 =?us-ascii?Q?rImE/7oYCgL4v4qm69gVdiY5CgYCNmtpxl6Qf8AouK5fGdMbqr8oBjcQcq96?=
 =?us-ascii?Q?HRv2W9gIUSOfnMYrCj15X2TbT/lvSKXNKtKZ7kUuNCE0BOsCnMNcAAgPEOvX?=
 =?us-ascii?Q?W49f0vl7BNwQEmgQ27x6SDAo2bCq0hZlfa6D2GD+8lKQadHs0A6ErSD6HKy9?=
 =?us-ascii?Q?N1LwQKUW7KnLvRieNNyL6ywOxTjjVYD9s1BnkXU9OE7pcch5nWEJJJkuhKOM?=
 =?us-ascii?Q?Lehe2uQLlhD+4oqOlloIaKBDFQeGytgkQIA4mPAc7CQgBYUFPI0EQT5pI1iK?=
 =?us-ascii?Q?YFclHYYuf8ghQ9P/ml9QhxA9i8CpMy7uMzh3UKJhU8QvrmGZVgoDvefiAUfj?=
 =?us-ascii?Q?xd7QueYQB59atjuNsug8HHA9Z1RQ9rADTQUGbzUo4o+AVhK+Tez9aIjx0j1+?=
 =?us-ascii?Q?u0BNXRUg2ahT4EeSC8+Kb31zD7iRoJNtewMbtl/aJ4v/UX5ZKlw7N5SIkraN?=
 =?us-ascii?Q?JTiIYmmHKRRwRjzdG9mRMwa4cPTMNaKKjlQJv3DgrKz0hmwTNgJymuBxd3t1?=
 =?us-ascii?Q?bD08Y957k91cqMGCMUvUdZiRMM6iBjlKbS8x+fL3BE7DqNxBQQmVgNlmE5GZ?=
 =?us-ascii?Q?q24sMdwxoua74prQHecNWrLCFDw1jWCPQi/Wwt0t4HspaNqgB09tNAYI/Cjb?=
 =?us-ascii?Q?nUew4RpzyjHc9gat9sU9kfT4MFHSPqqqSea4wnVOBsRpxcBx/qEVVJ5xxv6S?=
 =?us-ascii?Q?B6NrCzbxFwo3fQKQLXpGmq0BS/1iOJbaJGIlkrJVHvcNlGBQBrKeBGT9FhNW?=
 =?us-ascii?Q?/W62xisXRC1d4DGOw2hV/Ub/5pxtUSR1DsnSO44VkmMAYdHS8nKx2jypU6nK?=
 =?us-ascii?Q?6RQYQyujx0dAfo7meZyaQW6WI5PEhSkx3HslqYPPn5uZkA7XqHra/VjFwNcu?=
 =?us-ascii?Q?Mq62vly7EyrnDzY695H5CvMn82Gh5Ft+u1BL0aashNeKvxsohMbawuKwY50C?=
 =?us-ascii?Q?V9nMJABg5qU8AHEqxneaXs88Il/4apf6bUll5ACBU9xjCGrG1aSrZJ+CFnAy?=
 =?us-ascii?Q?WF4TuIW9N72ELPasmDmB7CrHynDb9FpDVrlY/b3QCtwlvtatBXe88VNrxUZl?=
 =?us-ascii?Q?rzX+TEFX0n37Iw0ZeZ5sXU5iJ5RcuW1XZntULdR88H+e+JoHTYiUohj63RCf?=
 =?us-ascii?Q?xtJXnxDM1shSxDmGlD0L1atRbMxiyFTnclJRqI731meJf1pI8JAqymoHm+XX?=
 =?us-ascii?Q?KQawdT7BHbOC27jGoSvgw1CliUnQgziVoK4t1O/R0gteUGcpNiCmaLUzXNLX?=
 =?us-ascii?Q?vVAUvA2/CsKbhmnsAsx/fO5wfXLzq3ZonAE0dP16e/A6jXifFaWvos7k9u0m?=
 =?us-ascii?Q?aKu7ygrRxp1xuEIWLQYLSWk7b7ry+vdYCj1EmLfpohDRYBqcHlXMy2PVrCDF?=
 =?us-ascii?Q?wZG8s/yF8E63iEQxNcB6srHnVLp4wDp/6XXzm9o1gH5MUrTFtvT3gwZ5H1cY?=
 =?us-ascii?Q?zxpkBZ+o/k2zJaiooX7wE1U5jKeaIockA+sgNZYnj4TAdUhxVlO99AJxC4Lj?=
 =?us-ascii?Q?9U5x67wSEMAzgywIaJifG1Azy04s0j71uEu0c+fU9eaUM/wxwDzKDBjNum74?=
 =?us-ascii?Q?FFRD0634Q/Qa2sMLc4f5x1sz7bhGkd0=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e9628645-5293-459c-64fb-08da1927cb88
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2022 06:19:53.7822
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OWJ+/tRa0bVLHOmIO0ly5txLFJOmPN977oY53/oHpKqoF7uSveaMMe3JvlpFZoSB8V3ZFb96zpWArMAtwCeXf2+mP5nIb0Wq+x09sVUlV+A=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1001MB2358
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.850
 definitions=2022-04-07_01:2022-04-07,2022-04-07 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0
 phishscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 spamscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204070064
X-Proofpoint-ORIG-GUID: vK95fLofZ441aEdlqu-H3GKsy_b85FRx
X-Proofpoint-GUID: vK95fLofZ441aEdlqu-H3GKsy_b85FRx
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Apr 07, 2022 at 11:23:49PM -0400, Jaehee Park wrote:
> diff --git a/drivers/staging/wfx/wfx.h b/drivers/staging/wfx/wfx.h
> index 6594cc647c2f..78f2a416fe4f 100644
> --- a/drivers/staging/wfx/wfx.h
> +++ b/drivers/staging/wfx/wfx.h
> @@ -25,6 +25,8 @@
>  #define USEC_PER_TXOP 32 /* see struct ieee80211_tx_queue_params */
>  #define USEC_PER_TU 1024
>  
> +#define wvif_to_vif(ptr)(container_of((void *)ptr, struct ieee80211_vif, drv_priv))
> +

Better to make this a function.

Stefano's comments are correct.  It would have saved space with the 80
limit to do a "struct ieee80211_vif *vif = wvif_to_vif();" at the start
of the function.  Also dereferencing the results of a function call
like this, "frob(foo)->bar", without checking makes me itch.  If it's
at the top of the function then that's kind of different.  I normally
assume that the functions in the declaration block cannot fail.  From
analysing static checker warnings, putting functions which can fail in
that the declaration block is risky.

It's always better to test things but this patch looks correct to me:

The add interface does:

	struct wfx_vif *wvif = (struct wfx_vif *)vif->drv_priv
        ...
	wvif->vif = vif;

The remove interface does:
	wvif->vif = NULL;

Those are the only places where ->vif is set container_of() will always
work.

regards,
dan carpenter