Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Fri, 8 Apr 2022 09:39:42 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Rebecca Mckeever <remckee0@gmail.com>
Cc:     outreachy@lists.linux.dev,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] staging: rtl8192u: cleanup of ternary and if else
 statements
Message-ID: <20220408063942.GQ3293@kadam>
References: <cover.1649378587.git.remckee0@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cover.1649378587.git.remckee0@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?avg//C0NNXZU+PfWj3zgeyfztSPx0i+9dBMj5RydIAuD7QR78tmptts2TWVj?=
 =?us-ascii?Q?kAZfnU+ycfuLkQbd601wqXnqpkG4z7MSA8XqI7Oh1YpXrHVTH8Et4rQJlaQ0?=
 =?us-ascii?Q?0NgDP4eZuhpJVsx+5Z2AG5qwDzAccoDLn7fA9oeHo3tMsVq/f+K5oyA58TYD?=
 =?us-ascii?Q?kRTvkCH/qKDzrFsk6pfrJl0+LDBWgoI4Fy4gnnH6nA5dsOMf0iTi1q4aXx42?=
 =?us-ascii?Q?LE/WuH2CVej4dukCAgU2rSsG1SwodA/VlqDInesI1DHRambphmMqPmQWXSIW?=
 =?us-ascii?Q?qgzBCVGPDTMY0yaYG5IFvBeqzlvAlN6FUA7UvTJzK7mC4fyUE4kH5iotB+s+?=
 =?us-ascii?Q?DRtbci/TBmhSXaNu7g1DXHgU7Q51rzheIfvb0Fu4ynwMveIVYkJj7Aig8Ex4?=
 =?us-ascii?Q?OJ4NfnX/xIYl5OBKA0iNhLOWzJ3V5yNNfvb22WSCOPH7Kdbm3zEhwC7NsNIi?=
 =?us-ascii?Q?2Q83Wp8MLmk66606ZaFLk0HOQKKOA/lmi6dDogPOGmNx62GqekD4jnPcydnU?=
 =?us-ascii?Q?eAH8G11OxVJKpMO5hjhAXHdG2DDFlUAksBStxAGoJ6sd+yLM631+PcAqx3vS?=
 =?us-ascii?Q?A0PB6XB+Ps/30dRqV4pxeiV6YxdfSDhOg+uAcOcwlJXV5VheeAFkJFZBWdxw?=
 =?us-ascii?Q?HyhKZnAkd6xpMGOkg6eIE69cRUb4KtL2zA4DoP+CuOX+gJS4348iuF93L4Mo?=
 =?us-ascii?Q?JrT4z0WqNT2Qnka7phQ6W0ZFFmlhHOzR90znwA73Rv9K2fkbFh11R/kCC+km?=
 =?us-ascii?Q?upT5yWS1DpppK5Fl4ikDZ0ocVsbyKaAc73NqpSHVCJwnhYOI4K5zw6er+167?=
 =?us-ascii?Q?wASmnTpfQiY5fGSsGv/SFnrDZj3KCtnpLTB5gS5cbNlp3BXYpSPG+tdigrex?=
 =?us-ascii?Q?Fh+3E2UMhF0Nmnmz8lPiD+lW82wmPb0udqbI+2H/Uwek4W5OLaN0IGpNYalh?=
 =?us-ascii?Q?8zy9uU0cW2dztebh77Kz6fJvQYnbjijauANQGW+tdbc6jatwt/mr8IaE31ZI?=
 =?us-ascii?Q?BkKl5MmFwdkAv/Os67RVPh9/+U9HFaGFirXCoSVHyLTovjBTLhZmkkl+zESv?=
 =?us-ascii?Q?vYWL3Te7k0O0UzBX7B5Kr9NLqdsyBsue/SWPW6nPWDqvjV1ZMzVLc6Rq79Xi?=
 =?us-ascii?Q?pZUaqhKUbt0HV+qJ5GXbv0MB4mWzzYQnhqSBPdaVhZEnUWLB6n3SMRXeQxE2?=
 =?us-ascii?Q?qIpopttGJ9ryCTSzunE3M0r7M5jFiIpXTZY31YwK3VaQDj8eDOUhqeL4Iakw?=
 =?us-ascii?Q?WLzmVvlmxWAJC/cMLnjuq0NgQNakNlMkwyY7Fqg23fcs/m1eFSYUBtms+So/?=
 =?us-ascii?Q?XKdYcJbc49VhJGY6Ib2LGNuZi5u5+HQfQy8NDG0OSrEzBsR2+6Oth4SYebLY?=
 =?us-ascii?Q?NaLFUz7Vo0sRhWAr+zYG+y608n2UxbgubdAMaw12j1sITwtqYIfE1fOwKjWS?=
 =?us-ascii?Q?puwccP3UjWoyriYWRkQWNPxGc4czK8c5MixVIJQ1f4LP/jNU3yx34RHJk0jh?=
 =?us-ascii?Q?fPSGMrmVeaLRwEYzCYni+LLqMPIbejtHS0SDRrKxBtKECbuCakfbqcgLzCrl?=
 =?us-ascii?Q?02HnNVnto7di9aXhLNOM2RiTI+Jg8XBAuJOUB6TGrGhFuCxCHE18mHG/YEl3?=
 =?us-ascii?Q?8W/xHrA65CWO+aXoVBsRHjBqpIrcge77KkqsP77n6TBMjQa9x4/9kJzIeXiC?=
 =?us-ascii?Q?HRindc6aX+MVfdvJkb0oMlwqlJPTbkByFo8/6Q+dCK2yvMeAWWk5Bet1awLJ?=
 =?us-ascii?Q?eBO0zK3ft+VoBNtNLvDMhNJEX7FNLVg=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4fb73a77-7b6e-4446-6d95-08da192a9764
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2022 06:39:54.6858
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +a73N6bhs0UHZXIC+0Yy4taj7VZChFmZAwAujIVM7eCn2IGR9xOq0G+LnXZkgZORvV0Lk6emFE+SX1e7syRxLz2lLekoVGke62SDiThlQdA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB4956
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.850
 definitions=2022-04-07_01:2022-04-07,2022-04-07 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0
 phishscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 spamscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204070064
X-Proofpoint-ORIG-GUID: b-2odTNODYfZS7L6-5ftJ-8ON3BeAlFJ
X-Proofpoint-GUID: b-2odTNODYfZS7L6-5ftJ-8ON3BeAlFJ
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Apr 07, 2022 at 08:12:49PM -0500, Rebecca Mckeever wrote:
> These patches replace ternary and if else statements with
> more readable statements. Found with minmax coccinelle script.
> 
> ---
> v1 -> v2:
> * Patch 1: "staging: rtl8192u: replace ternary statement with if and
> * assignment"
>   * replaced max macro with an if statement followed by an assignment
> 
> * Patch 2: "staging: rtl8192u: use min_t/max_t macros instead of if
> * else"
>   * changed the type argument in min_t and max_t from u8 to u32
> ---

Looks great.  Thanks!

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>

regards,
dan carpenter