Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <cover.1648461096.git.zong.li@sifive.com> <mhng-6ddf988e-9f86-4f3e-8b6a-6be65f384829@palmer-ri-x1c9>
 <YkU6dPFNPkD0Jay+@matsya>
In-Reply-To: <YkU6dPFNPkD0Jay+@matsya>
From:   Zong Li <zong.li@sifive.com>
Date:   Fri, 8 Apr 2022 16:03:22 +0800
Message-ID: <CANXhq0oz_zNHJEaWxk9QFy=sDf1cKmrJROn3pEfQWo0AF2Cetw@mail.gmail.com>
Subject: Re: [PATCH v8 0/4] Determine the number of DMA channels by
 'dma-channels' property
To:     Vinod Koul <vkoul@kernel.org>
Cc:     Palmer Dabbelt <palmer@dabbelt.com>,
        Rob Herring <robh+dt@kernel.org>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        Conor Dooley <conor.dooley@microchip.com>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Bin Meng <bin.meng@windriver.com>,
        Green Wan <green.wan@sifive.com>,
        dmaengine <dmaengine@vger.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org List" <linux-kernel@vger.kernel.org>,
        linux-riscv <linux-riscv@lists.infradead.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Mar 31, 2022 at 1:22 PM Vinod Koul <vkoul@kernel.org> wrote:
>
> On 30-03-22, 20:15, Palmer Dabbelt wrote:
> > On Mon, 28 Mar 2022 02:52:21 PDT (-0700), zong.li@sifive.com wrote:
> > > The PDMA driver currently assumes there are four channels by default, it
> > > might cause the error if there is actually less than four channels.
> > > Change that by getting number of channel dynamically from device tree.
> > > For backwards-compatible, it uses the default value (i.e. 4) when there
> > > is no 'dma-channels' information in dts.
> > >
> > > This patch set contains the dts and dt-bindings change.
> > >
> > > Changed in v8:
> > >  - Rebase on master
> > >  - Remove modification of microchip-mpfs.dtsi
> > >  - Rename DMA node name of fu540-c000.dtsi
> > >
> > > Changed in v7:
> > >  - Rebase on tag v5.17-rc7
> > >  - Modify the subject of patch
> > >
> > > Changed in v6:
> > >  - Rebase on tag v5.17-rc6
> > >  - Change sf_pdma.chans[] to a flexible array member.
> > >
> > > Changed in v5:
> > >  - Rebase on tag v5.17-rc3
> > >  - Fix typo in dt-bindings and commit message
> > >  - Add PDMA versioning scheme for compatible
> > >
> > > Changed in v4:
> > >  - Remove cflags of debug use reported-by: kernel test robot <lkp@intel.com>
> > >
> > > Changed in v3:
> > >  - Fix allocating wrong size
> > >  - Return error if 'dma-channels' is larger than maximum
> > >
> > > Changed in v2:
> > >  - Rebase on tag v5.16
> > >  - Use 4 as default value of dma-channels
> > >
> > > Zong Li (4):
> > >   dt-bindings: dma-engine: sifive,fu540: Add dma-channels property and
> > >     modify compatible
> > >   riscv: dts: Add dma-channels property and modify compatible
> > >   riscv: dts: rename the node name of dma
> > >   dmaengine: sf-pdma: Get number of channel by device tree
> > >
> > >  .../bindings/dma/sifive,fu540-c000-pdma.yaml  | 19 +++++++++++++--
> > >  arch/riscv/boot/dts/sifive/fu540-c000.dtsi    |  5 ++--
> > >  drivers/dma/sf-pdma/sf-pdma.c                 | 24 ++++++++++++-------
> > >  drivers/dma/sf-pdma/sf-pdma.h                 |  8 ++-----
> > >  4 files changed, 38 insertions(+), 18 deletions(-)
> >
> > Thanks, these are on for-next.
>
> The drivers/dma/ should go thru dmaengine tree. During merge window I
> dont apply the patches
>
> --
> ~Vinod

Hi Vinod,
Many thanks for considering this patchset :)  Could I know if there is
an opportunity to pick this into the following few -rc kernels?