Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Subject: Re: [RFC PATCH 5/5] x86/mce: Handle AMD threshold interrupt storms
To:     "Luck, Tony" <tony.luck@intel.com>,
        Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>,
        Borislav Petkov <bp@alien8.de>
Cc:     "hpa@zytor.com" <hpa@zytor.com>,
        Yazen Ghannam <yazen.ghannam@amd.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>
References: <20220406063542.183946-1-Smita.KoralahalliChannabasappa@amd.com>
 <20220406063542.183946-6-Smita.KoralahalliChannabasappa@amd.com>
 <b140590dadea411ca3641b0537bfcd9f@intel.com>
From:   "Koralahalli Channabasappa, Smita" <skoralah@amd.com>
Message-ID: <30c01863-85ef-4cd4-9e73-340e2d98b9bf@amd.com>
Date:   Fri, 8 Apr 2022 02:48:47 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.2.1
In-Reply-To: <b140590dadea411ca3641b0537bfcd9f@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NEJLNWNIZ2FiOUxVdXdIMTl3Q0FzK2ErL3VsSDlIU0RKRGJPRGNRd00yR0Jr?=
 =?utf-8?B?V25UUHpkamF3eXppQU9QVyt0NVFRWU00MGVMYTJEdHVRbDM1UWp5V3ViTmNo?=
 =?utf-8?B?UWRBTXJVcXFXbjBLMlZUS1FWODhBYnozZmNHeklnd3ZqQ3pTNkZFWE5vRnhH?=
 =?utf-8?B?OWw1RzlUSVRGaWMxeEVER2V6MExYNmt3aHBmcG5CeEYxRGRYWlhyS3hGTFd2?=
 =?utf-8?B?VHg5SVk4Q0E2c1ltOVZnWWhSU3gwK3RtYkRwbGJyQUloWml3ei9OcEg0SFg5?=
 =?utf-8?B?ODM2WmN3NEZEVHcvYlcvVXFma3RDd1NwODl3L0xwb2pGTHNXMEU3cDFJbDBX?=
 =?utf-8?B?MUhMZ2dRcGk0K3FoQmxtWGZqbzdPQU9JQ0tPWkY2M0h5UG9BUHNVN0phU3ZH?=
 =?utf-8?B?U2xtMndGU3JaSFNZYmJpNlJ6NlFIVkU3YTVVWWNEUXNQU1pDTnhJNW16WUd2?=
 =?utf-8?B?MGZWZGJQWUxnUWF2aUo5a2VwUDZWWERpRWhuMkdPdXJZbkQ3Z0hRQko4bWVK?=
 =?utf-8?B?cU40UmZGaFIzRGJMT08xRmM1YmZFbEVWSU1xcDBJRU56YmdtZnZBWEdLWHFG?=
 =?utf-8?B?cHFaVERvc04zUWkya21zeDFVSVlpN1JFV0N1cmRvTkRZT3JPdmRHSzVqRHEy?=
 =?utf-8?B?bndjdVplbWpLczUzMk9uUVFReEZzNmhERjI2NnA2VzNOb2dxR3lDN1orc1Ft?=
 =?utf-8?B?Ty92dmUxWDVQVXdVbHZhVkxsZE5xT0tSRGlJYXA3bytnV0Fxd00xUUtnUkFl?=
 =?utf-8?B?ZmtPMnZISGVRN3JDdSsxVkFxWSs5QkprUDB0bEVHeExxeERwYjNpZkd1bHJ4?=
 =?utf-8?B?YjRDNm9yZG5NUWI4WXRmcko1cjZVZFRxY2p3L0c5V01IaFZjRjBDRFg1ME9r?=
 =?utf-8?B?Tm80bzREYXFQNW9BV29PZmFINHZIQ0h5eFIvZkdhQmEwcXZHMEwza1JpdWpT?=
 =?utf-8?B?SGJGUEdLWFZPMXhMVzBvN2hmeU1xekNhN1BYaHRweVh6c0MzcVU5RjNnMnVR?=
 =?utf-8?B?V3JZYjdsRXpvQlNZS1ZPbG45Y2dlSXh1TEkyMUxScnNpY2hjQ1dOc0hGMG15?=
 =?utf-8?B?R3YzbS9rTTczaVRYc2w3MC9KRDZBbnBRZ2M0MW1GN1ppRXhibVhCSzlYYkNp?=
 =?utf-8?B?OElwYXQ4ZkFjeWRqTUx5UU4zYmE5RVFvd3hBY1QvcDFXNDk0c3J5WFBlK0Zu?=
 =?utf-8?B?WFltMWFLVk1wYnkwWTdsZ0tEVEhyUUlQQnBJeDRvMGNsaVIzYWxKY1ZWcVBn?=
 =?utf-8?B?b0JubkxMVFg5VjJHWStoV2JPcUk3SVJnWkZ5ZERKWVI5VjFPZXJyYkFzbzNO?=
 =?utf-8?B?SnJqNktGcnRWQUJYNkQwNHJyckVPRGtRRnVvU2JOUUhSWlMwYWxUemJWRmkx?=
 =?utf-8?B?NWhkZEhhbElCS0lYRWx1OU9EOUN2cmJaQkFwTUt3bFhEWHR4VlFNUGpvc0tW?=
 =?utf-8?B?UXI1NnJwKzBSVVlCSzVDWEJEM2ZKb0hkd3BJNXJjcHozRm9vdzI3d1BvdHdt?=
 =?utf-8?B?aGFMNEtTTWhIVCs3S1A1UHZkQUtIZXNxdExFQlpFL1c0UWd5S3E1MmZwWUdF?=
 =?utf-8?B?MkxkWkY0TURlWjNqWnFwVFh1VnozUXFVV3NpL2lZay9KSTBINVhvWG5nUnI4?=
 =?utf-8?B?aGVOQ2lNaEkrOVcyckFQU29CVCtwYlF2Ti8yR2hwNXFSaGk1Q2xmS3k0RlFU?=
 =?utf-8?B?Zk9kYjNGOVdnY3VZSjJVcUt0b0NJMVY2NnE0Y2VQaXFaUk8vdENVNThWclNI?=
 =?utf-8?B?WmkrTUxHNDBmRDJ0VE1mcnBlZU9ITldEWHNyU1NQT0t2K0txTFNiVWZHSncw?=
 =?utf-8?B?YkJNZGdTNG5vM3hPa2NleVQxYU1mbEhrNDZSYVZqaFVBaTNFNkh0S0srVlNM?=
 =?utf-8?B?b0ZPWjdZa05udkNHYlBob0gybTdLQnFibDZyUmthUTVMVDlML01HaXR5dFBa?=
 =?utf-8?B?UjNJeWJEQkFvMklsRHltdUdtQmwvRjR2SzdtTHEyb2Z6S25qeUhKVE5UU2Vu?=
 =?utf-8?B?TWNSV0s0T2kxOUx1Y3hocGdiSHU3VHZTekRxTE1TTERvaWlzZS8wMzJDVDYr?=
 =?utf-8?B?dDlVWjVza1IwWFdqek9neEM4MUJkN0cvSklaTE1DcmJaTGd4KzlPSEs3bEFX?=
 =?utf-8?B?VFFJaDcveGtSRXB0Wm13ODFBRzYrek1uZ3VGdWMvVHVyTm9aWDlFRm1iekdQ?=
 =?utf-8?B?d01WdSthaEVjL1NETDZqVG1XbUxxV3k1b0VoMlNVc3Q5cnlKak1VMk43OE1B?=
 =?utf-8?B?cnQybmRxVDNPVDJOdkpsaVRCRk9lWEJGTkRJWHVySmtvbFpZekNOVkxPWEZm?=
 =?utf-8?B?TG5xeE9Hejh2dU0rTGhpUXpqdHg4aENCQk03elJwYVJkekxiS3BPWWhmb0ty?=
 =?utf-8?Q?wexHgshG9c3qjs/PYm0L7Qv0wQhoQfa70bLOXVRwMlbvi?=
X-MS-Exchange-AntiSpam-MessageData-1: N8WKptld5d5nJA==
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5c9909f0-399d-4d01-f2f1-08da1934382e
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB2869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2022 07:48:49.9972
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Xtu3ZdC7HLYBEBN7YoYV5Uviu1Z3mKJTtsStNLSUrd1a4f+YcFrq0x8UZzSqkJxXfo8UEoxKGdxCeNRWS02BZw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5187
X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On 4/6/22 5:44 PM, Luck, Tony wrote:

> +		/* Return early on an interrupt storm */
> +		if (this_cpu_read(bank_storm[bank]))
> +			return;
>
> Is you reasoning for early return that you already have plenty of
> logged errors from this bank, so OK to skip additional processing
> of this one?

The idea behind this was: Once, the interrupts are turned off by
track_cmci_storm() on a storm, (which is called before this "if
statement") logging and handling of subsequent corrected errors
will be taken care by machine_check_poll(). Hence, no need to
redo this again in the handler....

Let me know what are your thoughts on this?

>
> -Tony