Received: by 2002:a05:6a10:144:0:0:0:0 with SMTP id 4csp98932pxw; Fri, 8 Apr 2022 02:10:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy8jFFEGgyXNGBEcKb2ypOLBsCaKzwZpxNE08UQZO+3NJ89vrMIUHEWHTZ0E1xQfaXfmROV X-Received: by 2002:a05:6402:4302:b0:419:4be8:6493 with SMTP id m2-20020a056402430200b004194be86493mr18586638edc.294.1649409006415; Fri, 08 Apr 2022 02:10:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649409006; cv=none; d=google.com; s=arc-20160816; b=xB7zEFm8aeVDDhoJ3oFbPDsIH3jKBsUn5VwiepIUUqure5xvKI5R4A+6xxoSd4j0Ba Os9fp5zcnBMHWuncvb1DRInVyzzmQvGoFfwm4OkN1wMEQm63Fg6VIjGoxsWY1oIbsUCD fOZOkS/A1GVC7Mp8BH78ANuKU0TPJasbKoBJo26/WgRCWtZwb4khk/SK/WtAo3ZNUBQD cmx6rlm/r2T4W75/9tJKeD5bvrA03K/gmEr+ZntLbfNzRug4jw+Cy5CFrMngGIngnsBX FhK31PSPQ/myCbOnhLekNci0hH6LU1Mo8vBPvpsvI4zKcOBFSBYNLHl+xFE77EN2ioTH VkRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=yuQFl788i69gkuHZnfVhALt8fZsIexOSaYwO7DsFL54=; b=kIVmOcpQMUIIRotZ9y6DJ8A7TrR46mf40WwbyYCLF6M5I7qVONKRQnaUTIl6yrMFuD cMmna7qsgZzD7VJlD7sPMqvOM3lWI2ubYIFUWQu4OtEsil0p6MWv++dwjO9D740rmeRo lNxKOTBau76cT74qr+aE2HOB882mnvSex3s49NP/3PEaaGxppTtbb5TYLxrcW3yxDbwU Lf8S85yqvrnn6xqkORZWsXIPxvsvQgOoqN3Y18cBhdLgdzuHxrPt4dofL8GQkoUsG4pf 6ZWC0aEyld+RiTwRkEfSgBx/SVSnUWSaLqfY1QIiYdMm68N6h7MUAP9JrInD28MgNnuj nfKQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=gx8vkxt3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id tl1-20020a170907c30100b006e7b159466esi535430ejc.403.2022.04.08.02.09.41; Fri, 08 Apr 2022 02:10:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=gx8vkxt3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231417AbiDHITf (ORCPT + 99 others); Fri, 8 Apr 2022 04:19:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231382AbiDHITd (ORCPT ); Fri, 8 Apr 2022 04:19:33 -0400 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6FA6625C9 for ; Fri, 8 Apr 2022 01:17:29 -0700 (PDT) Received: by mail-ed1-x536.google.com with SMTP id k2so9158058edj.9 for ; Fri, 08 Apr 2022 01:17:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=yuQFl788i69gkuHZnfVhALt8fZsIexOSaYwO7DsFL54=; b=gx8vkxt3S763Ala7vzwT1kODYsT4g6h9F/zXUPb23Kp7SxBqah2MLv/qepESsLFEk6 I0ssg1XGAfLpTdDwbWD4XOyGCf1OaXP7MTUwFge2EkjWfCqDuI9cbnBKQghpKTSNb+FZ qQiXqB5C+6GD7/kuW52bYq8t0iaiLUOwEH2Gy5BwrGYXzXXkp7NTwGQcZ2MpnvUUOoRE 8UllVY1p3GkIjUo9lvPFKOrk+3+oTIFWk3jYgmGy2leoAdfs+MGwaRimWw+KYJ0Gamjn j+cp3u90dmMQdHjdkVO7f2J+JL8VKRUppRdrEM545wEFGS7/HXzUyxt2c1TjJNQuTQQ1 yHtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=yuQFl788i69gkuHZnfVhALt8fZsIexOSaYwO7DsFL54=; b=rGsJkcifl5Y1W9q0iZKMwSrN0At5Yc3WRF3gEQIukKh31g0VMzo2H+07MtDhVFpWf+ fZgAUpLo/GzHYSyc/7BcT0WhP8ww7pNujIJVGT6Hq3l6FqweB44+VUH8pt5p03SorPbf EtFBwouohoLGmKAB+bYi7oxvm2ENvmymiWyp+VIaBbTXAXhq88s2KnfnQrW0hUy3qU4I vDDlq9A6Xq12A/VIluC0iX1ZVAwJPIuCfoCe1Ou0A78MG/sHMFGfpLLUE5Wht5oG96Hi JIvKYq9olkocYNMsrsrtTR7jZYVrQ8YClrCY8J4sCnHwgujBni7Qsl5jat4ymPQg8lbD wkNw== X-Gm-Message-State: AOAM533PM6wRkv0TmwAgSwr+tOEC6gzA2MCyQnPpUKlAmgBh9f/oJ1A3 u9pYVn+KDtRt96PwbI509Hcovw== X-Received: by 2002:aa7:d287:0:b0:41d:79:73ca with SMTP id w7-20020aa7d287000000b0041d007973camr8932500edq.142.1649405848011; Fri, 08 Apr 2022 01:17:28 -0700 (PDT) Received: from [192.168.0.187] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.gmail.com with ESMTPSA id h26-20020a170906111a00b006e778bd4fc8sm6167691eja.38.2022.04.08.01.17.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Apr 2022 01:17:27 -0700 (PDT) Message-ID: <855d7daa-45d1-d6d8-32bd-51778cf58392@linaro.org> Date: Fri, 8 Apr 2022 10:17:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v2 1/2] dt-bindings: devfreq: mediatek: Add mtk cci devfreq dt-bindings Content-Language: en-US To: Johnson Wang , cw00.choi@samsung.com, krzk+dt@kernel.org, robh+dt@kernel.org, kyungmin.park@samsung.com Cc: khilman@kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, jia-wei.chang@mediatek.com, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20220408052150.22536-1-johnson.wang@mediatek.com> <20220408052150.22536-2-johnson.wang@mediatek.com> From: Krzysztof Kozlowski In-Reply-To: <20220408052150.22536-2-johnson.wang@mediatek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/04/2022 07:21, Johnson Wang wrote: > Add devicetree binding of mtk cci devfreq on MediaTek SoC. > Thank you for your patch. There is something to discuss/improve. > Signed-off-by: Johnson Wang > Signed-off-by: Jia-Wei Chang > --- > .../devicetree/bindings/devfreq/mtk-cci.yaml | 72 +++++++++++++++++++ > 1 file changed, 72 insertions(+) > create mode 100644 Documentation/devicetree/bindings/devfreq/mtk-cci.yaml Filename with vendor prefix, so something like: mediatek,cci.yaml Also please put it in the "interconnect" directory. > > diff --git a/Documentation/devicetree/bindings/devfreq/mtk-cci.yaml b/Documentation/devicetree/bindings/devfreq/mtk-cci.yaml > new file mode 100644 > index 000000000000..ef4ea951025c > --- /dev/null > +++ b/Documentation/devicetree/bindings/devfreq/mtk-cci.yaml > @@ -0,0 +1,72 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/devfreq/mtk-cci.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MediaTek Cache Coherent Interconnect (CCI) frequency and voltage scaling > + > +maintainers: > + - Jia-Wei Chang > + > +description: | > + MediaTek Cache Coherent Interconnect (CCI) uses the software devfreq module Do not reference software implementation (devfreq). > + to scale the clock frequency and adjust the voltage. MediaTek CCI shares > + the same power supplies with CPU, so the scheduling involves with CPUfreq. The same - cpufreq. Instead, focus on the hardware, what do you describe here? > + > +properties: > + compatible: > + enum: > + - mediatek,mt8183-cci > + - mediatek,mt8186-cci > + > + clocks: > + items: > + - description: > + The multiplexer for clock input of CPU cluster. > + - description: > + A parent of "cpu" clock which is used as an intermediate clock source > + when the original CPU is under transition and not stable yet. > + > + clock-names: > + items: > + - const: cci > + - const: intermediate > + > + operating-points-v2: > + description: > + For details, please refer to > + Documentation/devicetree/bindings/opp/opp-v2.yaml No need for description. Just "operating-points-v2: true". "opp-table:true" could stay. My previous comment about its removal was a wrong advice, because opp-table is used for a table being a children of this device node. Best regards, Krzysztof