Received: by 2002:a05:6a10:144:0:0:0:0 with SMTP id 4csp100468pxw; Fri, 8 Apr 2022 02:13:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwDwydrf8PYfizC6BbucwPPH10qN6+1GtlAK+iPhxzdKAl0poZOjqK68eU6HB/OrNgcxTWt X-Received: by 2002:a17:906:7316:b0:6d7:16be:b584 with SMTP id di22-20020a170906731600b006d716beb584mr17254413ejc.759.1649409207844; Fri, 08 Apr 2022 02:13:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649409207; cv=none; d=google.com; s=arc-20160816; b=M7HgU7Km8HyZXmYOm9KJAXv9//K3HWcRTXmtOIRr30swKDuAjzgoRDMXbWnYk5E1by Vlnd5koZx8u8zCOX1okMVdLo2QA3KB+s170K4fjVXp2mVqsU5cvd/E69mEa7o9nZ9y9f vUeExfvfjruDjN//1U/T0nnuzo3m2NJJSrp5uhDYezPhUDFSP63UFr1t8DyKBQ2f+aCu jxdy12wq6BCy4xuNyBkEgWqf9CUIfMG5lbD9NAA6zdp1gGOByB3c1TlDe1kjY4ViO1BT SAzm590SlGw8dvPX/ErOlHhkiWtkKRJ51vYfoT3/j7ajbqZkzouREcMnspmuWkwd2A5R +xhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=3Km0SRkFuJzfFORvv+1Vu4L8xEAbLx+rsw9hJOrFKqY=; b=yookrhljT7ImzXb8C93FBoYknBGn1vOzf3OBz1Wg10PqWl+S1qIv06GPIWGH3oYFqs XtdV5pn94623amrdhRozcC0I0PIRFmuP5/f90/5isVZwEny5qbTduQrNzxDbC/tTfoDt gZc2vb4glvRX2Sfflb61c9YmZ/sFHbgqbvjdwYp5UnkHIAoV3bpRIGWFiCw3YDo+K3W9 OuGifXVuRaG5ciNZh5OqS+nQWOaZ5zrRVBEAmyziBP7jPffuJQ4kFv6SS8dWZYPfL6AA mARdA+uzSnQFzaS5EM9+F1uHb5RSJeuIILsUHVsLbnlAcleQFE+cXw6K+qZEdCJgQYrq sK/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=AGaSlQ5G; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y6-20020a056402270600b00418c2b5beaasi416107edd.396.2022.04.08.02.13.03; Fri, 08 Apr 2022 02:13:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=AGaSlQ5G; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231490AbiDHIVJ (ORCPT + 99 others); Fri, 8 Apr 2022 04:21:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46046 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231534AbiDHIVH (ORCPT ); Fri, 8 Apr 2022 04:21:07 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C8597E09C for ; Fri, 8 Apr 2022 01:19:04 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id 3CE601F46C62 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1649405942; bh=n3PZ5EP+atv7EGkUpF8rFTDvYYK90dAfeWT4ALjfgCk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=AGaSlQ5GwsYXwaRRFXeblbG7SziGG7emykikpIAfxEU0y7PwcVwq+u6+VC78eN7ac dvw4nM8YN/wlDXzinoeJexXRkswap/l5Ls4ByFmjq/HeK24G2a+ei3E/QPHNlU+kb0 FACQyoSJTpUN6/Qwc7zjRsdxlPDWzX/WDlEMy/6m4XewBkGSzAmTCCLqrY3gX6T3hj I96FsuASNPhaQ76uG7hfT1gtyOnHu5KrRh3XnPIl3aQoVUBLlIbyAfSs8KB68bB0ZK EkXH2Wm3jvEvoVccIPRgGHjU+2jhsf2pcMh5mSC8js3K5Of3XDs8yFPmkJJr5iHzGr Z0TDgO0kfr0gA== Message-ID: Date: Fri, 8 Apr 2022 10:18:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v2] drm/mediatek: dpi: Use mt8183 output formats for mt8192 Content-Language: en-US To: =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= , Philipp Zabel , Chun-Kuang Hu Cc: kernel@collabora.com, Daniel Vetter , David Airlie , Jitao Shi , Matthias Brugger , Rex-BC Chen , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org References: <20220408013950.674477-1-nfraprado@collabora.com> From: AngeloGioacchino Del Regno In-Reply-To: <20220408013950.674477-1-nfraprado@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 08/04/22 03:39, Nícolas F. R. A. Prado ha scritto: > The configuration for mt8192 was incorrectly using the output formats > from mt8173. Since the output formats for mt8192 are instead the same > ones as for mt8183, which require two bus samples per pixel, the > pixelclock and DDR edge setting were misconfigured. This made external > displays unable to show the image. > > Fix the issue by correcting the output format for mt8192 to be the same > as for mt8183, fixing the usage of external displays for mt8192. > > Fixes: be63f6e8601f ("drm/mediatek: dpi: Add output bus formats to driver data") > Signed-off-by: Nícolas F. R. A. Prado > Lovely! Reviewed-by: AngeloGioacchino Del Regno