Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Yihao Han <hanyihao@vivo.com>
To:     Hannes Reinecke <hare@suse.de>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     kernel@vivo.com, Yihao Han <hanyihao@vivo.com>
Subject: [PATCH] scsi: fcoe: simplify if-if to if-else
Date:   Fri,  8 Apr 2022 01:12:37 -0700
Message-Id: <20220408081237.14037-1-hanyihao@vivo.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?9hIIbnRUWIvANOMbSA9VaubEEor8aCffYNdfJEhvPh1LBLlYmIYwftwuLvRG?=
 =?us-ascii?Q?7ylkPXPw4p69pwi0ymVnLpG2SF+mcN2q/A3GpdjzxBaRCbv6OXKBYSSKaPrm?=
 =?us-ascii?Q?T1FzbsXiTakR8Pt2FLzY/obUtqOD3V2SC46jUSzbh+YLoCByn1PCnEjMwI3p?=
 =?us-ascii?Q?KDu12N0PxFtODGZ7y4iw4d2tPdx13Car6JXI8Hi3BM+mnG4fg8MBYo4yWmKC?=
 =?us-ascii?Q?mTQS5kjoulNoFshgDyJWme0pNORdQ703yZn8w0l3WBe1wpFp0uKHHitr0rK8?=
 =?us-ascii?Q?lAZQ81VY4DZjuun4xO7aywdZ4QzaMN2SWv4fwQdWMVx8ldPlz8c2bDFRDWk8?=
 =?us-ascii?Q?xEOLPvzYw3I2EBeVP3q5f58xgcDnblPsksuCpOhVM7NjFizzIVQs9dWHV9w2?=
 =?us-ascii?Q?Nsz1S3DPaD4ULqPuSJHJMMI9FyH0WbV6SE7OKW9BabSFDTvC0rtzm3zS0gdt?=
 =?us-ascii?Q?4tLXi+PmR6956+s4LiBd169lQR0btT6kSE2ytAAwcuq2Qafkt7KJKN1PWUia?=
 =?us-ascii?Q?QCyw5ts69jne2LLI4KKGvuseaU6c8TL8OvMFhmRSqrRhvlkKWbmaJuhKdE8A?=
 =?us-ascii?Q?rBLBCGNFA0CwTe/4Ljo9bizrXaZoPuB5M+HWGtlAzSAwgNl9okhOwO5Xjgyi?=
 =?us-ascii?Q?ZECnGq7ngqETR5sZdLNbC4u5SfkonhxpvzjnyXhvVY3tJjGGeAAMomiIOxaW?=
 =?us-ascii?Q?sRgclkBfpTOsCSVXcKn7U3wA3fdunZ6z+L8jH844acSuYR9C83z8KwRN2k+x?=
 =?us-ascii?Q?sMxX6tF7wJuG9rNCa46RN2HfOVmfMmUXzmPCq+OO/8qBPPHYmVGHgQ44o8pu?=
 =?us-ascii?Q?iJhu/TIyFcvXCjLb+VIHpovwVc6TaWxKts7CbEVWkPRAWenQ/gT2ql5Jz9nc?=
 =?us-ascii?Q?eai8oFEWtDYL05Or2D8fvwOiMH7Ia0nAys6WRX5zp17oBJoGdB9ji5L2JVxI?=
 =?us-ascii?Q?98btrV20LlUVF1Aj97bOjT3cTgk5AxM9AGqQLU1oEZSu0wwWAmBakIlF+o2i?=
 =?us-ascii?Q?SWhWycP7AJ5j79KMOvz1cy6xozjdB4P6PncwxCcIxeYdugWnwan8uKOeRTBs?=
 =?us-ascii?Q?1liG1UsPY4BTVjmh5GainXk/0R3+omYsmV9GIydAqYoz2iLTy2lek5/13F89?=
 =?us-ascii?Q?oNHT8BLdPWMYchml1RcDqfAQg1c+Wwde37qzYhvwijrKNfwPRsq94XCCpM8D?=
 =?us-ascii?Q?ZYb420UC2vO3d0ML1F4RmmQwwWfL7cBZyI06JLgjI/AYqAmazz0iNzrUY2xO?=
 =?us-ascii?Q?KH+g99ZSmJ1vRlhKpwaBT/vJ9wFbqS2jfDaS3qNg3stsZY7NWVqAU9kQnvvL?=
 =?us-ascii?Q?8RKXtkwgy8J9v2OWO1igbqHm5IDvFkGfLZdIWsbw5j9PHjd+toTxJHvlPqLv?=
 =?us-ascii?Q?kqBJSk9SYofco8Nw5uuZlGT0CztSOVmzXbjOlq76eEU6zX9nBulhy1wU2S9K?=
 =?us-ascii?Q?UY6DlG1s2J4xcxVpg1yX0opNQkQF6EDzjTpvu53JFBf4YyuyGZ052Q0a3xq2?=
 =?us-ascii?Q?8cGC2N56cCigJliEOaUO9TudmkEx+9PpG5STVyuJAmr46cHg2a5n8Ee4UQ9H?=
 =?us-ascii?Q?LYZher5R+CGjybkZaEwMfiHKokv2o6T0d+dm1xDoO/3AMPeZ7nruazSUz6oS?=
 =?us-ascii?Q?xNp9zqYnRD7lcS/JFcZDFn2lfFhuXkdjq1mO6qPUyhwgRf/7WLESojFA4Bok?=
 =?us-ascii?Q?YCPJmEhxonFFjdo+0q49Tp+XLsNOtdTFA1cirQq/h4kDgIGJCtTk2rVA1KpD?=
 =?us-ascii?Q?jKp1N1gsOw=3D=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 46edba7e-ea77-411a-8e73-08da193861a1
X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB4173.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2022 08:18:37.4748
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OfcgoIf2zGtfMDlKnKoqiZV82m/oBZghSDnQufcaQ5FKgFktq0K1pQbdwu3UpRdOwLIg4HcQIHq99s+WoYIQEA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB4499
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Replace `if (!is_zero_ether_addr(mac))` with `else` for simplification
and add curly brackets according to the kernel coding style:

"Do not unnecessarily use braces where a single statement will do."

...

"This does not apply if only one branch of a conditional statement is
a single statement; in the latter case use braces in both branches"

Please refer to:
https://www.kernel.org/doc/html/v5.17-rc8/process/coding-style.html

Signed-off-by: Yihao Han <hanyihao@vivo.com>
---
 drivers/scsi/fcoe/fcoe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c
index 44ca6110213c..983e00135fea 100644
--- a/drivers/scsi/fcoe/fcoe.c
+++ b/drivers/scsi/fcoe/fcoe.c
@@ -2580,7 +2580,7 @@ static void fcoe_flogi_resp(struct fc_seq *seq, struct fc_frame *fp, void *arg)
 	/* pre-FIP */
 	if (is_zero_ether_addr(mac))
 		fcoe_ctlr_recv_flogi(fip, lport, fp);
-	if (!is_zero_ether_addr(mac))
+	else
 		fcoe_update_src_mac(lport, mac);
 done:
 	fc_lport_flogi_resp(seq, fp, lport);
-- 
2.17.1