Received: by 2002:a05:6a10:144:0:0:0:0 with SMTP id 4csp180100pxw; Fri, 8 Apr 2022 04:54:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyHHswvNytwIVBT8DqBumep77CPzaX5+DZ7Tr0CleEroD7wX8ygZsZzmA3m3WjWZFxsdgA+ X-Received: by 2002:a50:cc8d:0:b0:41c:b4f4:c874 with SMTP id q13-20020a50cc8d000000b0041cb4f4c874mr19276031edi.92.1649418849773; Fri, 08 Apr 2022 04:54:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649418849; cv=none; d=google.com; s=arc-20160816; b=IgbPqVrgPcfhQCPQyyKXaoSXjEOT5al1I8Ijpyf4dYKzo8iiQVE4WKmh8GyOQmvTWR 0z9OhDlI60Bbvi79ZhIb9815gDQEFe4oRNC+VScs2VYc6yeYF6oYneF1jOBksVhUwTA4 p5ICiIcyRhhAgJXcCWPKXIhEF5Vi7fX0QkHpdc26UPrZnQompqvTEhapFjxQBBCWiD8+ bCLSRkcBGxhOgaUGJKlsjAP8dM0i5UpUbD6oIliGeSN8pE+ExlFdj5VFR/QVeH4ia/dW 75buXDFSXQ3OAsbtwSAApcRYaZmkhEDw54Y06cEQDVDtOVV3T9ffwBymvlBxXCDKrf+e QhAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=+jxz4uDQ/O9Wz0r5Jryft+eFtOFBpK0Zq2KvWc3xbTs=; b=KK7cx5lQa2ZamXK6bfzCJvEwXF+X1vIv6p/QslsUeS+9z9kLxBkcEMmGL9oFz/yNj2 IfWIjTcE+gL2oDt1bp6wrOSVlDP48kJEB6LLCQHcy/rKhViIouZKK0++QnQHofPK8dWs eNMbHlfBjgV+3wHTkZuoh48kAr271Bb4VqkOYLVhq8ZxImCWQ/NSlbwKiLqaRJjBdJK6 tWwEl5YlyTWss6eA0cji0xv55BKVUeOipWlyIBp1jDx9A5RDlW3orbX0RU2hw6W3d5jb q+qroyMFgYOfJBsRwguB/xIYmw4weHBDvO3uNHCdZ1Wdy7+POPeCUZ1G+g7uMsiGZgkj qg4g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=E+HTIi1o; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l8-20020a509dc8000000b0041949d89125si673255edk.197.2022.04.08.04.53.01; Fri, 08 Apr 2022 04:54:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=E+HTIi1o; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234061AbiDHL03 (ORCPT + 99 others); Fri, 8 Apr 2022 07:26:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231779AbiDHL0X (ORCPT ); Fri, 8 Apr 2022 07:26:23 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 86E422E0A0 for ; Fri, 8 Apr 2022 04:24:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E81D061FA7 for ; Fri, 8 Apr 2022 11:24:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 76124C385A1; Fri, 8 Apr 2022 11:24:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649417058; bh=bZKhUAef1apcWbdBzo3Iz78dUuFA/2hoSWiMN4ip0sQ=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=E+HTIi1oTNk0sg7A2kDG5btHwhPFkUdAgLH+p44hzeMGF4yTpExspHMuCzrP/878A P+JBbGSOANbtFiK+Cd948O2LrdO4LRBCLaxSrqPcm4DRGLi8crvNVbHZqlAf/2p3FW p7RsEF0GiKTPpyH2CIZpLkNgi5pC9OjDoS9ksgX0dgaiO4tEiHIiYeQbtM/S87cBUN mZRzD2qFy/LMDucjWIyOdcVHhDoFP6rzlZSLqKpIFw+XJ9HgQkKyis0gi7cDlUqdBa ao+RDO/ge9nMX5ZGbfbVwgRFNPUTPQcCdf8Db/nXVUFvhsfrPvusccacd6l/WAzGuI oh7kU5zSxlF8A== From: Mark Brown To: ranjani.sridharan@linux.intel.com, liaoyu15@huawei.com, linux-kernel@vger.kernel.org Cc: liwei391@huawei.com In-Reply-To: <20220318021616.2599630-1-liaoyu15@huawei.com> References: <20220318021616.2599630-1-liaoyu15@huawei.com> Subject: Re: [PATCH -next] ASoC: SOF: topology: Fix memory leak in sof_control_load() Message-Id: <164941705720.1295287.17447478946565917709.b4-ty@kernel.org> Date: Fri, 08 Apr 2022 12:24:17 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 18 Mar 2022 10:16:16 +0800, Yu Liao wrote: > scontrol doesn't get freed when kstrdup returns NULL. > Fix by free iscontrol in that case. > > scontrol = kzalloc(sizeof(*scontrol), GFP_KERNEL); > if (!scontrol) > return -ENOMEM; > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: SOF: topology: Fix memory leak in sof_control_load() commit: 9b91d0ece22b9ab37fc185511c7f992e51c93d6e All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark