Message-ID: <46391416.3020708@linux.intel.com>
Date: Wed, 02 May 2007 15:43:34 -0700
From: chandramouli narayanan <mouli@linux.intel.com>
User-Agent: Thunderbird 1.5.0.10 (Windows/20070221)
MIME-Version: 1.0
To: Andi Kleen <ak@suse.de>
CC: linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH 2.6.21 2/3] x86_64: EFI64 support
References: <20070501185945.237601000@em64tdvp.jf.intel.com> <20070501190110.958988000@em64tdvp.jf.intel.com> <200705022255.37791.ak@suse.de>
In-Reply-To: <200705022255.37791.ak@suse.de>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1006
Lines: 30

Andi Kleen wrote:
>>  		if (type && ei->type != type) 
>> @@ -148,6 +178,29 @@ int __init e820_all_mapped(unsigned long
>>  unsigned long __init find_e820_area(unsigned long start, unsigned long end, unsigned size) 
>>  { 
>>  	int i; 
>> +	if (efi_enabled) {
>> +		efi_memory_desc_t *md;
>>     
>
> Please convert the memory map from EFI into the e820 map in one place. This
> would avoid all these weird special cases. Also custom memory map would
> just work then.
>   
I will work on this and provide an update patch.
> I know i386 doesn't do it this way, but it's wrong and we'll eventually
> fix it there too.
>
> Also you have a few arbitary and white space changes in there that should be removed.
>
>   
oops! I will fix this too.
> -Andi
>   
- mouli
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/