Received: by 2002:a05:6a10:144:0:0:0:0 with SMTP id 4csp206066pxw; Fri, 8 Apr 2022 05:34:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzzVHoARxB5xHPxFp0XOMZEnLiZueGqcKZNJnOSlSxIKgdH3hOjkku1rU0I5nPyi3BtZddT X-Received: by 2002:a05:6a00:26cf:b0:4f6:fc52:7b6a with SMTP id p15-20020a056a0026cf00b004f6fc527b6amr19361617pfw.39.1649421280040; Fri, 08 Apr 2022 05:34:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649421280; cv=none; d=google.com; s=arc-20160816; b=aNHo30rg0dnjUbii1+jBXLeSvYh6HDE1D+1RnoDbTlj72bG0DvGsggkIGqB9DxU2cz K2vDPa0nGvLUshJSmo27Mlmm9sIg+y57c4lOMJFxqe904srRPJ10xikn4wBiGGUiP1h6 hG070TEReYZVi0DoFvDn29QPCJr5uOub1sDpx+fVurLtbX674k7gwAXZQVDh3IVLtQNR q8P1qs1oonwFk99dYAEgR9kNrj510MVWczA/9/3bIeS4SRbMNJgD5fxJLOVB5HaQX+47 8D7tUl9xxRm8XjqZJ1VogH+WY3boHGEx5Mcm58IjgdSnwCiLfXXHR9LD14gXAvN1gJkO MHLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:reply-to:cc:from:to :dkim-signature:date; bh=rusAaDnliVYRoqaWx3ZseyT0eG4DdEtRKyDQafUunhY=; b=sSnLQryzGCxeqf9lFueim93LpoUHNXqH8Z3iZ98UVjqSlqdybS+u3Ev3lIEHPm6O2z et+t3cqE4uEbrCrFB9qqW803DYAgnRbhsrA2S+bqGvqeGDvwGoX6svIM8qBepTlXSNbd ykfvS6bTtw90CA95TRWyEWYsu4a+pGeheKZfXdFTZJG71RJouUZ0K3pPcsy211uQG2Nq X6jVPcXqvLI01RCabHFciuTTwn7BdSDwZv3uXufKc0ZG6w7sd2HpF3d0vUpadqzMdpzy Y8y7ii5js3CR5/iUt6ZMZc6vAfNSip5jRbQwwJxUMNpr0Ebntr2blyxv37Yu+cjuv9Jn z+1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@emersion.fr header.s=protonmail2 header.b=tCALG0eT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=emersion.fr Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t200-20020a635fd1000000b0039ce348f132si1221308pgb.124.2022.04.08.05.34.24; Fri, 08 Apr 2022 05:34:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@emersion.fr header.s=protonmail2 header.b=tCALG0eT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=emersion.fr Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234187AbiDHKDt (ORCPT + 99 others); Fri, 8 Apr 2022 06:03:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234158AbiDHKDn (ORCPT ); Fri, 8 Apr 2022 06:03:43 -0400 Received: from mail-40136.proton.ch (mail-40136.proton.ch [185.70.40.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7EF8313F89 for ; Fri, 8 Apr 2022 03:01:38 -0700 (PDT) Date: Fri, 08 Apr 2022 10:01:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=emersion.fr; s=protonmail2; t=1649412095; bh=rusAaDnliVYRoqaWx3ZseyT0eG4DdEtRKyDQafUunhY=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID; b=tCALG0eT8UMW1BL26yI62yvZGYqUvlm4cJp6HVttJFU/Vw68LIV2BjpljM4Yk2N/m 9UtMFeHqgbxq+W96l7dk+GGUmAYcK0bn3EcansddIBYaWYzPr+LLEEnrCaGDY+qy6w pHlaUS8CftUwPOTrMy7Thhm0tVPnPavcVt+CmrMIBIvuP3UVa9k3k3MmL1HiJUPo7B dOqYSAD8APV/Ov8RDlIWtgDmk/9hRVQZyxgzwK9I7mKsi+N5A3WOW42VePahZWg1+a 6FVKiuDXihKa28jw/k3QxoLUiwRaQ/3KwPY0t4id0qJEudzImEtrFZ5lC1hfPeTFsj JOhcK2hBuHjGA== To: Grigory Vasilyev From: Simon Ser Cc: Rodrigo Siqueira , Melissa Wen , Alex Deucher , =?utf-8?Q?Christian_K=C3=B6nig?= , "Pan, Xinhui" , David Airlie , Daniel Vetter , =?utf-8?Q?Michel_D=C3=A4nzer?= , Evan Quan , Bas Nieuwenhuizen , Sean Paul , Qingqing Zhuo , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Reply-To: Simon Ser Subject: Re: [PATCH] drm/amdgpu: Fix NULL pointer dereference Message-ID: <4o2YD5id7zhK5g__CUK3Yf-6Dj459XQ0qsydW6wKHdco3YYtl78BqGUfXvQ9UO0AZoAsMPfhFB0jw1BFldiFDcbZXmGgsobuAoTMWmoDqmE=@emersion.fr> In-Reply-To: <20220408092803.3188-1-h0tc0d3@gmail.com> References: <20220408092803.3188-1-h0tc0d3@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Is amdgpu_display_get_fb_info ever called with NULL tiling_flags/tmz_surfac= e? If not, there's no point in adding NULL checks.