Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Sandor Yu <Sandor.yu@nxp.com>
To:     dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        andrzej.hajda@intel.com, narmstrong@baylibre.com,
        robert.foss@linaro.org, Laurent.pinchart@ideasonboard.com,
        jonas@kwiboo.se, jernej.skrabec@gmail.com, hverkuil-cisco@xs4all.nl
Cc:     Sandor.yu@nxp.com, shengjiu.wang@nxp.com, cai.huoqing@linux.dev,
        maxime@cerno.tech, harry.wentland@amd.com
Subject: [PATCH v2 1/5] drm: bridge: dw_hdmi: cec: Add cec suspend/resume function
Date:   Fri,  8 Apr 2022 18:32:24 +0800
Message-Id: <45739041a743cd435415ca53264678e57a653147.1649412256.git.Sandor.yu@nxp.com>
In-Reply-To: <cover.1649412256.git.Sandor.yu@nxp.com>
References: <cover.1649412256.git.Sandor.yu@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YeIUHj3/NB80GLYqCKsknM7ML3qfXHQ6a9kji9IqoXbXs6nxk1tAgigAbT6s?=
 =?us-ascii?Q?1DSryu483n4Q5anYCvHRpTKb4fgnNs9jlS8WYudzMr5TOR0PUc3GKRJDRUO/?=
 =?us-ascii?Q?jLgPckm7ISOfYuwSriQtTzc0oT4CO8Jm+LkHInB6/v1Xl4nwBCNqJ3x8At00?=
 =?us-ascii?Q?Bt8EyOEKH5wRWc7vfrCLfCcV6iy/p/R5ESIpKfrbyAZzgPMGMzGdn3/mwkaK?=
 =?us-ascii?Q?5eLGes+gBWFjukGT8na+pD9Dwsmo7nsMJK+3DS2kmASDS2eIUDSTi2jr+oJi?=
 =?us-ascii?Q?eXrztfEbCf2MOmOxQdvw0yMx32V2guVFQe3v80oTdLjRHRmpLVDzKszDbkMR?=
 =?us-ascii?Q?5T20+JCiAnnAQMfMhXgTXxyydArWigaTt0jS0KWJshFExOrGH/96NLEigr6K?=
 =?us-ascii?Q?0iEJTH5n/RcM4WDYe4dTApnJGVb91Oq30zqOwVOLSI4sPY4POw5q/eS7wjS2?=
 =?us-ascii?Q?/EDERwXhr0Ipz0Rk3OOaetCDMOq5xeP1vyCbei9oNS/SlCEKZRLx3WYeVeav?=
 =?us-ascii?Q?eMgtDPuDNkwxf9c1bMC77u03FSg6krPrMlQp7bWEK8VJQEVf8SBYQrP4lbY7?=
 =?us-ascii?Q?KldArmpdPy+N7kXoBYgkP1u0e9AwU925zn/69ceFKyaJp1zGB4MwomliH0ri?=
 =?us-ascii?Q?SvmVq6DF9x6fbNUJjROXN0eUOy4vHOWOfCQO+v7KTf3xjyNPjjXZD1H9W0Za?=
 =?us-ascii?Q?SRfCBxKrC8qQpbnJFmNVHgh7YR+z13LBQ6cswBuBi3184AKb83anqW3W5wyg?=
 =?us-ascii?Q?ny+MN9sS4YgIXm3fS6cvoViM78NSduPIuF4H5Jxt+IdY/31DZj7TG4bDIX2f?=
 =?us-ascii?Q?LkMRczgskkMytHTI5z9UKFMR7nlIgU8/ZsQUs8JkfkeqB9GmQxjLWySMhV59?=
 =?us-ascii?Q?zBsxBDkUgbTrvT8oyoEKlv1m2l4NhYiUHB6gu/JyuGPOpYEsM7k7XO/E1lH6?=
 =?us-ascii?Q?2vgEKp9ZWdq4RRqSk2RBP1BtJD5qXS9yLw1QRpmSnLHhPnf7mUxU3FkWshs2?=
 =?us-ascii?Q?XuzcS7SbDansARgLH3pQUL+T2QxHqXDzsvh8NjSuzDpPDR6sABDxaYdEjvoS?=
 =?us-ascii?Q?iop/kiYn8/mg/7GVtpieQCREx09iCf4bjsBXqG9scLjPxE9YjL67gVK4xi94?=
 =?us-ascii?Q?SXfQ1EsX4nXyK4EDGlfVZXNdkjFRXlZQfqLH8VkdojKjvz3FUrB0eHfTBKuV?=
 =?us-ascii?Q?eYjJyItffEs7oiHkxs3QJbRYwG+n21d0vZO26Mg9nrSvk7PoxubbiyHw0GFn?=
 =?us-ascii?Q?xtYJ6pMtd6+z7H7NDv1/JjDeDGMHUdOA1OSyRkbqxV760WQu4dJgFit78+58?=
 =?us-ascii?Q?77nqjti3dTzu4uNzgSfjNBdrnO/et5rGX6HksUTHdF/uHR6sRAmFyrocU/Jy?=
 =?us-ascii?Q?0R8T3Y11DvA52d7BbSHAs0/Y1x4lZ+bU8tvNzWXnGNgl3OAQhbUfnANKa3Xo?=
 =?us-ascii?Q?IF8SFWDyBp6Xj60fcKZa4ML4I3isgy5myw0a2wwa/gnbXmutOrDvZqbDxLDB?=
 =?us-ascii?Q?Ts6S1G7XCrXdlFgU9tWno1oXfoUHUzPv2QkGHJgDAFkTdbCCKBcx+hKVddk+?=
 =?us-ascii?Q?+NeRA1h6bZUQOtKPIl87AYU4iQ95kRhP2DDW6t5VJYm+AyM+D7DSI1NaGx8O?=
 =?us-ascii?Q?xLHiX34hVgK7GhW5NUhpjcSG7HW3301sRzULqvHzM6K3YK2QNzBrZvJ2XrLS?=
 =?us-ascii?Q?KizkVntoFGXZAhoUF53Kb6OCXf5Pr1xcRdC8ot9QFu3YePuNN47ROTukTBt8?=
 =?us-ascii?Q?jZjKnEztDw=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 18941857-4ec3-4330-abc2-08da194b2ab3
X-MS-Exchange-CrossTenant-AuthSource: DB7PR04MB5450.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2022 10:33:05.8037
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YlIm8ZGPdR+O4c0z3JOcNq+0FZLrLvkIk+sxdVMbuE09U1JrXuPaaOPAhAujtDaNu3MPZPuQ4OiWSQdUvjHHOw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3405
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

CEC interrupt status/mask and logical address registers
will be reset when device enter suspend.
It will cause cec fail to work after device resume.
Add CEC suspend/resume functions, reinitialize logical address registers
and restore interrupt status/mask registers after resume.

Signed-off-by: Sandor Yu <Sandor.yu@nxp.com>
---
 drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c | 37 +++++++++++++++++++
 1 file changed, 37 insertions(+)

diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c
index c8f44bcb298a..ab176401b727 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c
@@ -62,6 +62,10 @@ struct dw_hdmi_cec {
 	bool rx_done;
 	struct cec_notifier *notify;
 	int irq;
+
+	u8 regs_polarity;
+	u8 regs_mask;
+	u8 regs_mute_stat0;
 };
 
 static void dw_hdmi_write(struct dw_hdmi_cec *cec, u8 val, int offset)
@@ -306,11 +310,44 @@ static int dw_hdmi_cec_remove(struct platform_device *pdev)
 	return 0;
 }
 
+static int __maybe_unused dw_hdmi_cec_resume(struct device *dev)
+{
+	struct dw_hdmi_cec *cec = dev_get_drvdata(dev);
+
+	/* Restore logical address */
+	dw_hdmi_write(cec, cec->addresses & 255, HDMI_CEC_ADDR_L);
+	dw_hdmi_write(cec, cec->addresses >> 8, HDMI_CEC_ADDR_H);
+
+	/* Restore interrupt status/mask register */
+	dw_hdmi_write(cec, cec->regs_polarity, HDMI_CEC_POLARITY);
+	dw_hdmi_write(cec, cec->regs_mask, HDMI_CEC_MASK);
+	dw_hdmi_write(cec, cec->regs_mute_stat0, HDMI_IH_MUTE_CEC_STAT0);
+
+	return 0;
+}
+
+static int __maybe_unused dw_hdmi_cec_suspend(struct device *dev)
+{
+	struct dw_hdmi_cec *cec = dev_get_drvdata(dev);
+
+	/* store interrupt status/mask register */
+	 cec->regs_polarity = dw_hdmi_read(cec, HDMI_CEC_POLARITY);
+	 cec->regs_mask = dw_hdmi_read(cec, HDMI_CEC_MASK);
+	 cec->regs_mute_stat0 = dw_hdmi_read(cec, HDMI_IH_MUTE_CEC_STAT0);
+
+	return 0;
+}
+
+static const struct dev_pm_ops dw_hdmi_cec_pm = {
+	SET_SYSTEM_SLEEP_PM_OPS(dw_hdmi_cec_suspend, dw_hdmi_cec_resume)
+};
+
 static struct platform_driver dw_hdmi_cec_driver = {
 	.probe	= dw_hdmi_cec_probe,
 	.remove	= dw_hdmi_cec_remove,
 	.driver = {
 		.name = "dw-hdmi-cec",
+		.pm = &dw_hdmi_cec_pm,
 	},
 };
 module_platform_driver(dw_hdmi_cec_driver);
-- 
2.25.1