Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 8 Apr 2022 13:52:42 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Kate Hsuan <hpa@redhat.com>
Cc:     Sakari Ailus <sakari.ailus@linux.intel.com>,
        Bingbu Cao <bingbu.cao@intel.com>,
        Tianshu Qiu <tian.shu.qiu@intel.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>,
        linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org, hdegoede@redhat.com
Subject: Re: [PATCH v3] staging: media: ipu3: Fix AWB x_start position when
 rightmost stripe is used
Message-ID: <20220408105242.GT3293@kadam>
References: <20220408104222.13893-1-hpa@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220408104222.13893-1-hpa@redhat.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?a7KXMyP5vnsBiSK69ImUuz/VUIyVyuI4WyIsGgRoxp8q4fU5Rvv+lwRUbpEA?=
 =?us-ascii?Q?VxWx5EypNHIPWKDWcGeDIzFTgmTtLGgyPXk46Q0ZMklEQRiQIDdvPOnu9J1s?=
 =?us-ascii?Q?cfIWYAtxAeOdSZ3mb2j1ls3s3i26ICm2KGtCynNtDWu738Hub7rtyoApW3YV?=
 =?us-ascii?Q?+kvI/JFA2Oe0ofXFWCzWPvoiWSO8wex+p1mfX6obSONGY81xOMXMxTk6JBAc?=
 =?us-ascii?Q?iqCDSorStU8Br8tesXzMfJiDxYfy0aZdzl3P84A6m9nJsrbc403A1dIHDrn7?=
 =?us-ascii?Q?dgBfC2NfdfmfjoNddj+qmCkGTNCuDyGCNQeP9pZ94G6BiXpEKl9arfhyAyg6?=
 =?us-ascii?Q?B19B/pTWiz22K5cYQioH82j2IZ8CTM9HXVknq+29Pk0yR4/Y6FkLC23tMYEY?=
 =?us-ascii?Q?AxeVfVqn9uiBkSLzBkS01ie9Ext9qhrd8D8rGWEmFtttoD61BaxNDzQNXMt7?=
 =?us-ascii?Q?/87NcTiEkVb/SPMhHglyJe1SlVZ5b3jwZ265zoYl9DqOwGY4wh5vBtZlyVWk?=
 =?us-ascii?Q?vk/egbpuEiB4/vLfvTvwa8nYcFi872A/G340QpWHwWQyFJSzaNIvK7Z2Dr22?=
 =?us-ascii?Q?9ANXy0Y09uRxiR9Hjib0cMjbszOB6gqWrRi1IRK4DJ5HJv2fBBn0phSPm8nw?=
 =?us-ascii?Q?oLR1YqaPsTH7Ulqa6F381L4XSAYQSXd+hg0ZCg9tQI8n0HWGE1N6j1hT4w4s?=
 =?us-ascii?Q?39OMJ+C3YcOBujTVZrudoDUfoeH+7kQCJbkvjWW/ipH7LLH6boAf8z3zYlQE?=
 =?us-ascii?Q?T4mHleBIgfXcZjSgTwCd9RZiiTxshf2NeW+m/x3jzmS4bMUO5gt+sj4VIi7W?=
 =?us-ascii?Q?PaXKb/ZhlZ8SvYE+bRcRESZPEXciR+bk7VaJ79qsnXS7P3sacvOcMKHe+Y82?=
 =?us-ascii?Q?9AfosTxrMiILcQjuz9pkIcTY8NRK8cpd9PcCle3qgOPpJhqwJEOU2ykJYTw2?=
 =?us-ascii?Q?VhYL+bkD5cpf9gDXAR3Z7nvkjEsirCQBQjl1jP+Lw3ab7uxKxN12tFTiIm+o?=
 =?us-ascii?Q?V98x97OugF/74ofXn6lwaCxn06MxfzwIPC/tcEBxKarPvYHYyBItym0IWPTG?=
 =?us-ascii?Q?ydcPPn3UjXNv/MOGPliUb0hzenIEfl3yF16IkAkFE+FZo5xyD/04Z2vFyoul?=
 =?us-ascii?Q?HHwzmwABwcdqxXKMEZyqz0vldkB0Y9MxNFa23HnORDeonvS+KkoF+Cw0RINq?=
 =?us-ascii?Q?+Qe/27Bh4hd43rwaTD+PyCeYg+cB+QiJnWsQCLYBdgtyGf/UrTnLjmWx5d1B?=
 =?us-ascii?Q?pOtwj5XWCaSLkMn+FQD5AxlYIpiE9BoVb+hAmJAHza0BwgT/nFAK6xYhMe6N?=
 =?us-ascii?Q?G73/8jz1kNaRLugEpdc0EixdFjbJ9FupSO1CAyGJ3GbQ3y4cOHrW99CFrtNP?=
 =?us-ascii?Q?lXTqh66SyObJBzN5g5xCrhE5IQxvY6wuxHod3dHpBpf1Osk0t7NPzkwb8x+g?=
 =?us-ascii?Q?xcQiMxAShEb3b0ic7CZRod1nqtIv7xjTu0eeAnwotCRqJcqvT5NvwVVxuigx?=
 =?us-ascii?Q?trHvDo/7LHf3ym1TRFfTrbKDojd3BtGcEtU9dYQOfwYz6BoK8pG7ioHhn0N6?=
 =?us-ascii?Q?uWY0SCStHHhIoYNPW5hwrmfMIT9y/yTub4LVBdiVIoeB4bG9GUdMBTqVzJxM?=
 =?us-ascii?Q?7Pr92OREkbVQ4xzMpDsMEg5JhHiUM3c4q2ob1Xm8aRWlYzvqKD4vtP7k84QK?=
 =?us-ascii?Q?W6fIk8L+pPwvQ6nNCBNe9Kicfq/xnpAJYNmZeqAekp/3iKKNqsCqmfLkdlL/?=
 =?us-ascii?Q?/i4ep6t9PPkYZ0BU20J45SsjzA1T5j4=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1cd1dd23-bc64-4f13-a547-08da194df67e
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2022 10:53:06.9548
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: X9ywNHKi5jwuMIaYAlcoYhxbmHzOq7we00asg7XV0poR85diuDrfYYTJThJnL2aGU6XP8/UNhuSfquSDcfbLtsP1+B+RyvDNm6SHEfDMMmY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB5710
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.858
 definitions=2022-04-08_03:2022-04-08,2022-04-08 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 malwarescore=0
 mlxlogscore=999 suspectscore=0 adultscore=0 bulkscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204080055
X-Proofpoint-GUID: 4Pe5eyE5vMw9C2Bez06wjiXpZDZ21c85
X-Proofpoint-ORIG-GUID: 4Pe5eyE5vMw9C2Bez06wjiXpZDZ21c85
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Apr 08, 2022 at 06:42:22PM +0800, Kate Hsuan wrote:
> An not calibrated x_start setting would result in an incorrect AWB grid
> configuration on a sensor when only the rightmost stripe is used.
> 
> If the AWB grid coordinate is set to the rightmost stripe, for example,
> x_start is greater than 640, the AWB grid will be at the rightmost edge of
> the sensor. The AWB statistic will be fetched from the wrong place of the
> sensor and results in an incorrect AWB estimation result. Therefore,
> stripe offset should subtract from x_start to have a correct grid
> configuration for the rightmost stripe.
> 

Thank you!

regards,
dan carpenter