Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 8 Apr 2022 14:49:33 +0300
From:   Abel Vesa <abel.vesa@nxp.com>
To:     Jiasheng Jiang <jiasheng@iscas.ac.cn>
Cc:     mturquette@baylibre.com, sboyd@kernel.org, shawnguo@kernel.org,
        s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com,
        linux-imx@nxp.com, linux-clk@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: imx: Add check for kcalloc
Message-ID: <YlAhTXH2+WJtrKP9@abelvesa>
References: <20220310080257.1988412-1-jiasheng@iscas.ac.cn>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220310080257.1988412-1-jiasheng@iscas.ac.cn>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?XjynPXJGpjOpOQoRqEL4JXnzvRj+yj77dPxKssZr/RW7fElKW+P/kVy829pz?=
 =?us-ascii?Q?ekdhhIlhVsKHYdToFDdfgpztnE8uFlNJEm0fHbMzlFlSi/OP4JvOANrU/Kgd?=
 =?us-ascii?Q?bZTASvs/Kzj1xVPbV/CtZSC0vKJCZdHyT3H+DcXWtSySzocWeLqSCOxADvOL?=
 =?us-ascii?Q?dsDs4KTaaDoUsC1mgaCry6OeYU4ESktdMA87aFoFc4sRm+y3xpXEsbrIRW0w?=
 =?us-ascii?Q?TVnASr00VFObi5YCuv5wrTytStQwcsAT/0dWabVkkaXOXnzrXo/5Zk95hTWc?=
 =?us-ascii?Q?Y+lcGxw0fGT/F8yGduZI+h2emHRBFC3dRmPwSvrK19vDIAI5yBWwE7PfWC46?=
 =?us-ascii?Q?GHoDfxcodJKnA1WWTXvs/cJ2HF3mS/qaV08D/hwabNsdsS+B4TpcdaPflVPS?=
 =?us-ascii?Q?+otdzqcO5SW2CmiCaQphXVrj9K89l1qJfavtU2PEqlywqsNSmL2nheEFEGfA?=
 =?us-ascii?Q?pXj+gqtAbdjS1CDB67zVQCFb+QR6wqlD4NXNCNv8Ouy0a85Xht/7wh0R+s5d?=
 =?us-ascii?Q?LUkJxq4XFGsMhiZz5cVqwOl2coop/Q/QzE0yddnmphzteen7kWIlVWy6lJzI?=
 =?us-ascii?Q?VoRbXqSKEcDYDU2OCqGjvmHGJvmNEDfUqOsFc4+k4nc0NC6NRj78fjTD1/eZ?=
 =?us-ascii?Q?sohtY51PGhfn7GefH1gWEkAOE3l0zGIEJT3yIpAvO4fJ2CIbCCd+hiR3u+MQ?=
 =?us-ascii?Q?IzlDSn8iA6We2/djbzhJaZuhWRy90kten8VHzdC3h6nV+hhvnLRVRk4y4tWr?=
 =?us-ascii?Q?jZBwcv4l8Bgz7+C8IWtbpiFHhpgxhc84eecCODgUMaZdxtsDNTbzNA/FJ+If?=
 =?us-ascii?Q?Y6RXnK/tO8CFrnVGVxncfe6U56ftpNeA2h59MTOxOWYvNTGPtZsI1UQM1gkd?=
 =?us-ascii?Q?nrh5pB5jU5r3kiQ3w8lvN9wPA+GXi0UUjFWHiYLkTpZ08yg+i4B/XRrt9m2l?=
 =?us-ascii?Q?ANy5JlcmgZToWHTf5ttcjm2xTrUoeDAAulX7dnYcD3XpBDrZP3SdLQNcK/S1?=
 =?us-ascii?Q?R1DOXIr4WZhJpdVa4vku4fsMQ/Bw9FMRQRnMFbccp8r+5lu2mXPlm/5QAzqB?=
 =?us-ascii?Q?6iHiPuQtHZh0qQWYnSmrUJqUhN1dzmmJDviZBtjVt2mkpirg9WpviAkmH2ki?=
 =?us-ascii?Q?MFiSDzs19bdhdugIn8SWBNaqlGeWdomszIz+Ki9dEAuql3imgXepLbl98Cot?=
 =?us-ascii?Q?3v7DF4vXLK/HHgb4s77S+Tb1g+oimQC9L/L5c7GAhV3oeLQitaSGenc65eHV?=
 =?us-ascii?Q?9vf8u0XZ/Jc+XD4FwMa/AT+VQWIUCA0ku0sk+ppQnHYB9OXf4440txsyRRiv?=
 =?us-ascii?Q?8l9vlVrsOFPKaCcsMRDwcnHaDFI/dEklAnjhmlclnq7HUsZsvC/5X30mmxLP?=
 =?us-ascii?Q?D1/Bh4mr/Vi93jm72XKKdhB1XXAhMM1soKeoQpAY9FPqmv8YVdssLB9ACjVB?=
 =?us-ascii?Q?4x9bZkgTTeTTYVnNuyKqMFe+6CBOO3VLtm3VUh8HJFWY/OMalpXCTiVNzCpl?=
 =?us-ascii?Q?ctdEViqXz7DVT2c6pyTqqfF1VZYNU4ekOFbnBshvtsvy7jS9/oYT73SASsmI?=
 =?us-ascii?Q?YanT1wOTLuI2ay3kVZdisfifviS1aEPUxDs1P/eYVwPfzfQ5hW0ohfUM/1XV?=
 =?us-ascii?Q?yvK24knvpiv407SQk2RSbHxK5l2+fGE/oGE/N/TOWEhO97/NNWljVveqbvzA?=
 =?us-ascii?Q?vW2TNL32BFOUApvL054qZHr4BIZVXoKxYf693AO6RwKAkygnrIh/ylgyEDw1?=
 =?us-ascii?Q?GQQUSgICtQ=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1e3aae6f-85be-45a2-3e97-08da1955da1e
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB4688.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2022 11:49:35.0238
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ghwbxv83A/JiN8HBXCULZMJn3PBfx5lAyvBwStdE+gkwCdHY3hMCR8FLYQbdaptdwi34echSUdLNmLWWa3RSsQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6111
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 22-03-10 16:02:57, Jiasheng Jiang wrote:
> As the potential failure of the kcalloc(),
> it should be better to check it in order to
> avoid the dereference of the NULL pointer.
>
> Fixes: 379c9a24cc23 ("clk: imx: Fix reparenting of UARTs not associated with stdout")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>

Reviewed-by: Abel Vesa <abel.vesa@nxp.com>

> ---
>  drivers/clk/imx/clk.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/clk/imx/clk.c b/drivers/clk/imx/clk.c
> index 7cc669934253..99249ab361d2 100644
> --- a/drivers/clk/imx/clk.c
> +++ b/drivers/clk/imx/clk.c
> @@ -173,6 +173,8 @@ void imx_register_uart_clocks(unsigned int clk_count)
>  		int i;
>
>  		imx_uart_clocks = kcalloc(clk_count, sizeof(struct clk *), GFP_KERNEL);
> +		if (!imx_uart_clocks)
> +			return;
>
>  		if (!of_stdout)
>  			return;
> --
> 2.25.1
>