Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0a6007fe-aa5e-fc2e-bf3a-fd877deebee3@ti.com>
Date:   Fri, 8 Apr 2022 12:59:49 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH 1/2] ARM: dts: keystone: align SPI NOR node name with
 dtschema
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Nishanth Menon <nm@ti.com>,
        Santosh Shilimkar <ssantosh@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20220407143140.295092-1-krzysztof.kozlowski@linaro.org>
CC:     Roger Quadros <rogerq@kernel.org>
From:   Grygorii Strashko <grygorii.strashko@ti.com>
In-Reply-To: <20220407143140.295092-1-krzysztof.kozlowski@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 07/04/2022 17:31, Krzysztof Kozlowski wrote:
> The node names should be generic and SPI NOR dtschema expects "flash".
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>   arch/arm/boot/dts/keystone-k2e-evm.dts  | 2 +-
>   arch/arm/boot/dts/keystone-k2g-evm.dts  | 2 +-
>   arch/arm/boot/dts/keystone-k2g-ice.dts  | 2 +-
>   arch/arm/boot/dts/keystone-k2hk-evm.dts | 2 +-
>   arch/arm/boot/dts/keystone-k2l-evm.dts  | 2 +-
>   5 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/keystone-k2e-evm.dts b/arch/arm/boot/dts/keystone-k2e-evm.dts
> index 66fec5f5d081..8f49883a675e 100644
> --- a/arch/arm/boot/dts/keystone-k2e-evm.dts
> +++ b/arch/arm/boot/dts/keystone-k2e-evm.dts
> @@ -137,7 +137,7 @@ partition@180000 {
>   };
>   
>   &spi0 {
> -	nor_flash: n25q128a11@0 {
> +	nor_flash: flash@0 {
>   		#address-cells = <1>;
>   		#size-cells = <1>;
>   		compatible = "Micron,n25q128a11";
> diff --git a/arch/arm/boot/dts/keystone-k2g-evm.dts b/arch/arm/boot/dts/keystone-k2g-evm.dts
> index d800f26b6275..88be868cf71e 100644
> --- a/arch/arm/boot/dts/keystone-k2g-evm.dts
> +++ b/arch/arm/boot/dts/keystone-k2g-evm.dts
> @@ -392,7 +392,7 @@ &qspi {
>   	pinctrl-0 = <&qspi_pins>;
>   	cdns,rclk-en;
>   
> -	flash0: m25p80@0 {
> +	flash0: flash@0 {
>   		compatible = "s25fl512s", "jedec,spi-nor";
>   		reg = <0>;
>   		spi-tx-bus-width = <1>;
> diff --git a/arch/arm/boot/dts/keystone-k2g-ice.dts b/arch/arm/boot/dts/keystone-k2g-ice.dts
> index 2a2d38cf0fff..bd84d7f0f2fe 100644
> --- a/arch/arm/boot/dts/keystone-k2g-ice.dts
> +++ b/arch/arm/boot/dts/keystone-k2g-ice.dts
> @@ -325,7 +325,7 @@ &qspi {
>   	cdns,rclk-en;
>   	status = "okay";
>   
> -	flash0: m25p80@0 {
> +	flash0: flash@0 {
>   		compatible = "s25fl256s1", "jedec,spi-nor";
>   		reg = <0>;
>   		spi-tx-bus-width = <1>;
> diff --git a/arch/arm/boot/dts/keystone-k2hk-evm.dts b/arch/arm/boot/dts/keystone-k2hk-evm.dts
> index ad4e22afe133..f968af0bfad3 100644
> --- a/arch/arm/boot/dts/keystone-k2hk-evm.dts
> +++ b/arch/arm/boot/dts/keystone-k2hk-evm.dts
> @@ -161,7 +161,7 @@ dtt@50 {
>   };
>   
>   &spi0 {
> -	nor_flash: n25q128a11@0 {
> +	nor_flash: flash@0 {
>   		#address-cells = <1>;
>   		#size-cells = <1>;
>   		compatible = "Micron,n25q128a11";
> diff --git a/arch/arm/boot/dts/keystone-k2l-evm.dts b/arch/arm/boot/dts/keystone-k2l-evm.dts
> index e200533d26a4..32619b3c5804 100644
> --- a/arch/arm/boot/dts/keystone-k2l-evm.dts
> +++ b/arch/arm/boot/dts/keystone-k2l-evm.dts
> @@ -110,7 +110,7 @@ partition@180000 {
>   };
>   
>   &spi0 {
> -	nor_flash: n25q128a11@0 {
> +	nor_flash: flash@0 {
>   		#address-cells = <1>;
>   		#size-cells = <1>;
>   		compatible = "Micron,n25q128a11";

Thank you
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>


-- 
Best regards,
Grygorii, Ukraine