Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Yihao Han <hanyihao@vivo.com>
To:     Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>, linux-clk@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     kernel@vivo.com, Yihao Han <hanyihao@vivo.com>
Subject: [PATCH] clk: clk-xgene: simplify if-if to if-else
Date:   Fri,  8 Apr 2022 06:06:09 -0700
Message-Id: <20220408130617.14963-1-hanyihao@vivo.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YhReKgBT8iHcjMSX+HD/Z6C2nBj5ZaMCs3MjhksBCoMUBNdTFtTLbe2lWWwi?=
 =?us-ascii?Q?XuXFZ0n3FLDl3L8zB4eZKpxc7/OdC/h2YKpfhQVeBAKIYyBXwonMXqP2EHQ3?=
 =?us-ascii?Q?P5fKEoEf3l3n2H9/tcrTK+8PMF0nkw1wNSDT+021C36DhL2ECkqNLrya9WBD?=
 =?us-ascii?Q?vQGllpnY+xU5JVEY/q7+aKAZVg57UI9EyGZzOWCwmLq7RfYX0ow3JGpkUKWA?=
 =?us-ascii?Q?BPHhMLbgotJ7P2/L79gqavao+93Gi3LfRFt5bEJHA7i4xKg8LRNyKIr+mOHS?=
 =?us-ascii?Q?TPO6P5uh9ahxB2JJCPv8mDB3FhtsrS/5uNHiyE8z2/qw9bElwZ+2Hm7h0R/0?=
 =?us-ascii?Q?B3+GlUIBTUowUbh6L8EzkAEF81+Jrv/8pF55gabjWjrxxeNqmwZeY/D6vJKn?=
 =?us-ascii?Q?7Gtj+KaisD3TT2ojzzDeCwfTFF+yQgsjxLiY5wDu7KlaraqyhoqU39RfHdPx?=
 =?us-ascii?Q?UZ7bupEK+Hq+NldTCz2XMxzdZECV5RtGnyMHrDX7pZoVVOe3STicm6LDTE7/?=
 =?us-ascii?Q?r2GdaAtHi0c0zjISm3I8Kdlq2szOUQjPFHnpvCb2FEC3IDJkqDsrQgRFjOW4?=
 =?us-ascii?Q?UNKC0yT4xfhwh4fpXypdl7axHEyC7BiOuGuyhqfbxNwreosjhSXlnCkw1TmH?=
 =?us-ascii?Q?FQUkRNH458XB4LVX+tj/vbOoy0Qwp+bu7NyhBKKjEqLmDxJjsmjjgx86Hm7X?=
 =?us-ascii?Q?Oip+ekEz3cU9xqSwAbNKNcp4P+hMDbsavdHMBP5wFEJ7Ej/exjBQXchNaD/I?=
 =?us-ascii?Q?zSQX1yXYhtrmtbYsFS4C6maRLtheruNupBcyJ7Ybmo5Q2FnL5Q9QMo26Jpwp?=
 =?us-ascii?Q?xiGl9MItOaw2FwkKhtYr4aX++gVo//TWqGz3aaBTIFbo21ZUAa1/z74F7HY9?=
 =?us-ascii?Q?ZbOoiLIhzy/NlQih5EWgE73nPzb4WjkElg3SYVVORPtFww1zSa53zY3J1aFk?=
 =?us-ascii?Q?nCRSYPiVpm19YCOqC+xnNOm7KbVV0xG73rBpyT7NvWzPCPd7VFhGQyxuMB1x?=
 =?us-ascii?Q?Y0O5X4midEAanNZ9IzQK2LkcrGsRWqFxav+WaTOHprrNKoXGzOloYOPvEvfL?=
 =?us-ascii?Q?Oh5uv6wWvy8qyOxZLVrO6pD3dYtPs3D/pXXAdpN4jgcm7MvbVeTSGnzK5vxY?=
 =?us-ascii?Q?g7YDI5mHyJphDsdGN2e8/8oCHbEEcug+4ep+Al2+2kB3D76BH7Ag6pohzJ0E?=
 =?us-ascii?Q?6mAF4YagJm6SvvvVHQB7vAf0cKIY593J51H5QiSegl1+WMrLYtca5SnbLHov?=
 =?us-ascii?Q?bh5c8g3F9K4rv4sBVcM5b7MeEQBPJ3xHS8Ym3uiOVXd+Ft11WCXAwQ8CNKSM?=
 =?us-ascii?Q?DjtOBRV6Ri854ToU20FqiALTowOQbhUIjPo6BM+T0W7TQJjxfgQcShwTB5c3?=
 =?us-ascii?Q?Dlh0BK+kUZ4PCJCtWHb1kK73piLz9084mIcCOrvTNopuiKckW/d/X6jVz8n4?=
 =?us-ascii?Q?O1L9oiq/aDFH3JlPeuIBBjmRol+G0knM+6f3OEjIdPyIM1ITld6pdAVcIlWK?=
 =?us-ascii?Q?QfZjVzdptrj3gYTnfvG0Ld83GlR1NA3CPBeHYDhTjh8v7OXiess/wETigL4x?=
 =?us-ascii?Q?icXn5P6F4R7Ddt7iavW2DRVdY1yyGGQr0Ox5M0O2XFHQQFxISlfx2QSfI2eg?=
 =?us-ascii?Q?r8LKCbg37/sPaGUywN3xZZfgkpggFarWTZ/U4BHjPHy0g3HuF2vDTgIkzgSa?=
 =?us-ascii?Q?GUp9ns8+bBGxzT+BRuycgcw1ze4Tcx8/et8DTrLSsPi1/UaydhghBpAHtWnt?=
 =?us-ascii?Q?6tt9zd950w=3D=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 19dbbd20-70b5-4366-d1b5-08da19609c14
X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB4173.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2022 13:06:35.7197
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SJhCg68lg8eg/aDFZlnonKs4pL3x6Gr3CQpbTmmvFwt+dORAP/WpsJCsKSA8rgYv7ijvtr75n6cHmmTe/7CnEw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SL2PR06MB3083
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Replace `if (!pclk->param.csr_reg)` with `else` for simplification
and add curly brackets according to the kernel coding style:

"Do not unnecessarily use braces where a single statement will do."

...

"This does not apply if only one branch of a conditional statement is
a single statement; in the latter case use braces in both branches"

Please refer to:
https://www.kernel.org/doc/html/v5.17-rc8/process/coding-style.html

Signed-off-by: Yihao Han <hanyihao@vivo.com>
---
 drivers/clk/clk-xgene.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/clk-xgene.c b/drivers/clk/clk-xgene.c
index 857217cbcef8..0c3d0cee98c8 100644
--- a/drivers/clk/clk-xgene.c
+++ b/drivers/clk/clk-xgene.c
@@ -522,10 +522,10 @@ static int xgene_clk_is_enabled(struct clk_hw *hw)
 		pr_debug("%s clock is %s\n", clk_hw_get_name(hw),
 			data & pclk->param.reg_clk_mask ? "enabled" :
 							"disabled");
+	} else {
+		return 1;
 	}
 
-	if (!pclk->param.csr_reg)
-		return 1;
 	return data & pclk->param.reg_clk_mask ? 1 : 0;
 }
 
-- 
2.17.1