Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <768e8812-ecbf-93e7-ffad-feec1b36d924@amd.com>
Date:   Fri, 8 Apr 2022 11:19:54 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: [PATCH] drm/amdgpu: disable ASPM for legacy products that don't
 support ASPM
Content-Language: en-US
To:     "Limonciello, Mario" <Mario.Limonciello@amd.com>,
        "Deucher, Alexander" <Alexander.Deucher@amd.com>,
        "Koenig, Christian" <Christian.Koenig@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        "airlied@linux.ie" <airlied@linux.ie>,
        "daniel@ffwll.ch" <daniel@ffwll.ch>
Cc:     "amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20220408154447.3519453-1-richard.gong@amd.com>
 <BL1PR12MB51576654D3EEB10F5DF862A7E2E99@BL1PR12MB5157.namprd12.prod.outlook.com>
From:   "Gong, Richard" <richard.gong@amd.com>
In-Reply-To: <BL1PR12MB51576654D3EEB10F5DF862A7E2E99@BL1PR12MB5157.namprd12.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SnhpazBzcWVhQlpGQUxMRTlWTk5vcUpqTUN4NUJSRi9iZmVBa05WbW8xeTVI?=
 =?utf-8?B?NHhjZjk5bDVFNzYzckQwNHp5TW1Dc1Q4TElnZm82QmRtOTQ2ZHo1VjFoaDRP?=
 =?utf-8?B?MHpvcnRzNmhaQlhpaCtmRXFaaW9sY1hwNFBhanAzRkt3Tll2VDd2V3N6VGZW?=
 =?utf-8?B?YXVBY01mSnR5dHN2bzFrYnQ2SW95aFV3blpsYTVmTWFYbDhScDd5N3hxamdk?=
 =?utf-8?B?NlFuZVlJNkFpemlJemlUbW0xQUcrRzR2Ri9CVkMzV1pacjY3ZzFidUlUaXg4?=
 =?utf-8?B?ajF6V21JMUVtT0pTUWFpSUp6ZmN4eThKZ2Z0clBOSmx0bXU2bFVmeERhZjRm?=
 =?utf-8?B?OWRicDR1ZE14ejIxV0s0bnVHd2YzcFFHek5hdDBmcnZSVzFyUEV1RVVuaVRM?=
 =?utf-8?B?NWRjUmk3VXhlSXVubVpFMzk0RlF4aERzTGQvSG5qZU5JbkVYQ3dxVXJNQUQr?=
 =?utf-8?B?Y1cwVTJCaUtJdy9OeEg0U0tlM1pOZ2lGbHlCRzFMdlkrVkw5OU45RTM5YkF5?=
 =?utf-8?B?alhEbThsUXo3YkZDeHVPNUc1YVNzUGRZblBDSDdsSHUrU3FBODZUQXpCajcw?=
 =?utf-8?B?dlVwTG9WaHFqQlpESDZoNnJlU21rT1JqSFc5Nno2ZG9iRWNINjNURGNMcS9F?=
 =?utf-8?B?UVdaWGJvRjFwYWYzSlVDL2VWMWJ4OWhITWhzdUh6UENXa2tsL1ZMc2JUU2tW?=
 =?utf-8?B?eGpqNFp5dkJlenZtNTBObnlwUENWRUlxYzlhNTNYNUh3THkrbldtTk1pRW5I?=
 =?utf-8?B?c01xSHhnWEJmNGkyMThUMmxjZDk0SUtDU2hIc1o2MTQxZzdRbk5DRE9lSWhv?=
 =?utf-8?B?VXZzcjExWXQrOWt4QjJ5Y20wVGd0dDVYTUV6VUlaY0J2dWxFRUE1a2lkWmkx?=
 =?utf-8?B?b2E0SXlSeUJKci9oOTkrQ1Y2bzc1amkyUjRWWThRa1BPM2JNL3doWkkxa3pU?=
 =?utf-8?B?eW56aWh6MlNMUm1XZFNxcWQyeDVMbHRUckRLOTNVT3d0YlIrMFMrOVhqTEM3?=
 =?utf-8?B?VnloM2JNNXpFdkRqWWZEWktxN014QmRQcWx0a1ZDNTlGb0tlTWdlQlV5WmVQ?=
 =?utf-8?B?WjI1d2lFenZBcFYybVYyTlhNNEJzTFJBbm1UblJkV29yUEQrcU5kYkNWL0xy?=
 =?utf-8?B?M0hpanhlWC9Iby9Dd0crcXcvTktOZDFZV0NNRFhrVVpvblYyQmNtRC8vRlI5?=
 =?utf-8?B?YTRVYWJvVTVKcHlIYW9hT1NaVmxBd0ExSlhWbEYyb283VGFGall1R2loS0U3?=
 =?utf-8?B?NFBFWCtwUnJ1dzl0MzdYVVc5eXdaampGeSswTlB3VzY5aWxLUHFVeUpUbTVm?=
 =?utf-8?B?bGJadjJKaDVWMm8xMS9STGhTaHd0NUJKYnNQR3J4VVpVRmF6V3RobWpwT2s5?=
 =?utf-8?B?YVlVZnlYd1JhNU5aU3gxa2QzdFdxWllLM2lmKzFaQ0t1aVJKV0Q1T0dzU3Ro?=
 =?utf-8?B?SDlWNVdiOXRQeFFsV0R5MGhCQVdCcEVJNkF3dmh3Y0NHb0RuL2NVYlhORHZ6?=
 =?utf-8?B?MEtQMzhDOFVVNVh5QUVHV1RaamhBYUJwazdkUG9jcHlhOCtaMTNjYW85TmpE?=
 =?utf-8?B?a0pTYTVWYllacFVWVmtPNVU1K2xZRjlpdHVSSzk0eU9YSTNnNUV0RGpFQkZs?=
 =?utf-8?B?eVVVYUxiQ05MZk13S1NTdnlUWjM3Q3l6elFnSlFDbGRiVTVjUTcxSk5lY2JM?=
 =?utf-8?B?d3lQa2F6U3R4RkZzdWRid1gxem4wYlM1d2hoNTdEZVl4ZEsrclNJZFNqU2N6?=
 =?utf-8?B?c3JNd0RWNXQwbUcxU3VOMldiSXFrQkUzY0tGcVZScTBKeUN3VUF3OU02cFJR?=
 =?utf-8?B?YlNGRzF4elVSZGZsTlM2eFY2dU9yMU9yVXBZaWJqdGlaVXp4RGhNZkNtTDhD?=
 =?utf-8?B?TGl2S0FYakpyR3FvN2VLV3h5SjlxSWkvYnFuUEgrVk96NlZCRHl5dFJEcWdD?=
 =?utf-8?B?L2g1bEowODhVajJiRGcrZG5RV0lkR1hFdzQ1cDEyaGlENVBZZEJnNWIwN0s5?=
 =?utf-8?B?VlptUWtmWWJaL1JVM0czOWJpSHBsd1dlNkZWY3d0MEZuT0JZVmZhN01QWENm?=
 =?utf-8?B?T2tlWWgyWTZZak1qbGgxOURPakQvcDl3R2NKejU2MURJbVB3Z3djK0swc1pD?=
 =?utf-8?B?K2RZTzRJU0Y5dEtrT01ZQ2dkMjFiZkRvYW9Zb1ZuSGt3L2plUjNabS8wUUFi?=
 =?utf-8?B?QkxWamsxUDVaemU2YlEyU2Q1MmRWTitIWkFJK2xRQnA1OXl5a0l2UkFidXJU?=
 =?utf-8?B?UnNTWm5qdzlkWlNQN0pYVHpuNWlocGwvY2ZjclR2bGtGNlVTN1NlVXJMRFVI?=
 =?utf-8?B?NHJGRFJRQVVoejIxS1hNOE9jbWg1QXBnRjhPYUlmeFQxZUdHbmJ6Zz09?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d8633b7e-5e83-44dd-2f25-08da197ba079
X-MS-Exchange-CrossTenant-AuthSource: SA0PR12MB4526.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2022 16:19:59.1564
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: drVDJcx4p+vDXyGEMwLkHOdNSJCcx8BwmnsdkvNZXMbqldEU7Fg6fiZwh9eIcT9BrxIFsptEK2NA4jJ0Idiy+A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB5674
X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 4/8/2022 10:47 AM, Limonciello, Mario wrote:
> [Public]
>
>
>
>> -----Original Message-----
>> From: Gong, Richard <Richard.Gong@amd.com>
>> Sent: Friday, April 8, 2022 10:45
>> To: Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian
>> <Christian.Koenig@amd.com>; Pan, Xinhui <Xinhui.Pan@amd.com>;
>> airlied@linux.ie; daniel@ffwll.ch
>> Cc: amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; linux-
>> kernel@vger.kernel.org; Limonciello, Mario <Mario.Limonciello@amd.com>;
>> Gong, Richard <Richard.Gong@amd.com>
>> Subject: [PATCH] drm/amdgpu: disable ASPM for legacy products that don't
>> support ASPM
>>
>> Active State Power Management (ASPM) feature is enabled since kernel
>> 5.14.
>> However there are some legacy products (WX3200 and RX640 are examples)
>> that
>> do not support ASPM. Use them as video/display output and system would
>> hang
>> during suspend/resume.
>>
>> Add extra check to disable ASPM for old products that don't have
>> ASPM support.
>>
>> Signed-off-by: Richard Gong <richard.gong@amd.com>
>> Link: https://gitlab.freedesktop.org/drm/amd/-/issues/1885
>> ---
>>   drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>> index bb1c025d9001..8987107f41ee 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>> @@ -2012,6 +2012,10 @@ static int amdgpu_pci_probe(struct pci_dev
>> *pdev,
>>   	if (amdgpu_aspm == -1 && !pcie_aspm_enabled(pdev))
>>   		amdgpu_aspm = 0;
>>
>> +	/* disable ASPM for the legacy products that don't support ASPM */
>> +	if ((flags & AMD_ASIC_MASK) == CHIP_POLARIS12)
>> +		amdgpu_aspm = 0;
>> +
> I think it's problematic to disable it for the entire driver.  There might be multiple
> AMDGPUs in the system, and others may support ASPM.

The "problem" are WX3200 and RX640, both are from the same POLARIS12 family.

> Can it be done just as part of probe for Polaris?
>
>>   	if (amdgpu_virtual_display ||
>>   	    amdgpu_device_asic_has_dc_support(flags & AMD_ASIC_MASK))
>>   		supports_atomic = true;
>> --
>> 2.25.1