Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH] sfc: ef10: Fix assigning negative value to unsigned
 variable
To:     Haowen Bai <baihaowen@meizu.com>,
        Martin Habets <habetsm.xilinx@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org
References: <1649383888-2745-1-git-send-email-baihaowen@meizu.com>
From:   Edward Cree <ecree.xilinx@gmail.com>
Message-ID: <e2e85510-f4ad-d983-f76c-b678bc9e397e@gmail.com>
Date:   Fri, 8 Apr 2022 16:02:43 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.5.0
MIME-Version: 1.0
In-Reply-To: <1649383888-2745-1-git-send-email-baihaowen@meizu.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 08/04/2022 03:11, Haowen Bai wrote:
> fix warning reported by smatch:
> 251 drivers/net/ethernet/sfc/ef10.c:2259 efx_ef10_tx_tso_desc()
> warn: assigning (-208) to unsigned variable 'ip_tot_len'
> 
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
> ---
>  drivers/net/ethernet/sfc/ef10.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/sfc/ef10.c b/drivers/net/ethernet/sfc/ef10.c
> index 50d535981a35..1434510dbdc9 100644
> --- a/drivers/net/ethernet/sfc/ef10.c
> +++ b/drivers/net/ethernet/sfc/ef10.c
> @@ -2218,7 +2218,7 @@ int efx_ef10_tx_tso_desc(struct efx_tx_queue *tx_queue, struct sk_buff *skb,
>  	u16 outer_ipv4_id = 0;
>  	struct tcphdr *tcp;
>  	struct iphdr *ip;
> -	u16 ip_tot_len;
> +	s16 ip_tot_len;

The debug-warning on line 2260 relies on this being unsigned; it would
 be preferable to change the assignment on the line above to cast the
 value to u16, or to assign "0x10000 - EFX_TSO2_MAX_HDRLEN", since that
 is the actual semantics of the value.

-ed

>  	u32 seqnum;
>  	u32 mss;
>  
>