Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 8 Apr 2022 14:22:03 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Jakob Koschel <jakobkoschel@gmail.com>
Cc:     Leon Romanovsky <leon@kernel.org>,
        =?utf-8?B?SMOla29u?= Bugge <haakon.bugge@oracle.com>,
        Mark Zhang <markzhang@nvidia.com>,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
        Mike Rapoport <rppt@kernel.org>,
        Brian Johannesmeyer <bjohannesmeyer@gmail.com>,
        Cristiano Giuffrida <c.giuffrida@vu.nl>,
        "Bos, H.J." <h.j.bos@vu.nl>, Leon Romanovsky <leonro@nvidia.com>
Subject: Re: [PATCH v3] IB/SA: replace usage of found with dedicated list
 iterator variable
Message-ID: <20220408172203.GA3637956@nvidia.com>
References: <20220331091634.644840-1-jakobkoschel@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220331091634.644840-1-jakobkoschel@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5krphoEBqrgods1169VE/37ARS8pl8vp2c5GAEXEMzBPPIqox7K4T8/XPfKt?=
 =?us-ascii?Q?OiVqTdd+lYSZITXC1gvy52zaSGpPv867K+5V/LoZl3bR7I5P1+0fKjExx9m/?=
 =?us-ascii?Q?GDQ43O/Lt40YeqsgJCJJPIW6joLbz3vtlmKS04hKW5+7CwV+g6xqELZXpJPK?=
 =?us-ascii?Q?f8K55/04dPBArsiK6Q7hlUAxczijtxBIDNbm9lmtmpVrf9L/rjS/X3JJl1v0?=
 =?us-ascii?Q?9gx09D7cFybeHT088fV2qcow/hapt1CVHAnpkFtAkrJkSRx61xqm5j4+BqBM?=
 =?us-ascii?Q?R27zjbHTN87PEubENMHb+apYc+KwLN/z/++/1bvprYmMphYEma33GmlIN48a?=
 =?us-ascii?Q?mIUgqzRVHUSp+4Ktdzb6zEzYGSzhriPuvNDFh4pNDz2+POFKejMSgRrGuHRu?=
 =?us-ascii?Q?6BqeVW9dISOI4Yej8qSSmKzp05geDwpZ3V88A/xjH8YiiBv5VgzzBAJ/ueeB?=
 =?us-ascii?Q?5lk4rPfpdM90eB2+t/V/New6fKHWDnYv/aCxgQkI1vPqqCxjfzfCyG+Si3mO?=
 =?us-ascii?Q?OmblsXTmJjRabQB+MsSpPjqY6mh8V0vyYmPZJr7gqtiITn6z0zFhyTe1tsP9?=
 =?us-ascii?Q?RFw41aWQ+zb/MXR9tG4ytdaBOW+qRRy4Pb+HgkRPzNcKkLKXs/3gU8+wM/jD?=
 =?us-ascii?Q?IZIr0Wclm5gNYeqRbx7i/L2QkL6QxVUZKWYS5yZ8/ZTEDG90FUEz/MtlXN1e?=
 =?us-ascii?Q?Ka8dDQEC2vzpIDk8ectiYEQXC+NXm5OPqoHO1ouxC+B1pXKfWrLf/tPgJ3HW?=
 =?us-ascii?Q?NyL6UE7ngZO1f8vE5qhnYUq9S9XouZ9I+3KPbWVIbAb+uu2BBVS9vK0+yOOX?=
 =?us-ascii?Q?5DqDaAQDe0lqmxf5/BkXjho+UKg3NmblqzgFtDX8ZLvRu/sO4S8Q8CX/vQPg?=
 =?us-ascii?Q?WGAFxIzYmE4K5hKfMcQtd0PS0EV4tp+kvvGQ43TyXItx0Ozc2+auxpLyuheu?=
 =?us-ascii?Q?3fKsxbFnUTt8Jx7y+pk314XBy/uX6kWBTRaPkhLklPf4qLhPmEP7L+TNpNfv?=
 =?us-ascii?Q?SsVPaLnJli2iygPY2+Si+1YrJUqGfQgtWlolMjZdg7I41W7PNT/2Oh9ULVFw?=
 =?us-ascii?Q?BFHo7WYxvpHTnP23+YYXn++RbuXqAb2JyRjlk+F59YSN9OIs7dWv4eeQH+06?=
 =?us-ascii?Q?jztz0LYvD3tD4myvzpL7Xugth5vfq6StiYVB/uC+tMdXPtHJTZ0K1b/tlLvq?=
 =?us-ascii?Q?zOoqK+ZxVgUDgfiyCYrneVftyUmFd9IFDdgvmnPqlZHX2Sa/5WzURRiXTkxe?=
 =?us-ascii?Q?nNWDEtsaf48sLn2Up+HpTT8ppDgWrHfrM3e+bcd7hVLY7u7DefaU8vnNukwm?=
 =?us-ascii?Q?PFqh3OsiTq5N3nu49hZ5Xu1m266KUGAo03Rsr3fCnH3lAUPg8E5jQtMEcLsY?=
 =?us-ascii?Q?yw0pZlq8XBRq3N4jgKfYuEErB9KUiK7DHMqSGTrCNonepZlLe1Wh0IXwi7Kp?=
 =?us-ascii?Q?G7S2mXHi80oUglN5dGWTjJuBLJWiYhTD6bYO07W0apKpKx28gyXfYvA9wHGI?=
 =?us-ascii?Q?1xDGyebvIm6/fwq4jryEUD2AUJtTQwu8s5mez99P9sRLbeE7bxN2xqNGXS8A?=
 =?us-ascii?Q?4C9EECORNw2vNvgL01gCKPaE6FmTQyJWARb9t0Pj6VoA4lcr17LuYBM8yhmJ?=
 =?us-ascii?Q?hpU1CHH5vYRcpn5zIACI5SVnphIy/gWxrSh8yxMLQjqseLT7b7aD/Xpf1H6Y?=
 =?us-ascii?Q?gQ4C5KKxJc+2tt0lH+g53Z2QX31/T/lXnIh4Asaqupmc50jXv1nTibKNFBDt?=
 =?us-ascii?Q?zkaJX0WSfA=3D=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0c2f8829-8ea9-417f-6f80-08da19844d37
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2022 17:22:05.1338
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /jnZl2lH0Xo0TqLE8Bh/8Gr8Ksvyn1ugb/Wfs/Sy75sBhTa1OSDi3Ei6MHXOikNO
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB2952
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Mar 31, 2022 at 11:16:34AM +0200, Jakob Koschel wrote:
> To move the list iterator variable into the list_for_each_entry_*()
> macro in the future it should be avoided to use the list iterator
> variable after the loop body.
> 
> To *never* use the list iterator variable after the loop it was
> concluded to use a separate iterator variable instead of a
> found boolean.
> 
> This removes the need to use a found variable and simply checking if
> the variable was set, can determine if the break/goto was hit.
> 
> Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
> Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
> 
> v1->v2:
> - set query correctly (Mark Zhang)
> 
> v2->v3:
> - remove changelog and link from git commit message (Leon Romanovsky)
> 
> Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/
> 
>  drivers/infiniband/core/sa_query.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)

Applied to for-next, thanks

Jason