Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <bc8d25ed-e65f-83b9-e21c-25150f9b8884@marvell.com>
Date:   Fri, 8 Apr 2022 16:38:58 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:98.0) Gecko/20100101
 Thunderbird/98.0
Subject: Re: [EXT] [PATCH v2] net: atlantic: Avoid out-of-bounds indexing
Content-Language: en-US
To:     Kai-Heng Feng <kai.heng.feng@canonical.com>, <davem@davemloft.net>,
        <kuba@kernel.org>
CC:     Mario Limonciello <mario.limonciello@amd.com>,
        Paolo Abeni <pabeni@redhat.com>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20220408022204.16815-1-kai.heng.feng@canonical.com>
From:   Igor Russkikh <irusskikh@marvell.com>
In-Reply-To: <20220408022204.16815-1-kai.heng.feng@canonical.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk


> UBSAN warnings are observed on atlantic driver:
> [ 294.432996] UBSAN: array-index-out-of-bounds in
> /build/linux-Qow4fL/linux-5.15.0/drivers/net/ethernet/aquantia/atlantic/aq
> _nic.c:484:48
> [ 294.433695] index 8 is out of range for type 'aq_vec_s *[8]'
> 
> The ring is dereferenced right before breaking out the loop, to prevent
> that from happening, only use the index in the loop to fix the issue.

Thanks,

Reviewed-by: Igor Russkikh <irusskikh@marvell.com>

Igor