Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 8 Apr 2022 13:30:46 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Niels Dossche <dossche.niels@gmail.com>
Cc:     linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
        Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
        Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
Subject: Re: [PATCH] IB/rdmavt: add lock to call to rvt_error_qp to prevent a
 race condition
Message-ID: <20220408163046.GA3612436@nvidia.com>
References: <20220228165330.41546-1-dossche.niels@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220228165330.41546-1-dossche.niels@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ohYdTlM2xCNVbunQx1ft94NP2lcrkcEqd6pPtMI7xawW9fsnTQZPbnRUKnHX?=
 =?us-ascii?Q?19dCAIZNO17qIE9U1UvYzh9cGVwZ7qEcAZ8kMy/pUVjStulqHiYW6N5WjfrC?=
 =?us-ascii?Q?r3SjVIkTr1VD2Xz/A3ljjBhXhtKGeKpZMI41R4i16mGxUJgSgBhxdXtbrxus?=
 =?us-ascii?Q?xp4mLsLyvyOPnjeSo0gLzBcx7jDmAROvFdTrpFsIrUW+qqsf0i+QKFlwy9RO?=
 =?us-ascii?Q?yLNTGxz6HgsEJvnV5TCXM0vObQm271zOjQvEX8Xmuqv0BqxMgiU+I/0K8Y2g?=
 =?us-ascii?Q?eXxdif4LNhiXs7FJCCXAmc6HdRPly43OS9pNhxhhdN259m9LHclW6W70PDM2?=
 =?us-ascii?Q?k5CeDKSUr2QkbNxKWVVFIOYREjPkZyQ0/u2tj97SmSIF1WqBYMCmYvx8VucC?=
 =?us-ascii?Q?XCQaxz1/+iXfs9nWf6WgNSuOkPfryJk2cBo293Wkzegn7zI7gGfXPlGA+mGl?=
 =?us-ascii?Q?Zx+BPefPJhXVu8C9rB3yRdWC4WvbKege5lwuh2cSVUB/PnN8G1Iqw103Smp2?=
 =?us-ascii?Q?mgOW1lMr5RfhC91qySXGRkcF+lfX+/ufbQQ3G5h4VfEO5skZLDRDFoZ29gA6?=
 =?us-ascii?Q?bMAKXNdYR3VvUWfOEtpq1MLK3G+TBVIP3YevVmOnbwQERKZLQ5V4Iw7rviKS?=
 =?us-ascii?Q?Z1eYz9zXsWa50k+I2h91AeUp1u9pdfC7Y6Y9b5BGeqK0iQVcxYOBYI4UEqQ3?=
 =?us-ascii?Q?LGuLwrCBIatV3NO5xizzktYZ8ZXAT62WTPXqBP0QIV3OH+770BnU9UsApuu7?=
 =?us-ascii?Q?7N2W937Ar4S2XpL8ELYpik0oWN+yWDFzhw9zp5y+2KZwEXeFWFl4EunpqPOx?=
 =?us-ascii?Q?XXdgvVhFVD+pV2DYzgCujz4jm59PKrmbvFWCyJJjPoOmlDW66HQp255eWcQU?=
 =?us-ascii?Q?qgwHkuXK+MvaZrJy5wP3j9poFcPmX28ymSPKiePaPrnWAEyu65L8+gicBq3e?=
 =?us-ascii?Q?ZfaPNjUAACppTUSz9IHvNCA9upk7qxFuAqtBH5psNokUAYKsUAHwYzD5+b+E?=
 =?us-ascii?Q?dqw3hpFIsBKn1rbYMkw+PjXQ5lXk4iqMkXxptA/BdX8fJiCkfhL8y7ub0eAY?=
 =?us-ascii?Q?pmy1APufRSKdzogqgzNJdLmtHFAApWfQTlF0NckVwJt9eZtbSzfIBTqEPoc1?=
 =?us-ascii?Q?XE0R4dV9w9SuKyHNIqvOcfGIly9YNCzbxXfIQNDiEe9qzbi6fgD5V/HWS8Tw?=
 =?us-ascii?Q?JBVLdUyPZc1biptcUlRdJjKHvlpjKFUs1PugYI9SUWZNJvVGXnHmndxsayJT?=
 =?us-ascii?Q?Gp2N9SEQFId76eh2kc2jhLlDW9CbUtVvD0KbH4nnwxMYY0hES61kTfI8QG2h?=
 =?us-ascii?Q?7BZvi8Fpe+TGPJ/RybpE/FhF0V2spyWBarQSIUS4GcPMVT1F08ZkMOHo0Rzl?=
 =?us-ascii?Q?MQCOAlL/J+XUqE6vfONMAX/o7nDrYNirWLytVLbwT+z+htEU4aL0NLGOuHm3?=
 =?us-ascii?Q?y7MDby5iqCB6G/IrfFZWkZtcQ0vQ9r52Z4I0jyIREa46FrW/AIbfGL2fEdN6?=
 =?us-ascii?Q?gRa1FARWBJk8WQH+XOF/+bbsg7cpw5sJVhs+wP9sZtJJJ849PvI3qFeoGZ8J?=
 =?us-ascii?Q?NiMEOFUyBWk6jXiozJoFg6Ne3VjMmyLbXj4IdCe9JfaKS13v9rhO5b1JUXPY?=
 =?us-ascii?Q?cn0KHSX2UPfc4B4elJfQskLHRrkqKoS8nI6DA8/2v7BYSkkK3xbRHQkkxiul?=
 =?us-ascii?Q?g6E2ICDov292OlyfFtp4fcvZf9FnGMoO5WUGerktiaQoHUVVGlbpX4bTPdUK?=
 =?us-ascii?Q?K1rkxXngbA=3D=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 55c4267c-e86d-4d22-b9e4-08da197d233c
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2022 16:30:48.3509
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: c1TKIMcdDX4pjmAFSTiPniLNHgSOdLC7M+kzYy8ZIjv9aIIT0pAMm4/SUIU8Jglw
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB5703
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Feb 28, 2022 at 05:53:30PM +0100, Niels Dossche wrote:
> The documentation of the function rvt_error_qp says both r_lock and
> s_lock need to be held when calling that function.
> It also asserts using lockdep that both of those locks are held.
> However, the commit I referenced in Fixes accidentally makes the call
> to rvt_error_qp in rvt_ruc_loopback no longer covered by r_lock.
> This results in the lockdep assertion failing and also possibly in a
> race condition.
> 
> Fixes: d757c60eca9b ("IB/rdmavt: Fix concurrency panics in QP post_send and modify to error")
> Signed-off-by: Niels Dossche <dossche.niels@gmail.com>
> ---
>  drivers/infiniband/sw/rdmavt/qp.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)

Applied to for-rc, thanks

Jason