Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <67634336-4711-d643-03d3-d2514af55917@redhat.com>
Date:   Fri, 8 Apr 2022 10:23:12 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH 4/5] drm/solomon: Move device info from ssd130x-i2c to the
 core driver
Content-Language: en-US
To:     Neil Armstrong <narmstrong@baylibre.com>,
        linux-kernel@vger.kernel.org
Cc:     Chen-Yu Tsai <wens@kernel.org>, David Airlie <airlied@linux.ie>,
        dri-devel@lists.freedesktop.org, Mark Brown <broonie@kernel.org>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>
References: <20220407200205.28838-1-javierm@redhat.com>
 <20220407200205.28838-5-javierm@redhat.com>
 <58e38622-a041-3e5c-3dca-fa95cd5f59be@baylibre.com>
From:   Javier Martinez Canillas <javierm@redhat.com>
In-Reply-To: <58e38622-a041-3e5c-3dca-fa95cd5f59be@baylibre.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hello Neil,

Thanks for your feedback.

On 4/8/22 09:49, Neil Armstrong wrote:

[snip]

>>   
>> +static struct ssd130x_deviceinfo ssd130x_variants[] =  {
>> +	{
>> +		.default_vcomh = 0x40,
>> +		.default_dclk_div = 1,
>> +		.default_dclk_frq = 5,
>> +		.page_mode_only = 1,
>> +	},
> 
> Why not [SH1106_ID] = {
> 
> and later:
> 
> if (variant < NR_SSD130X_VARIANTS)
> 	ssd130x->device_info = ssd130x_variants[variant];
> 
> instead of less efficient ssd13x_variant_to_info ?
>

Indeed. I'll change that in v2.

-- 
Best regards,

Javier Martinez Canillas
Linux Engineering
Red Hat