Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 8 Apr 2022 19:00:28 -0700
From:   Josh Poimboeuf <jpoimboe@redhat.com>
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     x86@kernel.org, Lai Jiangshan <jiangshanlai@gmail.com>,
        Andrew Cooper <Andrew.Cooper3@citrix.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH] x86: PUSH_AND_CLEAR_REGS_COMPAT
Message-ID: <20220409020028.wfcwidlvg5rgwpki@treble>
References: <20220408223827.GR2731@worktop.programming.kicks-ass.net>
 <20220408231447.GS2731@worktop.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20220408231447.GS2731@worktop.programming.kicks-ass.net>
Precedence: bulk

On Sat, Apr 09, 2022 at 01:14:47AM +0200, Peter Zijlstra wrote:
> On Sat, Apr 09, 2022 at 12:38:27AM +0200, Peter Zijlstra wrote:
> > 
> > How insane?
> 
> Anyway, the questino is; since int80 doesn't wipe the high regs, can we
> get away with the SYS*_compat things not doing that either and then all
> using the normal PUSH_AND_CLEAR_REGS without having to invent _COMPAT
> for that?

I'd rather not, clearing the register values on the stack is a good
thing as it gives attackers less control.  In fact I wish we could do
that for the 64-bit syscalls, but alas, callee-saved registers and all.

-- 
Josh