Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 8 Apr 2022 14:33:49 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Coco Li <lixiaoyan@google.com>
Cc:     "David S . Miller" <davem@davemloft.net>, netdev@vger.kernel.org,
        Paolo Abeni <pabeni@redhat.com>, linux-kernel@vger.kernel.org,
        willem de bruijn <willemb@google.com>,
        Eric Dumazet <edumazet@google.com>,
        Greg Thelen <gthelen@google.com>
Subject: Re: [PATCH net-next] fou: Remove XRFM from NET_FOU Kconfig
Message-ID: <20220408143349.1e3413eb@kernel.org>
In-Reply-To: <20220407171554.2712631-1-lixiaoyan@google.com>
References: <20220407171554.2712631-1-lixiaoyan@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu,  7 Apr 2022 10:15:54 -0700 Coco Li wrote:
> XRFM is no longer needed for configuring FOU tunnels
> (CONFIG_NET_FOU_IP_TUNNELS), remove from Kconfig.

What's the full story? The original code mentions udp_encap_rcv 
but would be used to note where that dependency got removed.

> Built and installed kernel and setup GUE/FOU tunnels.
> 
> Signed-off-by: Coco Li <lixiaoyan@google.com>
> ---
>  net/ipv4/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig
> index 87983e70f03f..e983bb0c5012 100644
> --- a/net/ipv4/Kconfig
> +++ b/net/ipv4/Kconfig
> @@ -321,7 +321,6 @@ config NET_UDP_TUNNEL
>  
>  config NET_FOU
>  	tristate "IP: Foo (IP protocols) over UDP"
> -	select XFRM
>  	select NET_UDP_TUNNEL
>  	help
>  	  Foo over UDP allows any IP protocol to be directly encapsulated

I think we can also remove the include of xfrm.h from fou.c ?