Received: by 2002:a05:6a10:144:0:0:0:0 with SMTP id 4csp1186910pxw; Sat, 9 Apr 2022 14:38:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz1rlAju/b0Iq1Mv5gcKYZXLFLkhClXu6p1jPHd7iPVcSihXJIr2RL21N2KnmwEkivS63Uz X-Received: by 2002:a17:906:37cd:b0:6e0:bdb6:f309 with SMTP id o13-20020a17090637cd00b006e0bdb6f309mr24043856ejc.394.1649540335833; Sat, 09 Apr 2022 14:38:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649540335; cv=none; d=google.com; s=arc-20160816; b=TjHXG4WU1Pp/tY0d/o+sPbcy3cN0YSWTbUTQFRLzGhL+Ez5qcBdE1A71MVycrfB+iL fDXwHIKpFOMixr+wpp6OHJp929LQBDNUj8IFfQKA7HgmhsOb0gmy4vKsoaTqaIpgsi1b C2nIB8hSWSj8oB1JgcKemoY47HWwnaczXrX5soMiDgrUQFxM+pn/nHQVYKNoNsidd16e 7r56O1cJVwfqlgBPnKsEfk30Wlves4Z4RJTCb0TcgLMMu5/nWG49iLLh4PGFqr6rT+Dz j8EN2qYz5cb0IbqQpE706ZjFdMQRHLduXW/ran0ahz4+5dQLBLCFeDwFq45aw4xV/9Tw OuLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=vl38/Gn1Ja/tfx1OE95rZjNeXGNT1OOD4zzjhjOONik=; b=DHMMfWWG99TRNZLHBgEpqSp5QBe1G6eE2gmUs/gX6U4lyZo2s2L4NBcuPpwXwTzY1o jzBBVzIA+NOMgJ8X5oXM94s5pc1nesJTfVlbEYrAA6nIkE3wAhcmDTaRLfsTiXevnRDR 3WXoxKaK+bPg1e4kZdJWOyeDzmlgjliu5FYjAFno89cBtwhvJQhig4Qf1Waa1QfUtyaT 1yEvNb5OnX4iHEPzQ6x6WSmWuKSnDwQMni4YULJEOUg1m9F3xnipuhi+EC+VcYZ7oxDA VTga0iDdMaAkY/K47kkduKMX1UBTFtmZzRaF9ORlCgxTfiLCpZnqLSLxzh0YMzS4KBF/ 4WtQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=K1Wsvwuo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b12-20020a50e38c000000b00418ed45e7ddsi4239267edm.38.2022.04.09.14.38.28; Sat, 09 Apr 2022 14:38:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=K1Wsvwuo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238838AbiDIOpH (ORCPT + 99 others); Sat, 9 Apr 2022 10:45:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232292AbiDIOpD (ORCPT ); Sat, 9 Apr 2022 10:45:03 -0400 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8573BDE8F for ; Sat, 9 Apr 2022 07:42:55 -0700 (PDT) Received: by mail-pj1-x102b.google.com with SMTP id h23-20020a17090a051700b001c9c1dd3acbso12314510pjh.3 for ; Sat, 09 Apr 2022 07:42:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=vl38/Gn1Ja/tfx1OE95rZjNeXGNT1OOD4zzjhjOONik=; b=K1WsvwuoCpAIHJWhA/t7k/ll20oJIFxUcaj9+xFS8rndq8lbEQnGLMXJKZM92HJ5AG iYR9vg9r170/BRZdFbYm/E9/61C8iwLGhVZYfL7acFA+08b7E3iHtHQFDIYuwunVOt9H D5St9/4uIf3Fjdura6SkBzwY3HJ9jNvDI70sKSbT7ICPZdJoL2SIBSGDMbqzhlDMato+ gE0osfNBgJ7tDoSm7Yt3hETKG4VlH4CRVtImaL+hqCBFxESMw2oGY6U4bI/cJbWAjlPK blbZE2zVGlRNrllye2MBu16e8vHPCTOxXxY4+/c4VcMeif9zdMBEm8cBhWYG8rEEfiz6 AJPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=vl38/Gn1Ja/tfx1OE95rZjNeXGNT1OOD4zzjhjOONik=; b=WDqJalPKAJ3izf+nOYmPD7zt/wBRATPAlw1SxrQqOPhNLnZGIro4k+5wK9FZfa1svX DP1LOddS7aZeH3hAHLX8haBOHDYyjFyxdC5tybBzFoX6IZLZvEiwuc5WVYLedodLmJK9 stoc9yXrspcqQBZtSyiLZR8t2jYsT1L3XX7DYtihk7AYxGklecnpdYus9c8hH2qfgl0n 8IB+z4lLUirZn3Gk1sE8UKSfB/sVkZvpBm28GPznQ7Jpg3bTc6tTGQDi4DQZv004ZCvd fDscs9suibJXH3TXV7xtRO+aZingtom6+YqVPj7GZ1EIBsHabAwA3mcPAFA9eRz6SbUp wSdA== X-Gm-Message-State: AOAM531Wo3ELU3+5FjHqeY95Dkl1yRNSV29ZOUSMdUSdcp9Qbh2pf3aM iAdAvYKBeJbAtj5Cf47lAA== X-Received: by 2002:a17:90b:1bc8:b0:1c7:443:3ffb with SMTP id oa8-20020a17090b1bc800b001c704433ffbmr26976623pjb.84.1649515374917; Sat, 09 Apr 2022 07:42:54 -0700 (PDT) Received: from localhost.localdomain ([121.165.123.189]) by smtp.gmail.com with ESMTPSA id q5-20020a17090a68c500b001cb651fffdbsm2218373pjj.8.2022.04.09.07.42.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Apr 2022 07:42:54 -0700 (PDT) From: JaeSang Yoo X-Google-Original-From: JaeSang Yoo To: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin Cc: Ohhoon Kwon , Wonhyuk Yang , Jiyoup Kim , Donghyeok Kim , JaeSang Yoo , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH] mm/slub: remove meaningless node check in ___slab_alloc() Date: Sat, 9 Apr 2022 23:42:39 +0900 Message-Id: <20220409144239.2649257-1-jsyoo5b@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org node_match() with node=NUMA_NO_NODE always returns 1. Duplicate check by goto statement is meaningless. Remove it. Signed-off-by: JaeSang Yoo --- mm/slub.c | 1 - 1 file changed, 1 deletion(-) diff --git a/mm/slub.c b/mm/slub.c index 9fe000fd19ca..a65e282b8238 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -2913,7 +2913,6 @@ static void *___slab_alloc(struct kmem_cache *s, gfp_t gfpflags, int node, */ if (!node_isset(node, slab_nodes)) { node = NUMA_NO_NODE; - goto redo; } else { stat(s, ALLOC_NODE_MISMATCH); goto deactivate_slab; -- 2.25.1