Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <70411972-e31a-27a1-acbf-26f5ab471a6a@linux.intel.com>
Date:   Fri, 8 Apr 2022 22:45:16 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH] perf: Add missing newline at end of file
Content-Language: en-US
To:     "Liang, Kan" <kan.liang@intel.com>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
Cc:     Geert Uytterhoeven <geert+renesas@glider.be>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Andi Kleen <andi@firstfloor.org>,
        Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
References: <20190617144725.6415-1-geert+renesas@glider.be>
 <20190617160011.GB3927@kernel.org>
 <CAMuHMdWPDMhz9YdEs-=iCLa6w--iS-Ug9SMUa=UG0bW2mMYyxA@mail.gmail.com>
 <CO1PR11MB4803640A785DF199D0496017E8E49@CO1PR11MB4803.namprd11.prod.outlook.com>
From:   Xing Zhengjun <zhengjun.xing@linux.intel.com>
In-Reply-To: <CO1PR11MB4803640A785DF199D0496017E8E49@CO1PR11MB4803.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 4/5/2022 9:59 PM, Liang, Kan wrote:
>
>> On Mon, Jun 17, 2019 at 6:00 PM Arnaldo Carvalho de Melo
>> <arnaldo.melo@gmail.com> wrote:
>>> Em Mon, Jun 17, 2019 at 04:47:25PM +0200, Geert Uytterhoeven escreveu:
>>>> "git diff" says:
>>>>
>>>>      \ No newline at end of file
>>>>
>>>> after modifying the files.
>>> Auto generated files, IIRC, Andi, Kan, Sukadev?
>> The auto-generated files have been updated, the issue still exists.
>>
> It seems like a converter tool issue.
>
> + Zhengjun
>
> Zhengjun, could you please take a look?
>
> Thanks,
> Kan
It only happened for perf core event files. Add "\n" at the end of the 
perf core event file, then the issue is fixed.
I have updated the event convert tool 
https://github.com/intel/event-converter-for-linux-perf , then the next 
time uses the convert tool to generate perf events, the issue will be 
disappeared.

-- 
Zhengjun Xing