Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\))
Subject: Re: [PATCH 07/18] MIPS: DTS: jz4780: fix otg node as reported by
 dtbscheck
From:   "H. Nikolaus Schaller" <hns@goldelico.com>
In-Reply-To: <bd19b6eb-d53a-b665-749d-46c275c85ccc@linaro.org>
Date:   Sat, 9 Apr 2022 15:05:37 +0200
Cc:     Rob Herring <robh+dt@kernel.org>,
        Paul Cercueil <paul@crapouillou.net>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        linux-mips@vger.kernel.org, letux-kernel@openphoenux.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <822182F3-5429-4731-9FA1-8F18C5D95DEC@goldelico.com>
References: <cover.1649443080.git.hns@goldelico.com>
 <298162bfa2e7225ccc753865e1ffa39ce2722b2a.1649443080.git.hns@goldelico.com>
 <bd19b6eb-d53a-b665-749d-46c275c85ccc@linaro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Precedence: bulk


> Am 09.04.2022 um 13:15 schrieb Krzysztof Kozlowski =
<krzysztof.kozlowski@linaro.org>:
>=20
> On 08/04/2022 20:37, H. Nikolaus Schaller wrote:
>> arch/mips/boot/dts/ingenic/ci20.dtb: usb@13500000: compatible: =
'oneOf' conditional failed, one must be fixed:
>> 	['ingenic,jz4780-otg', 'snps,dwc2'] is too long
>> 	['ingenic,jz4780-otg', 'snps,dwc2'] is too short
>> 	'brcm,bcm2835-usb' was expected
>> 	'hisilicon,hi6220-usb' was expected
>> 	'rockchip,rk3066-usb' was expected
>> 	'ingenic,jz4780-otg' is not one of ['rockchip,px30-usb', =
'rockchip,rk3036-usb', 'rockchip,rk3188-usb', 'rockchip,rk3228-usb', =
'rockchip,rk3288-usb', 'rockchip,rk3308-usb', 'rockchip,rk3328-usb', =
'rockchip,rk3368-usb', 'rockchip,rv1108-usb']
>> 	'lantiq,arx100-usb' was expected
>> 	'lantiq,xrx200-usb' was expected
>> 	'ingenic,jz4780-otg' is not one of ['amlogic,meson8-usb', =
'amlogic,meson8b-usb', 'amlogic,meson-gxbb-usb', =
'amlogic,meson-g12a-usb', 'intel,socfpga-agilex-hsotg']
>> 	'amcc,dwc-otg' was expected
>> 	'apm,apm82181-dwc-otg' was expected
>> 	'snps,dwc2' was expected
>> 	'st,stm32f4x9-fsotg' was expected
>> 	'st,stm32f4x9-hsotg' was expected
>> 	'st,stm32f7-hsotg' was expected
>> 	'st,stm32mp15-fsotg' was expected
>> 	'st,stm32mp15-hsotg' was expected
>> 	'samsung,s3c6400-hsotg' was expected
>> 	'intel,socfpga-agilex-hsotg' was expected
>=20
> You really don't need to paste entire warning.
>=20
>=20
>> 	=46rom schema: Documentation/devicetree/bindings/usb/dwc2.yaml
>>=20
>> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
>> ---
>> arch/mips/boot/dts/ingenic/jz4780.dtsi | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>=20
>> diff --git a/arch/mips/boot/dts/ingenic/jz4780.dtsi =
b/arch/mips/boot/dts/ingenic/jz4780.dtsi
>> index 2021836983c96..c5124459678b7 100644
>> --- a/arch/mips/boot/dts/ingenic/jz4780.dtsi
>> +++ b/arch/mips/boot/dts/ingenic/jz4780.dtsi
>> @@ -576,7 +576,7 @@ bch: bch@134d0000 {
>> 	};
>>=20
>> 	otg: usb@13500000 {
>> -		compatible =3D "ingenic,jz4780-otg", "snps,dwc2";
>> +		compatible =3D "snps,dwc2";
>=20
> This looks wrong, the block usually should have a specific compatible.
> Please mention why it does not.

Well, I did not even have that idea that it could need an explanation.

There is no "ingenic,jz4780-otg" and none is needed here to make it =
work.

Therefore the generic "snps,dwc2" is sufficient.