Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   =?ISO-8859-1?Q?J=E9r=F4me?= Pouiller <jerome.pouiller@silabs.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jaehee Park <jhpark1013@gmail.com>,
        Stefano Brivio <sbrivio@redhat.com>
Cc:     linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
        outreachy@lists.linux.dev,
        Alison Schofield <alison.schofield@intel.com>
Subject: Re: [PATCH v2] staging: wfx: use container_of() to get vif
Date:   Sat, 09 Apr 2022 16:07:12 +0200
Message-ID: <2419031.jE0xQCEvom@pc-42>
Organization: Silicon Labs
In-Reply-To: <20220408074424.6e862f3f@elisabeth>
References: <20220408032349.GA2132476@jaehee-ThinkPad-X1-Extreme> <Yk++AMDTu7LCbjHu@kroah.com> <20220408074424.6e862f3f@elisabeth>
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?dOv0h82Rgl9jrxjGEJWwgwn/DFJVHpPkjkdeIRkvjUeRiDW+k9LkxoQOw0?=
 =?iso-8859-1?Q?jwGWNABiZQBlMFPKV6+7OhVNMd9L0Qx833II3bezoNsWmDuCz1zeIrz7Dy?=
 =?iso-8859-1?Q?c/HocCksh51S78nYOqGoU8mIhMBN7J074lts95y5bgLcz5d9yTT7Cq2rtl?=
 =?iso-8859-1?Q?i150rDh+BOMxnIC/WqvKZXoXSzh6YI1G4R81vFkC5krXZ2f4Gr9MLCws4f?=
 =?iso-8859-1?Q?XB14hgMff48pkScVs+78c+NVG75ytJ1I1Xla0CQfpKSZLhGsbaCZkn6vlL?=
 =?iso-8859-1?Q?D1Wg1ZEBjoKvt0HqCNfwOw99/+WXDEHEny1g2EoH200+UMD7AJpMNtjULg?=
 =?iso-8859-1?Q?caj1S1za/dX5rSY+vTcDlKOARxY+040PLrfDT8vuhAYoUU7bOGmeZgotY1?=
 =?iso-8859-1?Q?PEO4ekaIcZsfVpf5wwFTu/Ok9UeAbH0QHh3k1laxR39Y/JTz3HL5JiN3WD?=
 =?iso-8859-1?Q?y1sOwNz6uptpPlhp16s1EjfdeUKIgIySKim6ZX5Z+60tSKwt0h+n6BzjFq?=
 =?iso-8859-1?Q?y/+wSXzj7HXC/9IujN2Hn2HSCpSAedUHEX4Fgb8WTFl9029XEVBuZOLM3o?=
 =?iso-8859-1?Q?xmSeL2Jd4hlaUI+ST224qnMQXsmdcAEQeWZP+jp7KksnFxTHlS4K5jIyN9?=
 =?iso-8859-1?Q?8Y5ZVf0X7P+mdsIw8XGkRuEgOL3seMpQrqZAuiW3t8fD7qC5znPLMyfF9X?=
 =?iso-8859-1?Q?WOZaSXyexhidJo9CPROrHXOKfcksRW9yyf+uPeMSz++jUKiKUFyCQqdlcQ?=
 =?iso-8859-1?Q?tnMHh4oFqMMvkqqgXlhlZwuzJ9FbBM4Dzh+Na8CTzf2vdkXqQj0SXf11sn?=
 =?iso-8859-1?Q?oBQbcFn5AMBaAVww+xb8ITtHSRrwCeHbC0btKUVhU1whjg/6Vpn31kn0vZ?=
 =?iso-8859-1?Q?MD6M6qlhTDBL1tOMkzFNYZNAWGyxeHRb+2TyH6WVCbre6Q1hRRXNSvQAip?=
 =?iso-8859-1?Q?N7DgsECD4g91ciPjJ8lpUsjiOxdi613NZ8A4C2X0aKvtukH2YW5x2H+L/d?=
 =?iso-8859-1?Q?lvgyUDyy2qtqEbY87w1XWlZ7yIbeAn8G8xwSjRviqLqWIpXGYbxw2gzQCy?=
 =?iso-8859-1?Q?r3OJyVQpbg2ZqCcqlbgY2wmu9bwxu9ENq7tKDqX0X1ybVTgsk5wWMA5Jux?=
 =?iso-8859-1?Q?7eOYmPHQ9DFWE1tVxk+uw1ZeKYb0zAapfPD6HgR5xDkCdYHIXFu1ZTNm10?=
 =?iso-8859-1?Q?FIjQKAAJJb1VVMxG9FxW6v8TYYYLbm/vHbClCCVqTHw4ZbS4ocE0GWqEWJ?=
 =?iso-8859-1?Q?iiE9DBMot1o6Zgb5PUsHFdgg44l+m1Eoqe5jvrrX4UWU/Epk07HvpdHqJK?=
 =?iso-8859-1?Q?FNGOJ1/x9+R6BvOU3YoQkMeWpva1EWGbDYZSBmP25Mj/QiRXmSFik4g8fo?=
 =?iso-8859-1?Q?WeoM+1jyno0ElkpNlQ1uso4LUJ1Q4xSvB8JHtb0HToSEyG+y4GfQVWpOhs?=
 =?iso-8859-1?Q?AuJwAZmn/0o98HaHlAWS3ia5nqtjLHkSp0lAVcZGt/wMqp1BbpLSyi6aex?=
 =?iso-8859-1?Q?JNWeCvLeWNEvUXI0WjUV7Zgbgz+ASA/7duQqjUBczxJXwxijKcFvIpWa5x?=
 =?iso-8859-1?Q?HgQC5jCaW2WVSM3WRJoU97j8bJiB5d3qjOJUreauKLSJ4YW4LGoELHflAA?=
 =?iso-8859-1?Q?EuzFCDDrxRAZEwD1HNRSFkI3UE2f/KgR8cx2qDUrEmyrhe2sc4gmv1S4sQ?=
 =?iso-8859-1?Q?uF2KdiJAklv2K/p3jh7AVAjaCOVYvS0Rh3uBYHxLX+Jj8gCSqsTpX94iQU?=
 =?iso-8859-1?Q?TyXnkTuLcjacclGgeS6TNRgW8pRiyINYJj40OddGNl2WjOuuCC8qtMmk2C?=
 =?iso-8859-1?Q?J3geja6bNOIRToV/TtHyIY3QbdPs0L9vlQKPWXeJL9dFgmsZNsoKxPhY3l?=
 =?iso-8859-1?Q?Ck?=
X-MS-Exchange-AntiSpam-MessageData-1: /rPJneUQAucS5Ff5NlLrwN9ciQZ1+ncdUQY=
X-OriginatorOrg: silabs.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c1a9f2e2-d1df-4a52-47bf-08da1a32429c
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5657.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2022 14:07:19.5977
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 66OZ5ecculhaLPXULL5FkkOfp9jrM/tKy+A5041FC6C4voyKkbFpb2ztlqRip98lgwGRTgKnp86VI8QurPJuGg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3386
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Friday 8 April 2022 07:44:24 CEST Stefano Brivio wrote:
> On Fri, 8 Apr 2022 06:45:52 +0200 Greg Kroah-Hartman <gregkh@linuxfoundat=
ion.org> wrote:
> > On Thu, Apr 07, 2022 at 11:23:49PM -0400, Jaehee Park wrote:
> > >
> > > [...]
> > >
> > > @@ -61,7 +63,6 @@ struct wfx_dev {
> > >
> > >  struct wfx_vif {
> > >     struct wfx_dev             *wdev;
> > > -   struct ieee80211_vif       *vif;
> >
> > You need to test this on real hardware.  For an outreachy-first-task,
> > this is not a good one at all.
>=20
> We discussed about this on the outreachy list, and I suggested, as
> Jaehee also mentioned, that maybe somebody (J=E9r=F4me?) with the hardwar=
e
> could give it a try.
>
> It looks a bit difficult but it also looks almost correctly done now. :)

Absolutely.

I will test it once the various comments will be fixed.


--=20
J=E9r=F4me Pouiller