Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3d5c2bfc-cfb1-ea2d-f88c-36e0e4f92293@kernel.org>
Date:   Fri, 8 Apr 2022 21:50:19 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH RESEND net-next v5 2/4] net: skb: rename
 SKB_DROP_REASON_PTYPE_ABSENT
Content-Language: en-US
To:     menglong8.dong@gmail.com, kuba@kernel.org, pabeni@redhat.com
Cc:     rostedt@goodmis.org, mingo@redhat.com, xeb@mail.ru,
        davem@davemloft.net, yoshfuji@linux-ipv6.org,
        imagedong@tencent.com, edumazet@google.com, kafai@fb.com,
        talalahmad@google.com, keescook@chromium.org, alobakin@pm.me,
        flyingpeng@tencent.com, mengensun@tencent.com,
        dongli.zhang@oracle.com, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org, benbjiang@tencent.com
References: <20220407062052.15907-1-imagedong@tencent.com>
 <20220407062052.15907-3-imagedong@tencent.com>
From:   David Ahern <dsahern@kernel.org>
In-Reply-To: <20220407062052.15907-3-imagedong@tencent.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/7/22 12:20 AM, menglong8.dong@gmail.com wrote:
> From: Menglong Dong <imagedong@tencent.com>
> 
> As David Ahern suggested, the reasons for skb drops should be more
> general and not be code based.
> 
> Therefore, rename SKB_DROP_REASON_PTYPE_ABSENT to
> SKB_DROP_REASON_UNHANDLED_PROTO, which is used for the cases of no
> L3 protocol handler, no L4 protocol handler, version extensions, etc.
> 
> From previous discussion, now we have the aim to make these reasons
> more abstract and users based, avoiding code based.
> 
> Signed-off-by: Menglong Dong <imagedong@tencent.com>
> ---
>  include/linux/skbuff.h     | 8 +++-----
>  include/trace/events/skb.h | 2 +-
>  net/core/dev.c             | 8 +++-----
>  3 files changed, 7 insertions(+), 11 deletions(-)
> 


Reviewed-by: David Ahern <dsahern@kernel.org>