Received: by 2002:a05:6a10:87d6:0:0:0:0 with SMTP id g22csp417359pxr; Sun, 10 Apr 2022 19:29:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz5FJr8WJBYq+lDbMKqpszt9zli+lt5pxRi7ADPOQWxf5CUB2EDsae4/1mijFLeTikZMpx/ X-Received: by 2002:a63:2f46:0:b0:382:230f:b155 with SMTP id v67-20020a632f46000000b00382230fb155mr25467523pgv.64.1649644176475; Sun, 10 Apr 2022 19:29:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649644176; cv=none; d=google.com; s=arc-20160816; b=bJ+0EwwEi0JZR8V8EDcAq6Ud0ZPOT/6VTo1n2/nl17RHFx5Lue55L9syO7dIYeKdip wt4wBZH7pyuPNHJ7krjEEPo0VinX18MKoLBGpFjo1kcvVp1IqgxahAg74xxibA8tXUWX IZH5fNwAW1OxHXxX6KL+rPkCou83Aq3gq6/pzOWXGVf5KLqqKDi/KWL0KKduANrLbc0e AFVErg+kFkuXhK+dGuC/9++sL96N7s7Dwfj/J+QLLVjuF0jddJIdOkOys6oWxBtMYh/v oN/nJvTs7HDMydX9n7LTQKHPnhqvJdLEkIk8KR5IYIFicmhHNUADjkmB76GMIwVVwN9p WvDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:dkim-signature:dkim-signature:from; bh=4jv1XCzAA0sQnRATbKYwT40mQz2UjI4mAAOrGkzxjJ0=; b=udqZLTX193vZzM3NjSnCrUfhH6/8l5g7BrN0ne8MWjzFUmOKtSUSxOHxEeiLECIBB3 +2dnvRxktS8I3apC2o/DSZb4byOLQHu2c/Ng0t88HM4wgGD9XidGOe1Ded1SuaFQ492H XsjtF+3LEodLa9PiFXW3Peh1LI6cDAGG6Ga9Lfcj9+I0qwsvdqcaZd4b4qI11ZltyG7D XjKHUidlZnFitPlcNPh7ZHKzi+Dz1Xv7VEdbDdmHsq3Hd7FsBxU7E8TCuwzYztyOOqYw 5hUBDf9L198VVSD44A8eaz9JjppxPVzVIuHKSvDIcLcWpHXoJs1cWuUzms2wyZvZlOJB xBHw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=oN4OzZ98; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=z4nQH3vI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c15-20020a17090aa60f00b001bd14e01f3bsi10595968pjq.41.2022.04.10.19.29.22; Sun, 10 Apr 2022 19:29:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=oN4OzZ98; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=z4nQH3vI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239918AbiDHVsq (ORCPT + 99 others); Fri, 8 Apr 2022 17:48:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239908AbiDHVso (ORCPT ); Fri, 8 Apr 2022 17:48:44 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C99BF160C37 for ; Fri, 8 Apr 2022 14:46:37 -0700 (PDT) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1649454395; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4jv1XCzAA0sQnRATbKYwT40mQz2UjI4mAAOrGkzxjJ0=; b=oN4OzZ98SJpzhn99fiyr2x/tQm0k3Xg6UFZEviT7uYkq4Anlr1oPBg5AY5R6t0QqJDo89d /0eu8omXgmv2bJqj7eAs8rmTJA6PeWsdJ+WduCat+c7av47GH+DuSb6n5hehD7C4VXyM/1 Kpw3DXP6iLFNwNzS7xoeBDDip3STref5cHm7n5du2fU6hWEagdtkzjWF4xnYsXBcwAhufq yUiv8/K7PspftKjQTy97FedXolVMkucDAuUjvqyiSyozSn9lsQ46aAa7c10NaP1ik5QDeE Mam29PAXKZjER0BWs+lNN+jlXUGSKzy/1ylU+/ZIHR/SY1yfWLKuhQRdXGegaA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1649454395; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4jv1XCzAA0sQnRATbKYwT40mQz2UjI4mAAOrGkzxjJ0=; b=z4nQH3vI3VTtHrctAJwIeHhOG7tShlqCZwY4sb/sWZjZhPcyXv+lhQxxudhDbgVpwEwBaj CHtnMcm1CuJTOdDw== To: Steven Rostedt Cc: Linus Torvalds , LKML , jstultz@google.com, Stephen Boyd , Andrew Morton , Peter Zijlstra , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Eric Dumazet , Guenter Roeck Subject: Re: [RFC][PATCH] timers: Add del_time_free() to be called before freeing timers In-Reply-To: <20220408165827.42475fb2@gandalf.local.home> References: <20220407161745.7d6754b3@gandalf.local.home> <87pmlrkgi3.ffs@tglx> <87v8vjiaih.ffs@tglx> <20220408165827.42475fb2@gandalf.local.home> Date: Fri, 08 Apr 2022 23:46:34 +0200 Message-ID: <87pmlri6yt.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 08 2022 at 16:58, Steven Rostedt wrote: > On Fri, 08 Apr 2022 22:29:58 +0200 > Thomas Gleixner wrote: > >> What a shutdown function would prevent here is UAF, but I'm not entirely >> sure whether it will simplify coordinated shutdown and remove the >> requirement of a priv->shutdown flag all over the place. It might make >> some of the driver muck just get stuck in the shutdown, but that's >> definitely an improvement over a potential UAF which happens every blue >> moons. > > Note, it is the cause of a large percentage of crash reports reported by > ChromeOS. > > And we do not even know if it was this bluetooth issue that caused them. > There's evidence they are mostly caused by the wifi code. I only used the > bluetooth issue because it was the first one we found that looked obviously > wrong. I'm sure that there are hundres more...