Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 9 Apr 2022 12:07:15 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     John Garry <john.garry@huawei.com>
Cc:     James Clark <james.clark@arm.com>,
        linux-perf-users@vger.kernel.org, alexandre.truong@arm.com,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        German Gomez <german.gomez@arm.com>,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf: Don't show unwind error messages when augmenting
 frame pointer stack
Message-ID: <YlGhI1nHOpbb09GU@kernel.org>
References: <20220406145651.1392529-1-james.clark@arm.com>
 <ab0293b6-9e71-a28a-e5c1-e4d9b22b0ae6@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ab0293b6-9e71-a28a-e5c1-e4d9b22b0ae6@huawei.com>
Precedence: bulk

Em Fri, Apr 08, 2022 at 03:12:15PM +0100, John Garry escreveu:
> On 06/04/2022 15:56, James Clark wrote:
> > Commit b9f6fbb3b2c2 ("perf arm64: Inject missing frames when using 'perf
> > record --call-graph=fp'") intended to add a 'best effort' Dwarf unwind
> > that improved the frame pointer stack in most scenarios. It's expected
> > that the unwind will fail sometimes, but this shouldn't be reported as
> > an error. It only works when the return address can be determined from
> > the contents of the link register alone.
> > 
> > Fix the error shown when the unwinder requires extra registers by adding
> > a new flag that suppresses error messages. This flag is not set in the
> > normal --call-graph=dwarf unwind mode so that behavior is not changed.
> > 
> > Reported-by: John Garry <john.garry@huawei.com>
> > Fixes: b9f6fbb3b2c2 ("perf arm64: Inject missing frames when using 'perf record --call-graph=fp'")
> > Signed-off-by: James Clark <james.clark@arm.com>
> 
> Seems ok:
> Tested-by: John Garry <john.garry@huawei.com>

Thanks, applied.

- Arnaldo