Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220408083728.25701-1-xiam0nd.tong@gmail.com> <20220408122348.bt7lkaumwhv36a2q@fiona>
In-Reply-To: <20220408122348.bt7lkaumwhv36a2q@fiona>
From:   Song Liu <song@kernel.org>
Date:   Fri, 8 Apr 2022 09:35:54 -0700
Message-ID: <CAPhsuW5qZiE4z0j_+pJbiHQ+zK9oVw3DLgEXdSQ0m=m5ULX1Mw@mail.gmail.com>
Subject: Re: [PATCH v3] md: fix an incorrect NULL check in does_sb_need_changing
To:     Goldwyn Rodrigues <rgoldwyn@suse.de>
Cc:     Xiaomeng Tong <xiam0nd.tong@gmail.com>,
        Guoqing Jiang <guoqing.jiang@linux.dev>,
        linux-raid <linux-raid@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        stable@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Apr 8, 2022 at 5:23 AM Goldwyn Rodrigues <rgoldwyn@suse.de> wrote:
>
> On 16:37 08/04, Xiaomeng Tong wrote:
> > The bug is here:
> >       if (!rdev)
> >
> > The list iterator value 'rdev' will *always* be set and non-NULL
> > by rdev_for_each(), so it is incorrect to assume that the iterator
> > value will be NULL if the list is empty or no element found.
> > Otherwise it will bypass the NULL check and lead to invalid memory
> > access passing the check.
> >
> > To fix the bug, use a new variable 'iter' as the list iterator,
> > while using the original variable 'rdev' as a dedicated pointer to
> > point to the found element.
> >
> > Cc: stable@vger.kernel.org
> > Fixes: 2aa82191ac36 ("md-cluster: Perform a lazy update")
> > Acked-by: Guoqing Jiang <guoqing.jiang@linux.dev>
> > Signed-off-by: Xiaomeng Tong <xiam0nd.tong@gmail.com>
>
> Also safeguards from reading sb from a faulty device if all devices are
> faulty.
>
> Acked-by: Goldwyn Rodrigues <rgoldwyn@suse.com>

Applied to md-next. Thanks!