Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 10 Apr 2022 17:01:27 +0100
From:   Jonathan Cameron <jic23@kernel.org>
To:     Zheyu Ma <zheyuma97@gmail.com>
Cc:     lars@metafoo.de, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org, <linus.walleij@linaro.org>
Subject: Re: [PATCH] iio: magnetometer: ak8975: Fix the error handling in
 ak8975_power_on()
Message-ID: <20220410170127.058fc942@jic23-huawei>
In-Reply-To: <20220409034849.3717231-2-zheyuma97@gmail.com>
References: <20220409034849.3717231-1-zheyuma97@gmail.com>
        <20220409034849.3717231-2-zheyuma97@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Sat,  9 Apr 2022 11:48:49 +0800
Zheyu Ma <zheyuma97@gmail.com> wrote:

> When the driver fails to enable the regulator 'vid', we will get the
> following splat:
> 
> [   79.955610] WARNING: CPU: 5 PID: 441 at drivers/regulator/core.c:2257 _regulator_put+0x3ec/0x4e0
> [   79.959641] RIP: 0010:_regulator_put+0x3ec/0x4e0
> [   79.967570] Call Trace:
> [   79.967773]  <TASK>
> [   79.967951]  regulator_put+0x1f/0x30
> [   79.968254]  devres_release_group+0x319/0x3d0
> [   79.968608]  i2c_device_probe+0x766/0x940
> 
> Fix this by disabling the 'vdd' regulator when failing to enable 'vid'
> regulator.
> 
> Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
This driver doesn't really have a maintainer any more, though Linus W actually
last touched this bit of code. So +CC.

However, it's pretty obviously correct so applied to the fixes-togreg branch of iio.git.

For future reference, please don't send one fix as reply to a fix on a different driver.
Makes a mess of thread handling and tracking in patchwork etc.

Ideally also please provide a fixes tag.  For this one I have applied with out it
because it was a long time back and looks like the bug predates a bunch of refactoring
of this code.  

Applied to the fixes-togreg branch of iio.git and marked for stable.

Jonathan


> ---
>  drivers/iio/magnetometer/ak8975.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/magnetometer/ak8975.c b/drivers/iio/magnetometer/ak8975.c
> index 088f748b683e..2432e697150c 100644
> --- a/drivers/iio/magnetometer/ak8975.c
> +++ b/drivers/iio/magnetometer/ak8975.c
> @@ -416,6 +416,7 @@ static int ak8975_power_on(const struct ak8975_data *data)
>  	if (ret) {
>  		dev_warn(&data->client->dev,
>  			 "Failed to enable specified Vid supply\n");
> +		regulator_disable(data->vdd);
>  		return ret;
>  	}
>