Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\))
Subject: Re: [PATCH 05/18] MIPS: DTS: jz4780: fix pinctrl as reported by
 dtbscheck
From:   "H. Nikolaus Schaller" <hns@goldelico.com>
In-Reply-To: <c84b5ec0-0193-ab62-1985-25bc2baa9f05@linaro.org>
Date:   Sat, 9 Apr 2022 15:22:54 +0200
Cc:     Rob Herring <robh+dt@kernel.org>,
        Paul Cercueil <paul@crapouillou.net>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        linux-mips@vger.kernel.org, letux-kernel@openphoenux.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <B5EB5983-DA9F-4631-B737-2B1417CF9054@goldelico.com>
References: <cover.1649443080.git.hns@goldelico.com>
 <1941bc4ed553b27f399ad00ea61ff2b0237d14e3.1649443080.git.hns@goldelico.com>
 <e905896e-335d-a88a-1961-d17b92e46585@linaro.org>
 <530E0F7F-FC03-45DD-BF87-D049D3108AD3@goldelico.com>
 <c84b5ec0-0193-ab62-1985-25bc2baa9f05@linaro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Precedence: bulk


> Am 09.04.2022 um 15:13 schrieb Krzysztof Kozlowski =
<krzysztof.kozlowski@linaro.org>:
>=20
> On 09/04/2022 15:04, H. Nikolaus Schaller wrote:
>>=20
>>=20
>>> Am 09.04.2022 um 13:13 schrieb Krzysztof Kozlowski =
<krzysztof.kozlowski@linaro.org>:
>>>=20
>>> On 08/04/2022 20:37, H. Nikolaus Schaller wrote:
>>>> arch/mips/boot/dts/ingenic/ci20.dtb: pin-controller@10010000: =
$nodename:0: 'pin-controller@10010000' does not match =
'^(pinctrl|pinmux)(@[0-9a-f]+)?$'
>>>> 	=46rom schema: =
Documentation/devicetree/bindings/pinctrl/ingenic,pinctrl.yaml
>>>>=20
>>>> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
>>>> ---
>>>> arch/mips/boot/dts/ingenic/jz4780.dtsi | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>=20
>>>> diff --git a/arch/mips/boot/dts/ingenic/jz4780.dtsi =
b/arch/mips/boot/dts/ingenic/jz4780.dtsi
>>>> index 5f44cf004d473..b5299eaffb84a 100644
>>>> --- a/arch/mips/boot/dts/ingenic/jz4780.dtsi
>>>> +++ b/arch/mips/boot/dts/ingenic/jz4780.dtsi
>>>> @@ -155,7 +155,7 @@ rtc_dev: rtc@10003000 {
>>>> 		clock-names =3D "rtc";
>>>> 	};
>>>>=20
>>>> -	pinctrl: pin-controller@10010000 {
>>>> +	pinctrl: pinctrl@10010000 {
>>>=20
>>> Do it once for all DTSes, not one file at a time. There are four =
more
>>> places with this.
>>=20
>> Well, automation has no notion of "similarity" in this case to
>> merge several patches.
>=20
> What does that mean? One cannot create multiple patches and apply =
them?

This patch set was created by some automatic scripts. And they produce =
one patch
per group of warnings.

But here you ask me to merge 4 unrelated topics into a single one.

Or do you mean something else?

>=20
>> And they are not related. Every one is based on a different .yaml
>> schema file.
>=20
> Which does not matter, because the name of the node does not matter. =
We
> enforce it in schema to makes things organized and easier in testing.
> This does not fix any real problem, just the problem we created by
> ourselves with schema.
>=20
>>=20
>> That in all cases the result looks similar comes from similar
>> requirements by the schemata and has no inherent connection.
>=20
> All schemas will require it, won't they? The same for arm...

We may be talking about different things here.

My understanding:
you ask me to merge 5/18, 8/18, 9/18, 12/18 because they contain =
"controller" in the node-name.

Right? If not then we must clarify that first.

For pinctrl it is not allowed to have a -controller suffix while for the =
other it is mandatory
by the schema pattern.

BR and thanks,
Nikolaus