Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\))
Subject: Re: [PATCH 10/18] MIPS: DTS: jz4780: fix uart dmas as reported by
 dtbscheck
From:   "H. Nikolaus Schaller" <hns@goldelico.com>
In-Reply-To: <79dd8425-947d-603c-ebab-0625921551d8@linaro.org>
Date:   Sat, 9 Apr 2022 15:26:36 +0200
Cc:     Rob Herring <robh+dt@kernel.org>,
        Paul Cercueil <paul@crapouillou.net>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        linux-mips@vger.kernel.org, letux-kernel@openphoenux.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <5F7268BB-CCF3-4F01-ABB9-D5C3319F31F1@goldelico.com>
References: <cover.1649443080.git.hns@goldelico.com>
 <00ec9d965cac78b252e14444deed8c93f5116bca.1649443080.git.hns@goldelico.com>
 <a7a46736-e917-7274-1593-147ed36a2a68@linaro.org>
 <86044652-7B23-4F4D-B60F-C413F3C7BEF1@goldelico.com>
 <79dd8425-947d-603c-ebab-0625921551d8@linaro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Precedence: bulk


> Am 09.04.2022 um 15:16 schrieb Krzysztof Kozlowski =
<krzysztof.kozlowski@linaro.org>:
>=20
> On 09/04/2022 15:07, H. Nikolaus Schaller wrote:
>>=20
>>=20
>>> Am 09.04.2022 um 13:18 schrieb Krzysztof Kozlowski =
<krzysztof.kozlowski@linaro.org>:
>>>=20
>>> On 08/04/2022 20:37, H. Nikolaus Schaller wrote:
>>>> arch/mips/boot/dts/ingenic/ci20.dtb: serial@10030000: 'dmas' is a =
required property
>>>> 	=46rom schema: =
Documentation/devicetree/bindings/serial/ingenic,uart.yaml
>>>> arch/mips/boot/dts/ingenic/ci20.dtb: serial@10030000: 'dma-names' =
is a required property
>>>> 	=46rom schema: =
Documentation/devicetree/bindings/serial/ingenic,uart.yaml
>>>> arch/mips/boot/dts/ingenic/ci20.dtb: serial@10031000: 'dmas' is a =
required property
>>>> 	=46rom schema: =
Documentation/devicetree/bindings/serial/ingenic,uart.yaml
>>>> arch/mips/boot/dts/ingenic/ci20.dtb: serial@10031000: 'dma-names' =
is a required property
>>>> 	=46rom schema: =
Documentation/devicetree/bindings/serial/ingenic,uart.yaml
>>>> arch/mips/boot/dts/ingenic/ci20.dtb: serial@10032000: 'dmas' is a =
required property
>>>> 	=46rom schema: =
Documentation/devicetree/bindings/serial/ingenic,uart.yaml
>>>> arch/mips/boot/dts/ingenic/ci20.dtb: serial@10032000: 'dma-names' =
is a required property
>>>> 	=46rom schema: =
Documentation/devicetree/bindings/serial/ingenic,uart.yaml
>>>> arch/mips/boot/dts/ingenic/ci20.dtb: serial@10033000: 'dmas' is a =
required property
>>>> 	=46rom schema: =
Documentation/devicetree/bindings/serial/ingenic,uart.yaml
>>>> arch/mips/boot/dts/ingenic/ci20.dtb: serial@10033000: 'dma-names' =
is a required property
>>>> 	=46rom schema: =
Documentation/devicetree/bindings/serial/ingenic,uart.yaml
>>>> arch/mips/boot/dts/ingenic/ci20.dtb: serial@10034000: 'dmas' is a =
required property
>>>> 	=46rom schema: =
Documentation/devicetree/bindings/serial/ingenic,uart.yaml
>>>> arch/mips/boot/dts/ingenic/ci20.dtb: serial@10034000: 'dma-names' =
is a required property
>>>> 	=46rom schema: =
Documentation/devicetree/bindings/serial/ingenic,uart.yaml
>>>> arch/mips/boot/dts/ingenic/ci20.dtb: i2c@10050000: 'dmas' is a =
required property
>>>=20
>>> All these warnings are the same two warnings...
>>=20
>> See my earlier explanation that without them you can't verify by just =
reading commit message
>> and diff that all existing warnings have been addressed.
>=20
> Which does not make sense and there is no need... Automation does it
> (see Rob's tools). Don't make human life more difficult...

Ok, you are right. If you apply this patch and then run dtbscheck again, =
there would be
a warning left over.

But may I honestly ask why you review the commits and read the commit =
message at all?
You could simply ignore it... And it would be easier for both of us to =
leave it completely
to Rob's tools :)

BR and thanks,
Nikolaus