Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754963AbXECGdg (ORCPT ); Thu, 3 May 2007 02:33:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754972AbXECGdf (ORCPT ); Thu, 3 May 2007 02:33:35 -0400 Received: from smtp35.poczta.interia.pl ([80.48.65.35]:38965 "EHLO smtp4.poczta.interia.pl" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754705AbXECGde (ORCPT ); Thu, 3 May 2007 02:33:34 -0400 Message-ID: <4639822D.2060302@interia.pl> Date: Thu, 03 May 2007 08:33:17 +0200 From: =?ISO-8859-2?Q?Rafa=B3_Bilski?= User-Agent: Thunderbird 1.5.0.10 (X11/20070321) MIME-Version: 1.0 To: Mark Brown Cc: Tim Hockin , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: Natsemi DP83815 driver spaming References: <46379A7E.3000109@interia.pl> <20070501212750.GC31630@sirena.org.uk> <46382798.2090709@interia.pl> <463830E1.8080107@interia.pl> <20070502082211.GD31630@sirena.org.uk> <4638EF0B.9050701@interia.pl> <20070502214128.GA4814@sirena.org.uk> In-Reply-To: <20070502214128.GA4814@sirena.org.uk> X-Enigmail-Version: 0.94.3.0 Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: 8bit X-EMID: e2640acc Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 923 Lines: 27 >> What about module option? > > That would work, though you crossed in the post with me writing a patch > adding a sysfs file; I merged the two for overkill (below). I also have > a patch which changes the log message for the workaround so that it is > displayed by default in order to make this easier to diagnose. Applied. I set default value to 0. Flashed. However > + if (!NATSEMI_CREATE_FILE(pdev, dspcfg_workaround)) > + goto err_create_file; is going to err_create_file. Without these lines drivers works fine. Rafa? ---------------------------------------------------------------------- NIE KUPUJ!!! ...zanim nie porownasz cen >> http://link.interia.pl/f1a5e - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/