Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 10 Apr 2022 13:06:26 +0000
From:   Yazen Ghannam <yazen.ghannam@amd.com>
To:     Carlos Bilbao <carlos.bilbao@amd.com>
Cc:     bp@alien8.de, tglx@linutronix.de, mingo@redhat.com,
        dave.hansen@linux.intel.com, x86@kernel.org,
        linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org,
        bilbao@vt.edu
Subject: Re: [PATCH 2/2] x86/mce: Add messages for panic errors in AMD's MCE
 grading
Message-ID: <YlLWUlt1V0lx52a8@yaz-ubuntu>
References: <20220405183212.354606-1-carlos.bilbao@amd.com>
 <20220405183212.354606-3-carlos.bilbao@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220405183212.354606-3-carlos.bilbao@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PmpYzyeNxD8dpl7GAeAseizGqZBfLHJZMVbZSdedW5JIieFQteCH1cWjQR11?=
 =?us-ascii?Q?1sBmbhlBjaFwtR+V0XHKhpVJkmWUKy0F4d/ycFI3Z7aypesSV4+PadlXjM8y?=
 =?us-ascii?Q?v3nmBl9qwZqTo0VPVoLZDwTeIxFuk64gP5WPyRSBH4CfaGNdh+ThTFQpcRg4?=
 =?us-ascii?Q?13HTLHH4PLt9Ew6Qdax4Z4IrtuCycvhg8Av0CG1xMNW3ARp6lAZ8F9ls91eT?=
 =?us-ascii?Q?mgMY0MZwlNRBKRVapZQIC1NkQiareiGDOFTl0ffKv62yEXLAMgG7nEWJmZ84?=
 =?us-ascii?Q?YXANCuhwdCRx7PDA3REH5XOL4eukgfyTCGRm3ftT0RO8yzn9HhZcalXR7IRF?=
 =?us-ascii?Q?e+deftvgo6V/c4VCVKJQ9KlFKwJV+HilfhNCfm/qtvA/vRvOOpxcpN3sd5KD?=
 =?us-ascii?Q?htxYXTUhxfYjSgg3EonTt/uwXQeBWJVmhvQSuzJ4TavucKkPgS5re/0WBtlg?=
 =?us-ascii?Q?OIbVeQEBzNPwX/inRTNyUpG6Azl0UHQaFgvEb++euwwLkkQ+4/QfEys2gNuJ?=
 =?us-ascii?Q?5j4T33pS+wImuVTTxeKDQhJMFKWRWXBwEFy640x898flUSF3hsFjehj0FwA1?=
 =?us-ascii?Q?EZAjAYuA/KdH+5SX34AI5srSYmeEtpJJFIBIxU46eEd1Ydt0d+8i5q8XbKSm?=
 =?us-ascii?Q?oMj1TYgFWZUgWD+Ns4j2GwCvRz7juVotrXsbE1JVxD149mQMTjq+ptAVvur8?=
 =?us-ascii?Q?r/tfUH1VdGcchu5d8g4Jxf9qdO2UmKhnctceQh2SBFoGU8BfCvcS6492DLMc?=
 =?us-ascii?Q?huzGpQWNXk/HKa91EOO/FV0zIsityfjBO4frk6F6GA1sFQRBPJD7uhEFyWlQ?=
 =?us-ascii?Q?+mYeJ8cK5KlsV5PxL9jeM0PlqHx1ZyxjhBV7eDPUmuoZidTulAdeJ5HrCPPo?=
 =?us-ascii?Q?Y3P91sDTZrP8SVxzMK3JjiAagz6ZbOlW/DNXvozHAiIhVNrCbbAL/Oo9b78x?=
 =?us-ascii?Q?dO3ZwCFcQUP+tbOjsdfwmSMJ7d9XQTkS4BoEidzR33SXu4eV5Hwm9+OTV/Z5?=
 =?us-ascii?Q?f5L3aa6iY3xZvhvxJgrIaAD75zrPlLT+8n6PjKhIopLd8/nhU9BlazJtEFf0?=
 =?us-ascii?Q?fSq2kcQ6Gc1UBrNfW79qmBeyn6lzXk4jSaAo7Vbjj4saEAsOZA8gi9q/BTZ6?=
 =?us-ascii?Q?TQCzQhwMQacCG1PjO4io7AMXO2NoOVkco4VajIRXgHhVzlMphuHfdgZapnZG?=
 =?us-ascii?Q?bfc0UWLf39KUZbDcW92jE0McjjjZuZtNkEUG7pFOn2q/VeeKPcqjick/RN32?=
 =?us-ascii?Q?1zs6BFwg+/EbPz6apcWiB16v/eEwkCjg1mZNU/m7bH/BbIaJWbfmP2mdxf4a?=
 =?us-ascii?Q?G2kuqI40tmq5zWJ3uVSmWLd5mPO0znkpYztCjJjjfwcrCQfgVb9w+cV0wMvK?=
 =?us-ascii?Q?k1SHz/k7JN/0TEXUumUIea8nNy7kbRBAi8xHhAbMef0SRTCzufHye86IH29c?=
 =?us-ascii?Q?n0il0tQNqrHVcX+aLdro+RYsG4k2zsusRCWOLmGXjteS67PnhxQmXpAoTomW?=
 =?us-ascii?Q?sISCasIycfY53T6ZzUs2zRCWNm49ERP1c2bK1rRBLdWvJ2Tc0EbR+upCuorO?=
 =?us-ascii?Q?dSrpifbD39DuddRZTk2AhaAhS1kjKomSfTx6tRmgK2I6dPLYvpKlLtGKWn5S?=
 =?us-ascii?Q?9eZxTCMCBdPsUO78q1DZ68/ZnIjLHaz9ovSQzrWOyDn8IJ2Sz9MmcffvOb/W?=
 =?us-ascii?Q?8ikUTBolybeIPYDjFOESx+/ZzMw7VmN1HVfsuCR64l2QU6xwaQLSFE4igaRu?=
 =?us-ascii?Q?Bv1DXsHIDQ=3D=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a441b3cf-652d-4438-ee29-08da1af2ee18
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2022 13:06:30.6771
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BMFmuWbkgnF308L4fsp/eeEwhgMfF6C90IDkpJImVjCW7OC1OMjfvvB45QQt6sda9CDRvZgsiD1d6tFPWG90kw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB3681
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Apr 05, 2022 at 01:32:14PM -0500, Carlos Bilbao wrote:
> When a machine error is graded as PANIC by AMD grading logic, the MCE
> handler calls mce_panic(). The notification chain does not come into effect
> so the AMD EDAC driver does not decode the errors. In these cases, the
> messages displayed to the user are more cryptic and miss information
> that might be relevant, like the context in which the error took place.
> 
> Fix the above issue including messages on AMD's grading logic for machine
> errors graded as PANIC.
> 
> Signed-off-by: Carlos Bilbao <carlos.bilbao@amd.com>
> ---

Reviewed-by: Yazen Ghannam <yazen.ghannam@amd.com>

Thanks!

-Yazen