Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3b26a4e2-93a8-8b3f-20c3-c1593ea0d48b@lenbrook.com>
Date:   Sun, 10 Apr 2022 18:28:03 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] dmaengine: imx-sdma: fix regression with uart scripts
Content-Language: en-US
To:     Vinod Koul <vkoul@kernel.org>
Cc:     Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Lucas Stach <l.stach@pengutronix.de>,
        Robin Gong <yibin.gong@nxp.com>, dmaengine@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20220406224809.29197-1-kgroeneveld@lenbrook.com>
 <YlBzQpWEqMHz/HsU@matsya>
From:   Kevin Groeneveld <kgroeneveld@lenbrook.com>
In-Reply-To: <YlBzQpWEqMHz/HsU@matsya>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VUtVWTFsOFNpbThyWDlaSlRDdXpYUFl4aVBNZUpaTGVxallEeUlCMGVwQVps?=
 =?utf-8?B?S3RaZjB3K01mMENqU1lsZmlUSG04TE1ZYUlXU0hOZXZIajRmK1cyeE1zRENR?=
 =?utf-8?B?ZVlaalY2OUdBWE1yQyt3dlhmTEViZERSTTdBNStjeDJOb1pMVGZWTGFwWVVQ?=
 =?utf-8?B?ZGt6Um9iOTRPTDdVbkxpdzVyQ3BscU1Gd2Frc09vTkFybWpaT0FWTFNxN0oz?=
 =?utf-8?B?V1o2NW96bjVXS1lvdlRSR0JSNUNicEFyaFVYOTM3Zm1ZVzRyQkUxKzQxZ0RL?=
 =?utf-8?B?UGdIQVMyZHRMNkQ2TFZOMWxjeWhBTTdjR0k0dUwxOCtEZlJEY2xCdGNzcjR5?=
 =?utf-8?B?a05zRHVpWnYxS2thbW1XQXVmZEl1V1ArcDZSQUIzNVQxcDdUZS9mWmRYbnRs?=
 =?utf-8?B?ZEl5OWtuZEZhQitvb3MvWWF4cnphblZRaGdZLzIyRDBmSjFzMkxjVHZLTC9P?=
 =?utf-8?B?V0RZQ3orQWNZakROTmM0bGVuT0djejc3RGNVTjFXNklEZ09iM2FKNnhvZ0ND?=
 =?utf-8?B?UGJGV1VlTVhBbDVyT1BKVDVlN0F1eHdQbVNtSk9rYlB2c2RHZDZ6N2dZKzZB?=
 =?utf-8?B?YjBycXhjYXU2N1FJMXBuTys3NnkyYWt2bUJUczNUci9mWmc4czhjWUNYZ25X?=
 =?utf-8?B?NlRhUGxsZFp2c2l3cDFsQjNvZTQ3dWd6Z3NJeElBK1Y5aWVGUklnUTJCb0p5?=
 =?utf-8?B?RWxHRjNzV2YwNGZ0bXdoa3R4WkFjWjhZck13cHVUTGpCSnJrcndNZHhkZlEy?=
 =?utf-8?B?eFBWcVNaTkw1Szl6ZVVGZXByWUZTaWhUQzl6RGxhdjB1T1VWdFZ5Unh2c3Ji?=
 =?utf-8?B?WDRQWEdPV2JMdlBKUkQwaW9qMDVEd2Nka3NndUJ6TjlzNU1TN1M5ZDNNRmE5?=
 =?utf-8?B?OVZhOStXUmFpQTZOcHkxMVBwdlI2a2RnWlNtdDVzNUJaMnFvQVZyc1ZoRFpl?=
 =?utf-8?B?amdBZnpiejJXeGtCK3RjVDdvVnVHVUduNWphT3dVWXhiMWlCamxlYzJIN2J5?=
 =?utf-8?B?SW9YVmtFUnZLM0JXSUVlR1lmQzlSamZhUjBjTUluL3pBTHpzb011QmxLUUR1?=
 =?utf-8?B?MXZHNVdEekhkU2tBa2VXTktaZGlyNlltak5Vek41N29yNGFJdDhnRDEyNWZW?=
 =?utf-8?B?MHllYTg2MkcyUmZDd0VMOGhoeWJ3aDdzZ2E4bkE3eUVaWW5idGxHK294SXpS?=
 =?utf-8?B?MzNZbGQwOG9TTkhXUlNqSHhnOUh1S2pyaDE3UVlzYkExOFU1WWJMbStNMmx1?=
 =?utf-8?B?Z0F0NElLMFZpTFNvdEhVWFhCSUM3MUNpR3R3NXFUbjNOU01JdjBCSWpCZlBF?=
 =?utf-8?B?ZFpIVXJhQ3hiNnd5NVpYeVdQeUx1ek9iaTMzd3JabTg5UWNNdmNiWTJScDQ4?=
 =?utf-8?B?SUJMYnFnTXJRZFMxdEFRS3RqZFVIbFB0c0pGNnlaVmdpVVBzVE5kTGFORmpn?=
 =?utf-8?B?czlGTzRsUFJYVHRaOTByRDVVNW1SU3Vhd0RuVENZNFlzWVhSaFhOK3h1enRC?=
 =?utf-8?B?WnJwa2tQSDRUa2xjUDBPRWk5K253VWFYbE4yT043Z2pDKzVYYW5SY3hZVUtW?=
 =?utf-8?B?V3B0djFnSkxJRS9VN3BKODVkUGd6QmVISXpXRU91T2dYMUhLZWo5dSt5WWFB?=
 =?utf-8?B?VWFQVDJxMjhHRkV5WDVnYjFZUzZ6V2NNbkNCMHR1dHlWQTRNb1Z4c2RTUzls?=
 =?utf-8?B?Ri9tZ1BGTjRjK0V2djFlVkJnTjNZb2NQanlwb0Y4Y0R4RUdUYytGbS9lakxv?=
 =?utf-8?B?NTlZdENOcUxqVkZ4Z0NJRXhyeHBIajJFWExhblZnRDNyK0lHV1dPdzVoQzJG?=
 =?utf-8?B?bUVoYUZFcEhLL0p0RmJ4S0NHWkRsVEViRVBhRzNIOUt0SUtySDR6dGFzTVF0?=
 =?utf-8?B?ZWkyeGpib1hQZ1E3WWpzMnRLYnRRT2JFOHkwdWNqMkpScmZaVmtqMmoyekdk?=
 =?utf-8?B?eXExWEplWlE0ajA0UEhhc2NVbWc5cGZjV1ljRDlEbDhRdXlLamIzRHZUcDNy?=
 =?utf-8?B?MzRCRHhqaDNZQnRqQzFkWkl5WUZ0LzdESWMrWUdkMlhpZjROS3JTK1dMdTBz?=
 =?utf-8?B?MWV0QjFYZk1kSjI3cWpHUlhJajUrZmV0cVZIMnIvN011YkNSempaN0hhTVZC?=
 =?utf-8?B?WGJra2MyWlV2RS9wY24wemVCNDZKcnBRazZ4anRuMk1lNWNmU1ZYNTV0RE9w?=
 =?utf-8?B?YmlzTGNhc2hTSncvQUQ2VlEvd1NKdFVTZ2w3NHF5L1lNL3BPdUxOLzdrWmZs?=
 =?utf-8?B?NWYrNmlkNm5qQS9DNllJdGIrY1VDemErV3RlT3V3SVZvcWlwKy9IUG52eW84?=
 =?utf-8?B?czFhRnY0cFc0Z1g1bkR1bVNRZ3hWTDEvd0xOTTNrRlBvYTZZM1ZPK05MSGsz?=
 =?utf-8?Q?hk8lkr4qPN8f1YvU=3D?=
X-OriginatorOrg: lenbrook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 733ab89f-7017-4a49-75c1-08da1b4161a7
X-MS-Exchange-CrossTenant-AuthSource: YT4PR01MB9670.CANPRD01.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2022 22:28:05.2784
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3089fb55-f9f3-4ac8-ba44-52ac0e467cb6
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wJAf7mRJwsDlnluqll5twn0WncEWO/hfqxRCFYVdFbmwnWBh+mgWNqSicx7t8zfadPPJY3mRz8300MOBng9tx0iwjUIh+mKdjIFok9L2JiU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQBPR0101MB8160
X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2022-04-08 13:39, Vinod Koul wrote:
> 1. Patch title should reflect the change introduced, so the title is not
> apt, pls revise

In hindsight the title was not very descriptive. I will update and send 
a v2. Maybe something like:

dmaengine: imx-sdma: fix init of uart scripts

> 2. Is this in response to rmk's report, if so, please add reported-by

No. I am not even aware of any report on this issue. I discovered the 
issue on my own and found the problem commit by doing a bisect.

> 3. Lastly, I would like to see some tested by for this patch..

I have tested on imx5, imx6 and imx8 systems. I will add some brief 
details of this to the commit message in the v2 patch. I am not sure if 
I as the author should include a Tested-by tag.

>> Fixes: b98ce2f4e32b ("dmaengine: imx-sdma: add uart rom script")
> 
> cc: stable ?

That sounds reasonable. I am relatively new to submitting kernel patches 
and that thought never crossed by mind.


Kevin