Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4c2b304e-385e-8550-eefe-50d4da889048@infradead.org>
Date:   Fri, 8 Apr 2022 21:33:46 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v3] drm/gma500: depend on framebuffer
Content-Language: en-US
To:     James Hilliard <james.hilliard1@gmail.com>,
        dri-devel@lists.freedesktop.org
Cc:     Patrik Jakobsson <patrik.r.jakobsson@gmail.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>, linux-kernel@vger.kernel.org
References: <20220409042321.3184493-1-james.hilliard1@gmail.com>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20220409042321.3184493-1-james.hilliard1@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi--

On 4/8/22 21:23, James Hilliard wrote:
> Select the efi framebuffer if efi is enabled.
> 
> This appears to be needed for video output to function correctly.
> 
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>

Acked-by: Randy Dunlap <rdunlap@infradead.org>

> ---
> Changes v2 -> v3:
>   - select EFI_FB instead of depending on it
> Changes v1 -> v2:
>   - use depends instead of select
> ---
>  drivers/gpu/drm/gma500/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/gma500/Kconfig b/drivers/gpu/drm/gma500/Kconfig
> index 0cff20265f97..a422fa84d53b 100644
> --- a/drivers/gpu/drm/gma500/Kconfig
> +++ b/drivers/gpu/drm/gma500/Kconfig
> @@ -2,11 +2,13 @@
>  config DRM_GMA500
>  	tristate "Intel GMA500/600/3600/3650 KMS Framebuffer"
>  	depends on DRM && PCI && X86 && MMU
> +	depends on FB
>  	select DRM_KMS_HELPER
>  	# GMA500 depends on ACPI_VIDEO when ACPI is enabled, just like i915
>  	select ACPI_VIDEO if ACPI
>  	select BACKLIGHT_CLASS_DEVICE if ACPI
>  	select INPUT if ACPI

That "select INPUT" is really bad -- but not your problem.
In the entire kernel tree there are only 3 drivers that select INPUT,
and they are all in drivers/gpu/drm/.

> +	select FB_EFI if EFI
>  	help
>  	  Say yes for an experimental 2D KMS framebuffer driver for the
>  	  Intel GMA500 (Poulsbo), Intel GMA600 (Moorestown/Oak Trail) and

thanks.
-- 
~Randy