Received: by 2002:a05:6a10:87d6:0:0:0:0 with SMTP id g22csp637895pxr; Mon, 11 Apr 2022 03:23:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyVJaZ55C1p1B+JMrRaOfB/xBb0A62JIK8f4nfjYzqJX5HIXSKjGM7KBYRgVH1Btp2T6iYI X-Received: by 2002:a05:6a00:a0e:b0:4fd:fa6e:95fc with SMTP id p14-20020a056a000a0e00b004fdfa6e95fcmr32032872pfh.17.1649672620708; Mon, 11 Apr 2022 03:23:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649672620; cv=none; d=google.com; s=arc-20160816; b=dAAky6FQwH0cOU3lSr2k5jOSVs45mJazXA8MECwQqyfyyCaWstIpBxuPFFkz3JPeHm KTXD/cqVmVC+OvY0zMm80J9GfFAyv4UlunDDWwJHu3voYdRnS6xJnAAhkBg3nIds968A HAPc9FdTdCcuycXFDMsfEOjb2/jj+VlMfwLpdxyJhQNEVX06pStzcVA/hZyHJ42iXGET rVm/rPPdnZKnkx4NGPwhjODRjA64Wmnih/whGHQyPcAt1qi5327YsX11NrvnfF8G+W95 Warz9g7D4Da7tXry22akfaakGCRPYDkL3mUZ3wNzYpbJGkqIu3F2gvdDQ2n5P5iFqUmc EfrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=zfYoWyY6QfQtb8bxfVeguiwMYK3ggvVgjjoGQTQ3uvo=; b=AL+GUJnU0MojAfZG2ABZBqmxLZU6HO9CMOxT7R4pwMCe5E9/RqToTCt3g+wxCXK0nh jMJm0IhG5EQGYFneQKH8VfGVmJomF25zx2KuLMd0PkkM8JK3BgVK19DRD1CylxmUVQxJ tPviZukoHKJ+NZtVyU+le7inoPoNBzFYf4Rg3PLg7VC/wbp4rJUa86tK1pT9Pn59DAqW T8ode5yO7b8Cf/5h36cJcoyidmZf5oQBmwcJtYK+ssk4O6TDdDuzmLvkM7ERHrSJwro1 vW7GRLKBcsSEhMRYllyDnynv6W35gKHgWz65s7XvyGZEgCjrSrAyRcuOlmpufGZ1q5tI tn9w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n12-20020a6546cc000000b003991d7cd361si8531272pgr.622.2022.04.11.03.23.27; Mon, 11 Apr 2022 03:23:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244236AbiDKBez (ORCPT + 99 others); Sun, 10 Apr 2022 21:34:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48552 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239660AbiDKBey (ORCPT ); Sun, 10 Apr 2022 21:34:54 -0400 Received: from mail.meizu.com (unknown [14.29.68.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C864435DCF; Sun, 10 Apr 2022 18:32:41 -0700 (PDT) Received: from IT-EXMB-1-125.meizu.com (172.16.1.125) by mz-mail04.meizu.com (172.16.1.16) with Microsoft SMTP Server (TLS) id 14.3.487.0; Mon, 11 Apr 2022 09:32:39 +0800 Received: from meizu.meizu.com (172.16.137.70) by IT-EXMB-1-125.meizu.com (172.16.1.125) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.14; Mon, 11 Apr 2022 09:32:39 +0800 From: Haowen Bai To: Edward Cree , Martin Habets , "David S. Miller" , "Jakub Kicinski" , Paolo Abeni CC: Haowen Bai , , Subject: [PATCH V2] sfc: ef10: Fix assigning negative value to unsigned variable Date: Mon, 11 Apr 2022 09:32:37 +0800 Message-ID: <1649640757-30041-1-git-send-email-baihaowen@meizu.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [172.16.137.70] X-ClientProxiedBy: IT-EXMB-1-126.meizu.com (172.16.1.126) To IT-EXMB-1-125.meizu.com (172.16.1.125) X-Spam-Status: No, score=0.9 required=5.0 tests=BAYES_00,MAY_BE_FORGED, SPF_HELO_NONE,SPF_SOFTFAIL,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org fix warning reported by smatch: 251 drivers/net/ethernet/sfc/ef10.c:2259 efx_ef10_tx_tso_desc() warn: assigning (-208) to unsigned variable 'ip_tot_len' Signed-off-by: Haowen Bai --- V1->V2: to assign "0x10000 - EFX_TSO2_MAX_HDRLEN" is the actual semantics of the value. drivers/net/ethernet/sfc/ef10.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/sfc/ef10.c b/drivers/net/ethernet/sfc/ef10.c index 50d535981a35..c9ee5011803f 100644 --- a/drivers/net/ethernet/sfc/ef10.c +++ b/drivers/net/ethernet/sfc/ef10.c @@ -2256,7 +2256,7 @@ int efx_ef10_tx_tso_desc(struct efx_tx_queue *tx_queue, struct sk_buff *skb, * guaranteed to satisfy the second as we only attempt TSO if * inner_network_header <= 208. */ - ip_tot_len = -EFX_TSO2_MAX_HDRLEN; + ip_tot_len = 0x10000 - EFX_TSO2_MAX_HDRLEN; EFX_WARN_ON_ONCE_PARANOID(mss + EFX_TSO2_MAX_HDRLEN + (tcp->doff << 2u) > ip_tot_len); -- 2.7.4