Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220411014039.3368218-1-peng.fan@oss.nxp.com>
In-Reply-To: <20220411014039.3368218-1-peng.fan@oss.nxp.com>
From:   Jason Wang <jasowang@redhat.com>
Date:   Mon, 11 Apr 2022 16:52:30 +0800
Message-ID: <CACGkMEtnXPBvv1W8SdT0Hv4riShQP3Du+EMv0XNgOGNmmfS6ng@mail.gmail.com>
Subject: Re: [PATCH] tools/virtio: drop phys_addr_t typedef
To:     "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc:     mst <mst@redhat.com>,
        virtualization <virtualization@lists.linux-foundation.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Peng Fan <peng.fan@nxp.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Apr 11, 2022 at 9:39 AM Peng Fan (OSS) <peng.fan@oss.nxp.com> wrote=
:
>
> From: Peng Fan <peng.fan@nxp.com>
>
> With commit 884ee1e585ca ("tools/include: Add phys_addr_t to types.h"),
>
> When building virtio tools, there is a type conficting error:
>
> "
> ./linux/kernel.h:32:28: error: conflicting types for =E2=80=98phys_addr_t=
=E2=80=99
>    32 | typedef unsigned long long phys_addr_t;
>       |                            ^~~~~~~~~~~
> In file included from /usr/include/linux/virtio_blk.h:28,
>                  from virtio-ivshmem-block.c:29:
> ../include/linux/types.h:69:13: note: previous declaration of =E2=80=98ph=
ys_addr_t=E2=80=99 was here
>    69 | typedef u32 phys_addr_t;
>       |             ^~~~~~~~~~~
> "
>
> Let's drop the typedef in tools/virtio/linux/kernel.h
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>

Acked-by: Jason Wang <jasowang@redhat.com>

> ---
>  tools/virtio/linux/kernel.h | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/tools/virtio/linux/kernel.h b/tools/virtio/linux/kernel.h
> index 0b493542e61a..1d3248e3f270 100644
> --- a/tools/virtio/linux/kernel.h
> +++ b/tools/virtio/linux/kernel.h
> @@ -29,7 +29,6 @@
>  #define READ                    0
>  #define WRITE                   1
>
> -typedef unsigned long long phys_addr_t;
>  typedef unsigned long long dma_addr_t;
>  typedef size_t __kernel_size_t;
>  typedef unsigned int __wsum;
> --
> 2.25.1
>